[PATCH 06/12] frame-xchg: set allow multicast flag

[PATCH 06/12] frame-xchg: set allow multicast flag

[James Prestwood]

[-- Attachment #1: Type: text/plain, Size: 656 bytes --]

Receiving multicast frames is required by DPP
---
 src/frame-xchg.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/frame-xchg.c b/src/frame-xchg.c
index 5ba36081..95c030d8 100644
--- a/src/frame-xchg.c
+++ b/src/frame-xchg.c
@@ -611,6 +611,7 @@ bool frame_watch_add(uint64_t wdev_id, uint32_t group_id, uint16_t frame_type,
 
 	l_genl_msg_append_attr(msg, NL80211_ATTR_WDEV, 8, &wdev_id);
 	l_genl_msg_append_attr(msg, NL80211_ATTR_FRAME_TYPE, 2, &frame_type);
+	l_genl_msg_append_attr(msg, NL80211_ATTR_RECEIVE_MULTICAST, 0, NULL);
 	l_genl_msg_append_attr(msg, NL80211_ATTR_FRAME_MATCH,
 				prefix_len, prefix);
 
-- 
2.31.1

Re: [PATCH 06/12] frame-xchg: set allow multicast flag

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 890 bytes --]

Hi James,

On 1/18/22 15:25, James Prestwood wrote:
> Receiving multicast frames is required by DPP
> ---
>   src/frame-xchg.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/src/frame-xchg.c b/src/frame-xchg.c
> index 5ba36081..95c030d8 100644
> --- a/src/frame-xchg.c
> +++ b/src/frame-xchg.c
> @@ -611,6 +611,7 @@ bool frame_watch_add(uint64_t wdev_id, uint32_t group_id, uint16_t frame_type,
>   
>   	l_genl_msg_append_attr(msg, NL80211_ATTR_WDEV, 8, &wdev_id);
>   	l_genl_msg_append_attr(msg, NL80211_ATTR_FRAME_TYPE, 2, &frame_type);
> +	l_genl_msg_append_attr(msg, NL80211_ATTR_RECEIVE_MULTICAST, 0, NULL);

Should this be opt-in?  You may want to audit all uses of frame_watch_add to see 
if they can deal with multicast frames.

>   	l_genl_msg_append_attr(msg, NL80211_ATTR_FRAME_MATCH,
>   				prefix_len, prefix);
>   
> 

Regards,
-Denis

Re: [PATCH 06/12] frame-xchg: set allow multicast flag

[James Prestwood]

[-- Attachment #1: Type: text/plain, Size: 1271 bytes --]

On Thu, 2022-01-20 at 14:17 -0600, Denis Kenzior wrote:
> Hi James,
> 
> On 1/18/22 15:25, James Prestwood wrote:
> > Receiving multicast frames is required by DPP
> > ---
> >   src/frame-xchg.c | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/src/frame-xchg.c b/src/frame-xchg.c
> > index 5ba36081..95c030d8 100644
> > --- a/src/frame-xchg.c
> > +++ b/src/frame-xchg.c
> > @@ -611,6 +611,7 @@ bool frame_watch_add(uint64_t wdev_id, uint32_t
> > group_id, uint16_t frame_type,
> >   
> >         l_genl_msg_append_attr(msg, NL80211_ATTR_WDEV, 8,
> > &wdev_id);
> >         l_genl_msg_append_attr(msg, NL80211_ATTR_FRAME_TYPE, 2,
> > &frame_type);
> > +       l_genl_msg_append_attr(msg, NL80211_ATTR_RECEIVE_MULTICAST,
> > 0, NULL);
> 
> Should this be opt-in?  You may want to audit all uses of
> frame_watch_add to see 
> if they can deal with multicast frames.

I can make it dependent on a bool argument. Better than unnecissarily
passing on broadcasts to modules that don't care.

> 
> >         l_genl_msg_append_attr(msg, NL80211_ATTR_FRAME_MATCH,
> >                                 prefix_len, prefix);
> >   
> > 
> 
> Regards,
> -Denis