Re: [PATCH] wiphy: include libgen.h to fix implicit def. with musl libc

[Clayton Craft <clayton@craftyguy.net>]

[-- Attachment #1: Type: text/plain, Size: 1271 bytes --]

Hi Denis,

On Tue, 13 Feb 2024 17:09:19 -0600 Denis Kenzior <denkenz@gmail.com> wrote:
> Hmm, why did musl do that?  man 3 basename indicates that the libgen.h version 
> implementation is free to scratch in the input argument, while the string.h one 
> doesn't.

From what I can tell, they added it here[1] to appease apps expecting the GNU
libc string.h:basename, and removed it here[2] because C23 drops non-proto
declarations?
Also I think it's not POSIX C compliant, so maybe some of the motivation for
musl to drop it? I'm just speculating though...

1. https://git.musl-libc.org/cgit/musl/commit/?id=06aec8d7152dfb8360cb7ed9b3d7215ca0b0b500
2. https://git.musl-libc.org/cgit/musl/commit/?id=725e17ed6dff4d0cd22487bb64470881e86a92e7

> In this particular case it doesn't matter since driver_path is never used again. 
>   Still, the string.h version is much more intuitive.

Ahh ok I understand, thanks for explaining the differences.

> Maybe this should be re-implemented in missing.h or ell (say l_file_basename or 
> l_dir_basename) instead?

I'd defer to y'all on what the right path forward is here, since I'm really not
familiar with the code base here. I'd like to see this fixed somehow, so I'm
happy to try implementing something you recommend.

-Clayton

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]