Re: [PATCH] wiphy: include libgen.h to fix implicit def. with musl libc

[Denis Kenzior <denkenz@gmail.com>]

Hi Clayton,

On 2/12/24 12:47, Clayton Craft wrote:
> This fixes a runtime segfault with musl libc and GCC13. musl dropped a
> basename prototype[1] in string.h, causing GCC to define it implicitly
> with the wrong function signature. The correct basename definition based
> on how wiphy uses it is in libgen.h.

Hmm, why did musl do that?  man 3 basename indicates that the libgen.h version 
implementation is free to scratch in the input argument, while the string.h one 
doesn't.

In this particular case it doesn't matter since driver_path is never used again. 
  Still, the string.h version is much more intuitive.

Maybe this should be re-implemented in missing.h or ell (say l_file_basename or 
l_dir_basename) instead?

> 
> For context, see:
> https://gitlab.alpinelinux.org/alpine/aports/-/issues/15622
> 
> 1. https://git.musl-libc.org/cgit/musl/commit/?id=725e17ed6dff4d0cd22487bb64470881e86a92e7
> ---
>   src/wiphy.c | 1 +
>   1 file changed, 1 insertion(+)
> 

Regards,
-Denis