Re: [PATCH] wiphy: include libgen.h to fix implicit def. with musl libc

[Clayton Craft <clayton@craftyguy.net>]

[-- Attachment #1: Type: text/plain, Size: 990 bytes --]

On Wed, 14 Feb 2024 17:52:43 +0100 Marcel Holtmann <marcel@holtmann.org> wrote:
> Hi Denis,
> 
> >>>> Add a _get_driver is a good idea as well, but what is the reason for l_sysctl since sysctl is some specific system call.
> >>> 
> >>> l_sysctl is used to write stuff into procfs or sysfs.  Naming comes from the sysctl(8) utility.
> >> actually no. sysctl just handles /proc/sys/. It has nothing to do with sysfs.
> > 
> > You're right about sysctl.  ell used the same naming since it was meant to control net/ipv* kernel parameters.  However, the same API can be used inside sysfs since the semantics are identical.
> > 
> > If you don't like l_sysctl_get_driver, then lets call it l_sysfs_get_driver().
> 
> yes, I would prefer l_sysfs_get_driver.

Thanks Marcel & Denis for the replies. It's not clear to me what needs to be
done to resolve the original issue I set out to fix with this patch. Could you
please summarize this so I (or someone else) could try to implement it?

-Clayton

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]