[PATCH] test-runner: use **kwargs for start_process

[PATCH] test-runner: use **kwargs for start_process

[James Prestwood]

[-- Attachment #1: Type: text/plain, Size: 1009 bytes --]

This is just a more concise/pythonic way of doing function arguments.
Since Process/start_process have basically the same argument names
we can simplify and use **kwargs which will pass the named arguments
directly to Process(). This also allows us to add arguments to Process
without touching start_process if we need.
---
 tools/test-runner | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/test-runner b/tools/test-runner
index a71b9ef6..d1e1d42c 100755
--- a/tools/test-runner
+++ b/tools/test-runner
@@ -465,10 +465,10 @@ class TestContext:
 		self.results = {}
 		self.mainloop = GLib.MainLoop()
 
-	def start_process(self, args, wait=False, multi_test=False, env=None, check=False):
-		p = Process(args, wait, multi_test, env, ctx=self, check=check)
+	def start_process(self, args, **kwargs):
+		p = Process(args, ctx=self, **kwargs)
 
-		if not wait:
+		if not kwargs.get('wait', False):
 			self.processes.append(p)
 
 		return p
-- 
2.26.2

Re: [PATCH] test-runner: use **kwargs for start_process

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 533 bytes --]

Hi James,

On 9/15/20 12:36 PM, James Prestwood wrote:
> This is just a more concise/pythonic way of doing function arguments.
> Since Process/start_process have basically the same argument names
> we can simplify and use **kwargs which will pass the named arguments
> directly to Process(). This also allows us to add arguments to Process
> without touching start_process if we need.
> ---
>   tools/test-runner | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 


Applied, thanks.

Regards,
-Denis