[patch] i40e: remove an unneeded check

[patch] i40e: remove an unneeded check

[Dan Carpenter]

We know "ret" is zero here.  No need to check again.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
index 28da412..2640004 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
@@ -1534,12 +1534,12 @@ static int i40e_add_del_fdir_ethtool(struct i40e_vsi *vsi,
 		return ret;
 	}
 
-	if (!ret && add)
+	if (add)
 		i40e_update_ethtool_fdir_entry(vsi, input, fsp->location, NULL);
 	else
 		kfree(input);
 
-	return ret;
+	return 0;
 }
 
 /**

Re: [patch] i40e: remove an unneeded check

[Jeff Kirsher]

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

On Fri, 2014-03-28 at 11:29 +0300, Dan Carpenter wrote:
> We know "ret" is zero here.  No need to check again.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks Dan, I have added your patch to my queue.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [patch] i40e: remove an unneeded check

[Jeff Kirsher]

[-- Attachment #1: Type: text/plain, Size: 674 bytes --]

On Fri, 2014-03-28 at 11:29 +0300, Dan Carpenter wrote:
> We know "ret" is zero here.  No need to check again.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Dan with the latest bunch of patches I just pushed and that Dave
accepted, the code changes which directly affect your patch to leaves
your patch only changing the return statement from:

return ret;

to 

return 0;

but with the recent change in the code, the ret value can be something
other than 0 so your patch does not appear to be needed any longer.

Can you double check my findings by taking a look at David Miller's
latest net-next tree to verify please?

Cheers,
Jeff

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [patch] i40e: remove an unneeded check

[Dan Carpenter]

On Fri, Mar 28, 2014 at 12:17:16PM -0700, Jeff Kirsher wrote:
> On Fri, 2014-03-28 at 11:29 +0300, Dan Carpenter wrote:
> > We know "ret" is zero here.  No need to check again.
> > 
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> Dan with the latest bunch of patches I just pushed and that Dave
> accepted, the code changes which directly affect your patch to leaves
> your patch only changing the return statement from:
> 
> return ret;
> 
> to 
> 
> return 0;
> 
> but with the recent change in the code, the ret value can be something
> other than 0 so your patch does not appear to be needed any longer.

Sure, yep.  It's not needed anymore.

regards,
dan carpenter