* [patch] Staging: rtl8192e: remove some dead code
@ 2012-04-17 6:45 Dan Carpenter
2012-04-17 17:39 ` Larry Finger
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-04-17 6:45 UTC (permalink / raw)
To: kernel-janitors
We don't use the rxcmdpkt[] counters at all and we can remove them.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h
index 2a2519c..cebb748 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h
@@ -353,7 +353,6 @@ struct rt_stats {
unsigned long rxrdu;
unsigned long rxok;
unsigned long rxframgment;
- unsigned long rxcmdpkt[8];
unsigned long rxurberr;
unsigned long rxstaterr;
unsigned long rxdatacrcerr;
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c
index 58d044e..ea91744 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c
@@ -342,7 +342,6 @@ static void cmpk_handle_tx_rate_history(struct net_device *dev, u8 *pmsg)
u32 cmpk_message_handle_rx(struct net_device *dev,
struct rtllib_rx_stats *pstats)
{
- struct r8192_priv *priv = rtllib_priv(dev);
int total_length;
u8 cmd_length, exe_cnt = 0;
u8 element_id;
@@ -409,8 +408,6 @@ u32 cmpk_message_handle_rx(struct net_device *dev,
return 1;
}
- priv->stats.rxcmdpkt[element_id]++;
-
total_length -= cmd_length;
pcmd_buff += cmd_length;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] Staging: rtl8192e: remove some dead code
2012-04-17 6:45 [patch] Staging: rtl8192e: remove some dead code Dan Carpenter
@ 2012-04-17 17:39 ` Larry Finger
0 siblings, 0 replies; 2+ messages in thread
From: Larry Finger @ 2012-04-17 17:39 UTC (permalink / raw)
To: kernel-janitors
On 04/17/2012 01:45 AM, Dan Carpenter wrote:
> We don't use the rxcmdpkt[] counters at all and we can remove them.
>
> Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>
>
ACKed-by: Larry Finger <Larry.Finger@lwfinger.net>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h
> index 2a2519c..cebb748 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h
> @@ -353,7 +353,6 @@ struct rt_stats {
> unsigned long rxrdu;
> unsigned long rxok;
> unsigned long rxframgment;
> - unsigned long rxcmdpkt[8];
> unsigned long rxurberr;
> unsigned long rxstaterr;
> unsigned long rxdatacrcerr;
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c
> index 58d044e..ea91744 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c
> @@ -342,7 +342,6 @@ static void cmpk_handle_tx_rate_history(struct net_device *dev, u8 *pmsg)
> u32 cmpk_message_handle_rx(struct net_device *dev,
> struct rtllib_rx_stats *pstats)
> {
> - struct r8192_priv *priv = rtllib_priv(dev);
> int total_length;
> u8 cmd_length, exe_cnt = 0;
> u8 element_id;
> @@ -409,8 +408,6 @@ u32 cmpk_message_handle_rx(struct net_device *dev,
> return 1;
> }
>
> - priv->stats.rxcmdpkt[element_id]++;
> -
> total_length -= cmd_length;
> pcmd_buff += cmd_length;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-17 17:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-17 6:45 [patch] Staging: rtl8192e: remove some dead code Dan Carpenter
2012-04-17 17:39 ` Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox