[nf-next:mmap-netlink 65/68] net/netfilter/nfnetlink_queue_core.c:407:23: warning: unused variable '

[nf-next:mmap-netlink 65/68] net/netfilter/nfnetlink_queue_core.c:407:23: warning: unused variable '

[Fengguang Wu]

Hi Florian,

There are new compile warnings show up in

tree:   git://150.214.188.80/nf-next mmap-netlink
head:   c7e7243d0b69e2323dde057c28f1102d00e5a3c6
commit: b55f8ac10d3ef4c4379afabaa1f766de4d81a8a5 [65/68] nfqueue: extend spinlocked section for mmap'd sockets

All warnings:

net/netfilter/nfnetlink_queue_core.c: In function 'nfqnl_enqueue_packet':
net/netfilter/nfnetlink_queue_core.c:407:23: warning: unused variable 'size' [-Wunused-variable]

vim +407 net/netfilter/nfnetlink_queue_core.c
   404		int err = -ENOBUFS;
   405		int failopen = 0;
   406		struct sk_buff *entskb = entry->skb;
 > 407		size_t data_len = 0, size;
   408	
   409		/* rcu_read_lock()ed by nf_hook_slow() */
   410		queue = instance_lookup(queuenum);

---
0-DAY kernel build testing backend         Open Source Technology Centre
Fengguang Wu <wfg@linux.intel.com>                     Intel Corporation

Re: [nf-next:mmap-netlink 65/68] net/netfilter/nfnetlink_queue_core.c:407:23: warning: unused variab

[Florian Westphal]

Fengguang Wu <fengguang.wu@intel.com> wrote:
> tree:   git://150.214.188.80/nf-next mmap-netlink
> head:   c7e7243d0b69e2323dde057c28f1102d00e5a3c6
> commit: b55f8ac10d3ef4c4379afabaa1f766de4d81a8a5 [65/68] nfqueue: extend spinlocked section for mmap'd sockets
> 
> All warnings:
> 
> net/netfilter/nfnetlink_queue_core.c: In function 'nfqnl_enqueue_packet':
> net/netfilter/nfnetlink_queue_core.c:407:23: warning: unused variable 'size' [-Wunused-variable]

Thanks for reporting.

Pablo, please consider squashing this in with the original patch
before submitting for inclusion:

From: Florian Westphal <fw@strlen.de>
Date: Fri, 13 Jul 2012 09:59:30 +0200
Subject: [PATCH] netfilter: nf_queue: kill unused variable

In function 'nfqnl_enqueue_packet':
warning: unused variable 'size' [-Wunused-variable]

caused by commit b55f8ac10d3ef4c4379afabaa1f766de4d81a8a5
(nfqueue: extend spinlocked section for mmap'd sockets)

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
---
 net/netfilter/nfnetlink_queue_core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/netfilter/nfnetlink_queue_core.c b/net/netfilter/nfnetlink_queue_core.c
index 82bcced..09c85d0 100644
--- a/net/netfilter/nfnetlink_queue_core.c
+++ b/net/netfilter/nfnetlink_queue_core.c
@@ -404,7 +404,7 @@ nfqnl_enqueue_packet(struct nf_queue_entry *entry, unsigned int queuenum)
 	int err = -ENOBUFS;
 	int failopen = 0;
 	struct sk_buff *entskb = entry->skb;
-	size_t data_len = 0, size;
+	size_t data_len = 0;
 
 	/* rcu_read_lock()ed by nf_hook_slow() */
 	queue = instance_lookup(queuenum);
-- 
1.7.3.4

Re: [nf-next:mmap-netlink 65/68] net/netfilter/nfnetlink_queue_core.c:407:23: warning: unused variab

[Pablo Neira Ayuso]

On Fri, Jul 13, 2012 at 10:37:19AM +0200, Florian Westphal wrote:
> Fengguang Wu <fengguang.wu@intel.com> wrote:
> > tree:   git://150.214.188.80/nf-next mmap-netlink
> > head:   c7e7243d0b69e2323dde057c28f1102d00e5a3c6
> > commit: b55f8ac10d3ef4c4379afabaa1f766de4d81a8a5 [65/68] nfqueue: extend spinlocked section for mmap'd sockets
> > 
> > All warnings:
> > 
> > net/netfilter/nfnetlink_queue_core.c: In function 'nfqnl_enqueue_packet':
> > net/netfilter/nfnetlink_queue_core.c:407:23: warning: unused variable 'size' [-Wunused-variable]
> 
> Thanks for reporting.
> 
> Pablo, please consider squashing this in with the original patch
> before submitting for inclusion:
> 
> From: Florian Westphal <fw@strlen.de>
> Date: Fri, 13 Jul 2012 09:59:30 +0200
> Subject: [PATCH] netfilter: nf_queue: kill unused variable
> 
> In function 'nfqnl_enqueue_packet':
> warning: unused variable 'size' [-Wunused-variable]
> 
> caused by commit b55f8ac10d3ef4c4379afabaa1f766de4d81a8a5
> (nfqueue: extend spinlocked section for mmap'd sockets)
> 
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Florian Westphal <fw@strlen.de>

Thanks Florian, I'll do.