* [pci:next 73/77] arch/x86/boot/compressed/eboot.c:283 setup_efi_pci() error: potentially derefencing
@ 2012-09-09 12:19 Fengguang Wu
2012-09-09 19:13 ` [pci:next 73/77] arch/x86/boot/compressed/eboot.c:283 setup_efi_pci() error: potentially derefen Dan Carpenter
2012-09-13 17:04 ` Bjorn Helgaas
0 siblings, 2 replies; 3+ messages in thread
From: Fengguang Wu @ 2012-09-09 12:19 UTC (permalink / raw)
To: kernel-janitors
Hi Matthew,
FYI, there are new smatch warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
head: 97ac9d1f363964dec7fbb20cf3c2e88336b4d801
commit: 66f2adcdadea18a583d4f7cbd773847d635731a3 [73/77] EFI: Stash ROMs if they're not in the PCI BAR
All smatch warnings:
+ arch/x86/boot/compressed/eboot.c:283 setup_efi_pci() error: potentially derefencing uninitialized 'pci_handle'.
+ arch/x86/boot/compressed/eboot.c:303 setup_efi_pci() warn: add some parenthesis here?
+ arch/x86/boot/compressed/eboot.c:303 setup_efi_pci() warn: maybe use && instead of &
arch/x86/boot/compressed/eboot.c:728 handle_ramdisks() error: potentially derefencing uninitialized 'fh'.
---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu <wfg@linux.intel.com> Intel Corporation
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [pci:next 73/77] arch/x86/boot/compressed/eboot.c:283 setup_efi_pci() error: potentially derefen
2012-09-09 12:19 [pci:next 73/77] arch/x86/boot/compressed/eboot.c:283 setup_efi_pci() error: potentially derefencing Fengguang Wu
@ 2012-09-09 19:13 ` Dan Carpenter
2012-09-13 17:04 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2012-09-09 19:13 UTC (permalink / raw)
To: kernel-janitors
On Sun, Sep 09, 2012 at 08:19:39PM +0800, Fengguang Wu wrote:
> Hi Matthew,
>
> FYI, there are new smatch warnings show up in
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
> head: 97ac9d1f363964dec7fbb20cf3c2e88336b4d801
> commit: 66f2adcdadea18a583d4f7cbd773847d635731a3 [73/77] EFI: Stash ROMs if they're not in the PCI BAR
>
> All smatch warnings:
>
> + arch/x86/boot/compressed/eboot.c:283 setup_efi_pci() error: potentially derefencing uninitialized 'pci_handle'.
These warnings probably have too high of a false positive rate to be
worth emailing about. Although this one looks like a real bug. We
should be passing "&pci_handle" to efi_call_phys5 instead of
"pci_handle".
I'm not sure why GCC doesn't warn about these. Anyway, it's because
GCC didn't warn about unitialized variables that I added it to
Smatch.
> + arch/x86/boot/compressed/eboot.c:303 setup_efi_pci() warn: add some parenthesis here?
> + arch/x86/boot/compressed/eboot.c:303 setup_efi_pci() warn: maybe use && instead of &
These are real but they duplicate Sparse warnings. :/
> arch/x86/boot/compressed/eboot.c:728 handle_ramdisks() error: potentially derefencing uninitialized 'fh'.
>
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [pci:next 73/77] arch/x86/boot/compressed/eboot.c:283 setup_efi_pci() error: potentially derefen
2012-09-09 12:19 [pci:next 73/77] arch/x86/boot/compressed/eboot.c:283 setup_efi_pci() error: potentially derefencing Fengguang Wu
2012-09-09 19:13 ` [pci:next 73/77] arch/x86/boot/compressed/eboot.c:283 setup_efi_pci() error: potentially derefen Dan Carpenter
@ 2012-09-13 17:04 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2012-09-13 17:04 UTC (permalink / raw)
To: kernel-janitors
Just a reminder that the EFI ROM patches are not in my next branch
yet. IIRC, there is a section mismatch issue as well as the one
below.
On Sun, Sep 9, 2012 at 1:13 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Sun, Sep 09, 2012 at 08:19:39PM +0800, Fengguang Wu wrote:
>> Hi Matthew,
>>
>> FYI, there are new smatch warnings show up in
>>
>> tree: git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
>> head: 97ac9d1f363964dec7fbb20cf3c2e88336b4d801
>> commit: 66f2adcdadea18a583d4f7cbd773847d635731a3 [73/77] EFI: Stash ROMs if they're not in the PCI BAR
>>
>> All smatch warnings:
>>
>> + arch/x86/boot/compressed/eboot.c:283 setup_efi_pci() error: potentially derefencing uninitialized 'pci_handle'.
>
> These warnings probably have too high of a false positive rate to be
> worth emailing about. Although this one looks like a real bug. We
> should be passing "&pci_handle" to efi_call_phys5 instead of
> "pci_handle".
>
> I'm not sure why GCC doesn't warn about these. Anyway, it's because
> GCC didn't warn about unitialized variables that I added it to
> Smatch.
>
>> + arch/x86/boot/compressed/eboot.c:303 setup_efi_pci() warn: add some parenthesis here?
>> + arch/x86/boot/compressed/eboot.c:303 setup_efi_pci() warn: maybe use && instead of &
>
> These are real but they duplicate Sparse warnings. :/
>
>> arch/x86/boot/compressed/eboot.c:728 handle_ramdisks() error: potentially derefencing uninitialized 'fh'.
>>
>
> regards,
> dan carpenter
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-13 17:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-09 12:19 [pci:next 73/77] arch/x86/boot/compressed/eboot.c:283 setup_efi_pci() error: potentially derefencing Fengguang Wu
2012-09-09 19:13 ` [pci:next 73/77] arch/x86/boot/compressed/eboot.c:283 setup_efi_pci() error: potentially derefen Dan Carpenter
2012-09-13 17:04 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox