* [patch 1/2] target: remove duplicate initialization
@ 2012-10-02 8:27 Dan Carpenter
2012-10-02 20:24 ` Nicholas A. Bellinger
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-10-02 8:27 UTC (permalink / raw)
To: kernel-janitors
We set bAlternateSetting to zero twice. I kept the second one
(.bAlternateSetting = USB_G_ALT_INT_BBB) because that's more
descriptive.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/usb/gadget/tcm_usb_gadget.c b/drivers/usb/gadget/tcm_usb_gadget.c
index 0a83801..1ad4a69 100644
--- a/drivers/usb/gadget/tcm_usb_gadget.c
+++ b/drivers/usb/gadget/tcm_usb_gadget.c
@@ -1956,7 +1956,6 @@ static void usbg_deregister_configfs(void)
static struct usb_interface_descriptor bot_intf_desc = {
.bLength = sizeof(bot_intf_desc),
.bDescriptorType = USB_DT_INTERFACE,
- .bAlternateSetting = 0,
.bNumEndpoints = 2,
.bAlternateSetting = USB_G_ALT_INT_BBB,
.bInterfaceClass = USB_CLASS_MASS_STORAGE,
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch 1/2] target: remove duplicate initialization
2012-10-02 8:27 [patch 1/2] target: remove duplicate initialization Dan Carpenter
@ 2012-10-02 20:24 ` Nicholas A. Bellinger
0 siblings, 0 replies; 2+ messages in thread
From: Nicholas A. Bellinger @ 2012-10-02 20:24 UTC (permalink / raw)
To: kernel-janitors
On Tue, 2012-10-02 at 11:27 +0300, Dan Carpenter wrote:
> We set bAlternateSetting to zero twice. I kept the second one
> (.bAlternateSetting = USB_G_ALT_INT_BBB) because that's more
> descriptive.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/usb/gadget/tcm_usb_gadget.c b/drivers/usb/gadget/tcm_usb_gadget.c
> index 0a83801..1ad4a69 100644
> --- a/drivers/usb/gadget/tcm_usb_gadget.c
> +++ b/drivers/usb/gadget/tcm_usb_gadget.c
> @@ -1956,7 +1956,6 @@ static void usbg_deregister_configfs(void)
> static struct usb_interface_descriptor bot_intf_desc = {
> .bLength = sizeof(bot_intf_desc),
> .bDescriptorType = USB_DT_INTERFACE,
> - .bAlternateSetting = 0,
> .bNumEndpoints = 2,
> .bAlternateSetting = USB_G_ALT_INT_BBB,
> .bInterfaceClass = USB_CLASS_MASS_STORAGE,
> --
Looks fine, applied to target-pending/for-next
Thanks Dan!
--nab
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-02 20:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-02 8:27 [patch 1/2] target: remove duplicate initialization Dan Carpenter
2012-10-02 20:24 ` Nicholas A. Bellinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox