* [patch] x86, efi: precedence error in setup_efi_pci()
@ 2012-12-07 6:16 Dan Carpenter
[not found] ` <20121207061649.GA18220-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2012-12-07 6:16 UTC (permalink / raw)
To: Matt Fleming, Matthew Garrett
Cc: H. Peter Anvin, Thomas Gleixner, Ingo Molnar,
x86-DgEjT+Ai2ygdnm+yROfE0A, linux-efi-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
Negate has higher precedence than bitwise AND so the condition is always
false.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c
index b1942e2..18e329c 100644
--- a/arch/x86/boot/compressed/eboot.c
+++ b/arch/x86/boot/compressed/eboot.c
@@ -302,7 +302,7 @@ static efi_status_t setup_efi_pci(struct boot_params *params)
if (status != EFI_SUCCESS)
continue;
- if (!attributes & EFI_PCI_IO_ATTRIBUTE_EMBEDDED_ROM)
+ if (!(attributes & EFI_PCI_IO_ATTRIBUTE_EMBEDDED_ROM))
continue;
if (!pci->romimage || !pci->romsize)
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch] x86, efi: precedence error in setup_efi_pci()
[not found] ` <20121207061649.GA18220-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
@ 2012-12-08 3:05 ` H. Peter Anvin
[not found] ` <50C2AE91.9060800-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: H. Peter Anvin @ 2012-12-08 3:05 UTC (permalink / raw)
To: Dan Carpenter
Cc: Matt Fleming, Matthew Garrett, Thomas Gleixner, Ingo Molnar,
x86-DgEjT+Ai2ygdnm+yROfE0A, linux-efi-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
On 12/06/2012 10:16 PM, Dan Carpenter wrote:
> Negate has higher precedence than bitwise AND so the condition is always
> false.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c
> index b1942e2..18e329c 100644
> --- a/arch/x86/boot/compressed/eboot.c
> +++ b/arch/x86/boot/compressed/eboot.c
> @@ -302,7 +302,7 @@ static efi_status_t setup_efi_pci(struct boot_params *params)
> if (status != EFI_SUCCESS)
> continue;
>
> - if (!attributes & EFI_PCI_IO_ATTRIBUTE_EMBEDDED_ROM)
> + if (!(attributes & EFI_PCI_IO_ATTRIBUTE_EMBEDDED_ROM))
> continue;
>
> if (!pci->romimage || !pci->romsize)
>
What is the baseline for this patch?
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] x86, efi: precedence error in setup_efi_pci()
[not found] ` <50C2AE91.9060800-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
@ 2012-12-10 8:44 ` Dan Carpenter
2013-01-11 13:52 ` Matt Fleming
0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2012-12-10 8:44 UTC (permalink / raw)
To: H. Peter Anvin
Cc: Matt Fleming, Matthew Garrett, Thomas Gleixner, Ingo Molnar,
x86-DgEjT+Ai2ygdnm+yROfE0A, linux-efi-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
On Fri, Dec 07, 2012 at 07:05:53PM -0800, H. Peter Anvin wrote:
> On 12/06/2012 10:16 PM, Dan Carpenter wrote:
> >Negate has higher precedence than bitwise AND so the condition is always
> >false.
> >
> >Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> >diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c
> >index b1942e2..18e329c 100644
> >--- a/arch/x86/boot/compressed/eboot.c
> >+++ b/arch/x86/boot/compressed/eboot.c
> >@@ -302,7 +302,7 @@ static efi_status_t setup_efi_pci(struct boot_params *params)
> > if (status != EFI_SUCCESS)
> > continue;
> >
> >- if (!attributes & EFI_PCI_IO_ATTRIBUTE_EMBEDDED_ROM)
> >+ if (!(attributes & EFI_PCI_IO_ATTRIBUTE_EMBEDDED_ROM))
> > continue;
> >
> > if (!pci->romimage || !pci->romsize)
> >
>
> What is the baseline for this patch?
>
Sorry, this is a linux-next bug. Introduced in:
commit dd5fc854de5fd37adfcef8a366cd21a55aa01d3d
Author: Matthew Garrett <mjg@redhat.com>
Date: Wed Dec 5 14:33:26 2012 -0700
EFI: Stash ROMs if they're not in the PCI BAR
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] x86, efi: precedence error in setup_efi_pci()
2012-12-10 8:44 ` Dan Carpenter
@ 2013-01-11 13:52 ` Matt Fleming
0 siblings, 0 replies; 4+ messages in thread
From: Matt Fleming @ 2013-01-11 13:52 UTC (permalink / raw)
To: Dan Carpenter
Cc: H. Peter Anvin, Matthew Garrett, Thomas Gleixner, Ingo Molnar,
x86-DgEjT+Ai2ygdnm+yROfE0A, linux-efi-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
On Mon, 2012-12-10 at 11:44 +0300, Dan Carpenter wrote:
> On Fri, Dec 07, 2012 at 07:05:53PM -0800, H. Peter Anvin wrote:
> > On 12/06/2012 10:16 PM, Dan Carpenter wrote:
> > >Negate has higher precedence than bitwise AND so the condition is always
> > >false.
> > >
> > >Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > >
> > >diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c
> > >index b1942e2..18e329c 100644
> > >--- a/arch/x86/boot/compressed/eboot.c
> > >+++ b/arch/x86/boot/compressed/eboot.c
> > >@@ -302,7 +302,7 @@ static efi_status_t setup_efi_pci(struct boot_params *params)
> > > if (status != EFI_SUCCESS)
> > > continue;
> > >
> > >- if (!attributes & EFI_PCI_IO_ATTRIBUTE_EMBEDDED_ROM)
> > >+ if (!(attributes & EFI_PCI_IO_ATTRIBUTE_EMBEDDED_ROM))
> > > continue;
> > >
> > > if (!pci->romimage || !pci->romsize)
> > >
> >
> > What is the baseline for this patch?
> >
>
> Sorry, this is a linux-next bug. Introduced in:
>
> commit dd5fc854de5fd37adfcef8a366cd21a55aa01d3d
> Author: Matthew Garrett <mjg@redhat.com>
> Date: Wed Dec 5 14:33:26 2012 -0700
>
> EFI: Stash ROMs if they're not in the PCI BAR
Thanks Dan, I've picked this up.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-01-11 13:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-07 6:16 [patch] x86, efi: precedence error in setup_efi_pci() Dan Carpenter
[not found] ` <20121207061649.GA18220-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
2012-12-08 3:05 ` H. Peter Anvin
[not found] ` <50C2AE91.9060800-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2012-12-10 8:44 ` Dan Carpenter
2013-01-11 13:52 ` Matt Fleming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox