* [patch] Staging: comedi: add a missing break statement
@ 2013-01-13 20:05 Dan Carpenter
2013-01-14 10:11 ` Ian Abbott
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2013-01-13 20:05 UTC (permalink / raw)
To: kernel-janitors
This is a static checker fix. From the context it looks like there
should be a break here.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Please review this carefully. I think it's probably correct, but I'd
appreciate an Ack from someone who knows comedi better.
diff --git a/drivers/staging/comedi/drivers/ni_tiocmd.c b/drivers/staging/comedi/drivers/ni_tiocmd.c
index 0c991b9..13747f3 100644
--- a/drivers/staging/comedi/drivers/ni_tiocmd.c
+++ b/drivers/staging/comedi/drivers/ni_tiocmd.c
@@ -159,6 +159,7 @@ static int ni_tio_input_cmd(struct ni_gpct *counter, struct comedi_async *async)
async->inttrig = NULL;
mite_dma_arm(counter->mite_chan);
retval = ni_tio_arm(counter, 1, cmd->start_arg);
+ break;
case TRIG_OTHER:
async->inttrig = NULL;
mite_dma_arm(counter->mite_chan);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] Staging: comedi: add a missing break statement
2013-01-13 20:05 [patch] Staging: comedi: add a missing break statement Dan Carpenter
@ 2013-01-14 10:11 ` Ian Abbott
0 siblings, 0 replies; 2+ messages in thread
From: Ian Abbott @ 2013-01-14 10:11 UTC (permalink / raw)
To: kernel-janitors
On 2013-01-13 20:05, Dan Carpenter wrote:
> This is a static checker fix. From the context it looks like there
> should be a break here.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Please review this carefully. I think it's probably correct, but I'd
> appreciate an Ack from someone who knows comedi better.
>
> diff --git a/drivers/staging/comedi/drivers/ni_tiocmd.c b/drivers/staging/comedi/drivers/ni_tiocmd.c
> index 0c991b9..13747f3 100644
> --- a/drivers/staging/comedi/drivers/ni_tiocmd.c
> +++ b/drivers/staging/comedi/drivers/ni_tiocmd.c
> @@ -159,6 +159,7 @@ static int ni_tio_input_cmd(struct ni_gpct *counter, struct comedi_async *async)
> async->inttrig = NULL;
> mite_dma_arm(counter->mite_chan);
> retval = ni_tio_arm(counter, 1, cmd->start_arg);
> + break;
> case TRIG_OTHER:
> async->inttrig = NULL;
> mite_dma_arm(counter->mite_chan);
>
Acked-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-14 10:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-13 20:05 [patch] Staging: comedi: add a missing break statement Dan Carpenter
2013-01-14 10:11 ` Ian Abbott
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox