* [patch] USB: c67x00-ll-hpi.c: signedness bug in ll_recv_msg()
@ 2013-01-18 7:41 Dan Carpenter
2013-01-18 8:39 ` Peter Korsgaard
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2013-01-18 7:41 UTC (permalink / raw)
To: kernel-janitors
The callers expect this function to return zero on success or -EIO if it
times out. The type should be int instead of unsigned short.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/usb/c67x00/c67x00-ll-hpi.c b/drivers/usb/c67x00/c67x00-ll-hpi.c
index a9636f4..3a1ca4d 100644
--- a/drivers/usb/c67x00/c67x00-ll-hpi.c
+++ b/drivers/usb/c67x00/c67x00-ll-hpi.c
@@ -237,7 +237,7 @@ void c67x00_ll_hpi_disable_sofeop(struct c67x00_sie *sie)
/* -------------------------------------------------------------------------- */
/* Transactions */
-static inline u16 ll_recv_msg(struct c67x00_device *dev)
+static inline int ll_recv_msg(struct c67x00_device *dev)
{
u16 res;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] USB: c67x00-ll-hpi.c: signedness bug in ll_recv_msg()
2013-01-18 7:41 [patch] USB: c67x00-ll-hpi.c: signedness bug in ll_recv_msg() Dan Carpenter
@ 2013-01-18 8:39 ` Peter Korsgaard
0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2013-01-18 8:39 UTC (permalink / raw)
To: kernel-janitors
>>>>> "Dan" = Dan Carpenter <dan.carpenter@oracle.com> writes:
Dan> The callers expect this function to return zero on success or -EIO if it
Dan> times out. The type should be int instead of unsigned short.
Dan> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
Dan> diff --git a/drivers/usb/c67x00/c67x00-ll-hpi.c b/drivers/usb/c67x00/c67x00-ll-hpi.c
Dan> index a9636f4..3a1ca4d 100644
Dan> --- a/drivers/usb/c67x00/c67x00-ll-hpi.c
Dan> +++ b/drivers/usb/c67x00/c67x00-ll-hpi.c
Dan> @@ -237,7 +237,7 @@ void c67x00_ll_hpi_disable_sofeop(struct c67x00_sie *sie)
Dan> /* -------------------------------------------------------------------------- */
Dan> /* Transactions */
Dan> -static inline u16 ll_recv_msg(struct c67x00_device *dev)
Dan> +static inline int ll_recv_msg(struct c67x00_device *dev)
Dan> {
Dan> u16 res;
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-18 8:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-18 7:41 [patch] USB: c67x00-ll-hpi.c: signedness bug in ll_recv_msg() Dan Carpenter
2013-01-18 8:39 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox