[PATCH] scripts/coccinelle: find constant additions that could be bit ors

[PATCH] scripts/coccinelle: find constant additions that could be bit ors

[Julia Lawall]

From: Julia Lawall <Julia.Lawall@lip6.fr>

Semantic patch (http://coccinelle.lip6.fr/) to check for constants that are
added but are used elsewhere as bitmasks.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
 scripts/coccinelle/misc/orplus.cocci |   55 +++++++++++++++++++++++++++++++++++
 1 file changed, 55 insertions(+)

diff --git a/scripts/coccinelle/misc/orplus.cocci b/scripts/coccinelle/misc/orplus.cocci
new file mode 100644
index 0000000..4a28cef
--- /dev/null
+++ b/scripts/coccinelle/misc/orplus.cocci
@@ -0,0 +1,55 @@
+/// Check for constants that are added but are used elsewhere as bitmasks
+/// The results should be checked manually to ensure that the nonzero
+/// bits in the two constants are actually disjoint.
+///
+// Confidence: Moderate
+// Copyright: (C) 2013 Julia Lawall, INRIA/LIP6.  GPLv2.
+// Copyright: (C) 2013 Gilles Muller, INRIA/LIP6.  GPLv2.
+// URL: http://coccinelle.lip6.fr/
+// Comments:
+// Options: -no_includes -include_headers
+
+virtual org
+virtual report
+virtual context
+
+@r@
+constant c;
+identifier i;
+expression e;
+@@
+
+(
+e | c@i
+|
+e & c@i
+|
+e |= c@i
+|
+e &= c@i
+)
+
+@s@
+constant r.c,c1;
+identifier i1;
+position p;
+@@
+
+(
+ c1 + c - 1
+|
+*c1@i1 +@p c
+)
+
+@script:python depends on org@
+p << s.p;
+@@
+
+cocci.print_main("sum of probable bitmasks, consider |",p)
+
+@script:python depends on report@
+p << s.p;
+@@
+
+msg = "WARNING: sum of probable bitmasks, consider |"
+coccilib.report.print_report(p[0],msg)

Re: [PATCH] scripts/coccinelle: find constant additions that could be bit ors

[Michal Marek]

On Sat, Feb 02, 2013 at 05:19:55PM +0100, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> Semantic patch (http://coccinelle.lip6.fr/) to check for constants that are
> added but are used elsewhere as bitmasks.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Applied to kbuild.git#misc.

Michal

Re: [PATCH] scripts/coccinelle: find constant additions that could be bit ors

[Dan Carpenter]

On Fri, Feb 22, 2013 at 11:44:31AM +0100, Michal Marek wrote:
> On Sat, Feb 02, 2013 at 05:19:55PM +0100, Julia Lawall wrote:
> > From: Julia Lawall <Julia.Lawall@lip6.fr>
> > 
> > Semantic patch (http://coccinelle.lip6.fr/) to check for constants that are
> > added but are used elsewhere as bitmasks.
> > 
> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> Applied to kbuild.git#misc.
> 

I'm not sure we want to do this.  The one patch which was sent with
this script wasn't applied.

regards,
dan carpenter

Re: [PATCH] scripts/coccinelle: find constant additions that could be bit ors

[Julia Lawall]

On Sat, 23 Feb 2013, Dan Carpenter wrote:

> On Fri, Feb 22, 2013 at 11:44:31AM +0100, Michal Marek wrote:
> > On Sat, Feb 02, 2013 at 05:19:55PM +0100, Julia Lawall wrote:
> > > From: Julia Lawall <Julia.Lawall@lip6.fr>
> > > 
> > > Semantic patch (http://coccinelle.lip6.fr/) to check for constants that are
> > > added but are used elsewhere as bitmasks.
> > > 
> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> > 
> > Applied to kbuild.git#misc.
> > 
> 
> I'm not sure we want to do this.  The one patch which was sent with
> this script wasn't applied.

I think that the view on it was that if it isn't broken, don't fix it.  
But if the rules that are being added to the kernel are primarily being 
used for new code, then it could be reasonable for developers to consider 
whether they would really rather use | rather than the confusing +.

julia