* [patch 2/2] staging: rtl8188eu: || vs && typo
@ 2013-08-29 21:46 Dan Carpenter
2013-08-31 16:37 ` Larry Finger
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2013-08-29 21:46 UTC (permalink / raw)
To: kernel-janitors
Obviously it's impossible for ->KeyLength to be both 5 and 13. I assume
that && was intended here.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c b/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
index 5fab477..193f641 100644
--- a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
+++ b/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
@@ -743,7 +743,7 @@ _func_enter_;
/* Check key length for WEP. For NDTEST, 2005.01.27, by rcnjko. */
if ((encryptionalgo = _WEP40_ || encryptionalgo = _WEP104_) &&
- (key->KeyLength != 5 || key->KeyLength != 13)) {
+ (key->KeyLength != 5 && key->KeyLength != 13)) {
RT_TRACE(_module_rtl871x_ioctl_set_c_, _drv_err_, ("WEP KeyLength:0x%x != 5 or 13\n", key->KeyLength));
ret = _FAIL;
goto exit;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch 2/2] staging: rtl8188eu: || vs && typo
2013-08-29 21:46 [patch 2/2] staging: rtl8188eu: || vs && typo Dan Carpenter
@ 2013-08-31 16:37 ` Larry Finger
0 siblings, 0 replies; 2+ messages in thread
From: Larry Finger @ 2013-08-31 16:37 UTC (permalink / raw)
To: kernel-janitors
On 08/29/2013 04:46 PM, Dan Carpenter wrote:
> Obviously it's impossible for ->KeyLength to be both 5 and 13. I assume
> that && was intended here.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c b/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
> index 5fab477..193f641 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
> @@ -743,7 +743,7 @@ _func_enter_;
>
> /* Check key length for WEP. For NDTEST, 2005.01.27, by rcnjko. */
> if ((encryptionalgo = _WEP40_ || encryptionalgo = _WEP104_) &&
> - (key->KeyLength != 5 || key->KeyLength != 13)) {
> + (key->KeyLength != 5 && key->KeyLength != 13)) {
> RT_TRACE(_module_rtl871x_ioctl_set_c_, _drv_err_, ("WEP KeyLength:0x%x != 5 or 13\n", key->KeyLength));
> ret = _FAIL;
> goto exit;
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks,
Larry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-31 16:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-29 21:46 [patch 2/2] staging: rtl8188eu: || vs && typo Dan Carpenter
2013-08-31 16:37 ` Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox