* [patch] staging: rtl8192e: fix some confusing indenting
@ 2015-06-05 9:24 Dan Carpenter
2015-06-07 15:49 ` Mateusz Kulikowski
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2015-06-05 9:24 UTC (permalink / raw)
To: kernel-janitors
The indenting here causes a static checker warning:
drivers/staging/rtl8192e/rtllib_rx.c:626 RxReorderIndicatePacket()
warn: curly braces intended?
The code is actually correct, it's just that these lines were pushed in
an extra indent level by mistake in 35e33b0468ab ('staging: rtl8192e:
Fix LONG_LINE warnings').
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
index 6977f04..2bef1f6 100644
--- a/drivers/staging/rtl8192e/rtllib_rx.c
+++ b/drivers/staging/rtl8192e/rtllib_rx.c
@@ -623,9 +623,9 @@ static void RxReorderIndicatePacket(struct rtllib_device *ieee,
else
pTS->RxIndicateSeq = 4095 -
(WinSize - (SeqNum + 1)) + 1;
- netdev_dbg(ieee->dev,
- "Window Shift! IndicateSeq: %d, NewSeq: %d\n",
- pTS->RxIndicateSeq, SeqNum);
+ netdev_dbg(ieee->dev,
+ "Window Shift! IndicateSeq: %d, NewSeq: %d\n",
+ pTS->RxIndicateSeq, SeqNum);
}
/* Indication process.
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch] staging: rtl8192e: fix some confusing indenting
2015-06-05 9:24 [patch] staging: rtl8192e: fix some confusing indenting Dan Carpenter
@ 2015-06-07 15:49 ` Mateusz Kulikowski
0 siblings, 0 replies; 2+ messages in thread
From: Mateusz Kulikowski @ 2015-06-07 15:49 UTC (permalink / raw)
To: kernel-janitors
On 05.06.2015 11:24, Dan Carpenter wrote:
> The indenting here causes a static checker warning:
>
> drivers/staging/rtl8192e/rtllib_rx.c:626 RxReorderIndicatePacket()
> warn: curly braces intended?
>
> The code is actually correct, it's just that these lines were pushed in
> an extra indent level by mistake in 35e33b0468ab ('staging: rtl8192e:
> Fix LONG_LINE warnings').
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
> index 6977f04..2bef1f6 100644
> --- a/drivers/staging/rtl8192e/rtllib_rx.c
> +++ b/drivers/staging/rtl8192e/rtllib_rx.c
> @@ -623,9 +623,9 @@ static void RxReorderIndicatePacket(struct rtllib_device *ieee,
> else
> pTS->RxIndicateSeq = 4095 -
> (WinSize - (SeqNum + 1)) + 1;
> - netdev_dbg(ieee->dev,
> - "Window Shift! IndicateSeq: %d, NewSeq: %d\n",
> - pTS->RxIndicateSeq, SeqNum);
> + netdev_dbg(ieee->dev,
> + "Window Shift! IndicateSeq: %d, NewSeq: %d\n",
> + pTS->RxIndicateSeq, SeqNum);
> }
>
> /* Indication process.
>
Ouch, Thanks!
I've missed this one.
M.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-07 15:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-05 9:24 [patch] staging: rtl8192e: fix some confusing indenting Dan Carpenter
2015-06-07 15:49 ` Mateusz Kulikowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox