* [patch] ASoC: wm8731: harmless underflow in wm8731_put_deemph()
@ 2015-10-13 7:08 Dan Carpenter
2015-10-13 12:27 ` Charles Keepax
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2015-10-13 7:08 UTC (permalink / raw)
To: Liam Girdwood
Cc: Mark Brown, Jaroslav Kysela, Takashi Iwai, Charles Keepax,
Lars-Peter Clausen, Fabio Estevam, Songjun Wu,
Krzysztof Kozlowski, Axel Lin, Sergey Kiselev, patches,
alsa-devel, kernel-janitors
The code tries to verify that "deemph" is zero or one, but it fails to
account for that it can be negative. It's harmless because negatives
are treated the same as one, but we should fix it just to silence the
static checker warning.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/soc/codecs/wm8731.c b/sound/soc/codecs/wm8731.c
index ace8645..07cf1bd 100644
--- a/sound/soc/codecs/wm8731.c
+++ b/sound/soc/codecs/wm8731.c
@@ -132,7 +132,7 @@ static int wm8731_put_deemph(struct snd_kcontrol *kcontrol,
{
struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);
struct wm8731_priv *wm8731 = snd_soc_codec_get_drvdata(codec);
- int deemph = ucontrol->value.integer.value[0];
+ unsigned int deemph = ucontrol->value.integer.value[0];
int ret = 0;
if (deemph > 1)
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch] ASoC: wm8731: harmless underflow in wm8731_put_deemph()
2015-10-13 7:08 [patch] ASoC: wm8731: harmless underflow in wm8731_put_deemph() Dan Carpenter
@ 2015-10-13 12:27 ` Charles Keepax
0 siblings, 0 replies; 2+ messages in thread
From: Charles Keepax @ 2015-10-13 12:27 UTC (permalink / raw)
To: Dan Carpenter
Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Lars-Peter Clausen, Fabio Estevam, Songjun Wu,
Krzysztof Kozlowski, Axel Lin, Sergey Kiselev, patches,
alsa-devel, kernel-janitors
On Tue, Oct 13, 2015 at 10:08:57AM +0300, Dan Carpenter wrote:
> The code tries to verify that "deemph" is zero or one, but it fails to
> account for that it can be negative. It's harmless because negatives
> are treated the same as one, but we should fix it just to silence the
> static checker warning.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-13 12:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-13 7:08 [patch] ASoC: wm8731: harmless underflow in wm8731_put_deemph() Dan Carpenter
2015-10-13 12:27 ` Charles Keepax
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox