* [patch 1/2] ALSA: firewire-tascam: fix an LED bug
@ 2015-10-15 18:16 Dan Carpenter
2015-10-17 10:12 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2015-10-15 18:16 UTC (permalink / raw)
To: Clemens Ladisch, Takashi Sakamoto
Cc: Jaroslav Kysela, Takashi Iwai, alsa-devel, kernel-janitors
We recently tried to add some new code to support turning the LED on and
off but the code in snd_tscm_transaction_reregister() is unreachable.
Fixes: e65e2cb99e44 ('ALSA: firewire-tascam: Turn on/off FireWire LED')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/firewire/tascam/tascam-transaction.c b/sound/firewire/tascam/tascam-transaction.c
index 1c9a88b..45c3ce3 100644
--- a/sound/firewire/tascam/tascam-transaction.c
+++ b/sound/firewire/tascam/tascam-transaction.c
@@ -249,7 +249,7 @@ int snd_tscm_transaction_reregister(struct snd_tscm *tscm)
/* Turn on messaging. */
reg = cpu_to_be32(0x00000001);
- return snd_fw_transaction(tscm->unit, TCODE_WRITE_QUADLET_REQUEST,
+ err = snd_fw_transaction(tscm->unit, TCODE_WRITE_QUADLET_REQUEST,
TSCM_ADDR_BASE + TSCM_OFFSET_MIDI_TX_ON,
®, sizeof(reg), 0);
if (err < 0)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch 1/2] ALSA: firewire-tascam: fix an LED bug
2015-10-15 18:16 [patch 1/2] ALSA: firewire-tascam: fix an LED bug Dan Carpenter
@ 2015-10-17 10:12 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2015-10-17 10:12 UTC (permalink / raw)
To: Dan Carpenter
Cc: Clemens Ladisch, Takashi Sakamoto, alsa-devel, Jaroslav Kysela,
kernel-janitors
On Thu, 15 Oct 2015 20:16:30 +0200,
Dan Carpenter wrote:
>
> We recently tried to add some new code to support turning the LED on and
> off but the code in snd_tscm_transaction_reregister() is unreachable.
>
> Fixes: e65e2cb99e44 ('ALSA: firewire-tascam: Turn on/off FireWire LED')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
Takashi
>
> diff --git a/sound/firewire/tascam/tascam-transaction.c b/sound/firewire/tascam/tascam-transaction.c
> index 1c9a88b..45c3ce3 100644
> --- a/sound/firewire/tascam/tascam-transaction.c
> +++ b/sound/firewire/tascam/tascam-transaction.c
> @@ -249,7 +249,7 @@ int snd_tscm_transaction_reregister(struct snd_tscm *tscm)
>
> /* Turn on messaging. */
> reg = cpu_to_be32(0x00000001);
> - return snd_fw_transaction(tscm->unit, TCODE_WRITE_QUADLET_REQUEST,
> + err = snd_fw_transaction(tscm->unit, TCODE_WRITE_QUADLET_REQUEST,
> TSCM_ADDR_BASE + TSCM_OFFSET_MIDI_TX_ON,
> ®, sizeof(reg), 0);
> if (err < 0)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-17 10:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-15 18:16 [patch 1/2] ALSA: firewire-tascam: fix an LED bug Dan Carpenter
2015-10-17 10:12 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox