[patch] mfd: arizona: signedness bug in arizona_runtime_suspend()

[patch] mfd: arizona: signedness bug in arizona_runtime_suspend()

[Dan Carpenter]

The "jd_active" variable needs to be signed for the error handling to
work.

Fixes: 143e5887ae57 ('mfd: arizona: factor out checking of jack detection state')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
index 4e49210..d474732 100644
--- a/drivers/mfd/arizona-core.c
+++ b/drivers/mfd/arizona-core.c
@@ -628,7 +628,7 @@ err:
 static int arizona_runtime_suspend(struct device *dev)
 {
 	struct arizona *arizona = dev_get_drvdata(dev);
-	unsigned int jd_active = 0;
+	int jd_active = 0;
 	int ret;
 
 	dev_dbg(arizona->dev, "Entering AoD mode\n");

Re: [patch] mfd: arizona: signedness bug in arizona_runtime_suspend()

[Charles Keepax]

On Mon, Oct 19, 2015 at 01:18:05PM +0300, Dan Carpenter wrote:
> The "jd_active" variable needs to be signed for the error handling to
> work.
> 
> Fixes: 143e5887ae57 ('mfd: arizona: factor out checking of jack detection state')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>

thanks,
Charles

Re: [patch] mfd: arizona: signedness bug in arizona_runtime_suspend()

[Lee Jones]

export fullname=drivers/mfd/arizona-core.c
# From Dan's script
git log --oneline --no-merges mainline/master -- $fullname | head -n 10

3762aed mfd: arizona: Fixup some formatting/white space errors
6887b04 mfd: arizona: Add support for WM8998 and WM1814
16f6a0d mfd: arizona: Fix race between runtime suspend and IRQs
72e4316 mfd: arizona: Fix initialisation of the PM runtime
1115092 mfd: arizona: Fix race between runtime suspend and IRQs
8019ff6 regmap: Use reg_sequence for multi_reg_write / register_patch
fc027d1 mfd: arizona: Split INx_MODE into two fields
121c075 mfd: wm5110: Add delay before releasing reset line
e6cb734 mfd: arizona: Add better support for system suspend
96129a0 mfd: wm5110: Set DCVDD voltage to 1.175V before entering sleep mode

Each of the $subject lines above start with a capital letter. ;)

On Mon, 19 Oct 2015, Dan Carpenter wrote:
> The "jd_active" variable needs to be signed for the error handling to
> work.
> 
> Fixes: 143e5887ae57 ('mfd: arizona: factor out checking of jack detection state')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied, thanks.

> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index 4e49210..d474732 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -628,7 +628,7 @@ err:
>  static int arizona_runtime_suspend(struct device *dev)
>  {
>  	struct arizona *arizona = dev_get_drvdata(dev);
> -	unsigned int jd_active = 0;
> +	int jd_active = 0;
>  	int ret;
>  
>  	dev_dbg(arizona->dev, "Entering AoD mode\n");

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html