* Re: [PATCH] coccinelle: put_device: reduce false positives [not found] <1553321671-27749-1-git-send-email-wen.yang99@zte.com.cn> @ 2019-03-23 19:44 ` Markus Elfring 2019-03-23 20:06 ` Julia Lawall 0 siblings, 1 reply; 10+ messages in thread From: Markus Elfring @ 2019-03-23 19:44 UTC (permalink / raw) To: Wen Yang, Julia Lawall, Masahiro Yamada Cc: Yi Wang, Michal Marek, Nicolas Palix, kernel-janitors, linux-kernel, cocci > Don't complain about a return when this function returns "&pdev->dev". Would this information qualify to add the tag “Fixes” to the commit message? Regards, Markus ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] coccinelle: put_device: reduce false positives 2019-03-23 19:44 ` [PATCH] coccinelle: put_device: reduce false positives Markus Elfring @ 2019-03-23 20:06 ` Julia Lawall 2019-03-26 8:45 ` Dan Carpenter 0 siblings, 1 reply; 10+ messages in thread From: Julia Lawall @ 2019-03-23 20:06 UTC (permalink / raw) To: Markus Elfring Cc: Yi Wang, Michal Marek, kernel-janitors, Nicolas Palix, linux-kernel, cocci, Wen Yang [-- Attachment #1: Type: text/plain, Size: 523 bytes --] On Sat, 23 Mar 2019, Markus Elfring wrote: > > Don't complain about a return when this function returns "&pdev->dev". > > Would this information qualify to add the tag “Fixes” to the commit message? Fixes tags relate to stable kernels, so that one can see which stable kernels a particular patch should be propagated to. There is no need to propagate patches on semantic patches to stable kernels. People who run stable kernels are interested in their behavior, not the bug finding rules that they contain. julia ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] coccinelle: put_device: reduce false positives 2019-03-23 20:06 ` Julia Lawall @ 2019-03-26 8:45 ` Dan Carpenter 2019-03-26 9:38 ` Julia Lawall 0 siblings, 1 reply; 10+ messages in thread From: Dan Carpenter @ 2019-03-26 8:45 UTC (permalink / raw) To: Julia Lawall Cc: Yi Wang, Michal Marek, kernel-janitors, Nicolas Palix, linux-kernel, cocci, Markus Elfring, Wen Yang On Sat, Mar 23, 2019 at 09:06:54PM +0100, Julia Lawall wrote: > > > On Sat, 23 Mar 2019, Markus Elfring wrote: > > > > Don't complain about a return when this function returns "&pdev->dev". > > > > Would this information qualify to add the tag “Fixes” to the commit message? > > Fixes tags relate to stable kernels, so that one can see which stable > kernels a particular patch should be propagated to. There is no need to > propagate patches on semantic patches to stable kernels. People who run > stable kernels are interested in their behavior, not the bug finding > rules that they contain. The Fixes tag is not just about stable... For example, we use them for statistics to see how quickly bugs get fixed etc. regards, dan carpenter ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] coccinelle: put_device: reduce false positives 2019-03-26 8:45 ` Dan Carpenter @ 2019-03-26 9:38 ` Julia Lawall 2019-03-26 10:11 ` Dan Carpenter 0 siblings, 1 reply; 10+ messages in thread From: Julia Lawall @ 2019-03-26 9:38 UTC (permalink / raw) To: Dan Carpenter Cc: Yi Wang, Michal Marek, kernel-janitors, Nicolas Palix, linux-kernel, cocci, Markus Elfring, Wen Yang [-- Attachment #1: Type: text/plain, Size: 975 bytes --] On Tue, 26 Mar 2019, Dan Carpenter wrote: > On Sat, Mar 23, 2019 at 09:06:54PM +0100, Julia Lawall wrote: > > > > > > On Sat, 23 Mar 2019, Markus Elfring wrote: > > > > > > Don't complain about a return when this function returns "&pdev->dev". > > > > > > Would this information qualify to add the tag “Fixes” to the commit message? > > > > Fixes tags relate to stable kernels, so that one can see which stable > > kernels a particular patch should be propagated to. There is no need to > > propagate patches on semantic patches to stable kernels. People who run > > stable kernels are interested in their behavior, not the bug finding > > rules that they contain. > > The Fixes tag is not just about stable... For example, we use them for > statistics to see how quickly bugs get fixed etc. OK. But still do we need fixes tags for bug finding rules? Perhaps if the previous version was really broken, and it would be really undesirable to use it. thanks, julia ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] coccinelle: put_device: reduce false positives 2019-03-26 9:38 ` Julia Lawall @ 2019-03-26 10:11 ` Dan Carpenter 2019-03-26 10:15 ` Julia Lawall 0 siblings, 1 reply; 10+ messages in thread From: Dan Carpenter @ 2019-03-26 10:11 UTC (permalink / raw) To: Julia Lawall Cc: Yi Wang, Michal Marek, kernel-janitors, Nicolas Palix, linux-kernel, cocci, Markus Elfring, Wen Yang On Tue, Mar 26, 2019 at 10:38:43AM +0100, Julia Lawall wrote: > > > On Tue, 26 Mar 2019, Dan Carpenter wrote: > > > On Sat, Mar 23, 2019 at 09:06:54PM +0100, Julia Lawall wrote: > > > > > > > > > On Sat, 23 Mar 2019, Markus Elfring wrote: > > > > > > > > Don't complain about a return when this function returns "&pdev->dev". > > > > > > > > Would this information qualify to add the tag “Fixes” to the commit message? > > > > > > Fixes tags relate to stable kernels, so that one can see which stable > > > kernels a particular patch should be propagated to. There is no need to > > > propagate patches on semantic patches to stable kernels. People who run > > > stable kernels are interested in their behavior, not the bug finding > > > rules that they contain. > > > > The Fixes tag is not just about stable... For example, we use them for > > statistics to see how quickly bugs get fixed etc. > > OK. But still do we need fixes tags for bug finding rules? Perhaps if > the previous version was really broken, and it would be really undesirable > to use it. It's not worth resending a patch for that, but I probably would use the fixes tag. It depends on your definition of "bug" really... I tell people not to use Fixes for spelling mistakes and unused variables. But I do use the Fixes tag for things like "an off by one in a sanity check which doesn't affect run time because the index is always correct". regards, dan carpenter ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] coccinelle: put_device: reduce false positives 2019-03-26 10:11 ` Dan Carpenter @ 2019-03-26 10:15 ` Julia Lawall 2019-03-28 13:08 ` Masahiro Yamada 0 siblings, 1 reply; 10+ messages in thread From: Julia Lawall @ 2019-03-26 10:15 UTC (permalink / raw) To: Dan Carpenter Cc: Yi Wang, Michal Marek, kernel-janitors, Nicolas Palix, linux-kernel, cocci, Markus Elfring, Wen Yang [-- Attachment #1: Type: text/plain, Size: 1551 bytes --] On Tue, 26 Mar 2019, Dan Carpenter wrote: > On Tue, Mar 26, 2019 at 10:38:43AM +0100, Julia Lawall wrote: > > > > > > On Tue, 26 Mar 2019, Dan Carpenter wrote: > > > > > On Sat, Mar 23, 2019 at 09:06:54PM +0100, Julia Lawall wrote: > > > > > > > > > > > > On Sat, 23 Mar 2019, Markus Elfring wrote: > > > > > > > > > > Don't complain about a return when this function returns "&pdev->dev". > > > > > > > > > > Would this information qualify to add the tag “Fixes” to the commit message? > > > > > > > > Fixes tags relate to stable kernels, so that one can see which stable > > > > kernels a particular patch should be propagated to. There is no need to > > > > propagate patches on semantic patches to stable kernels. People who run > > > > stable kernels are interested in their behavior, not the bug finding > > > > rules that they contain. > > > > > > The Fixes tag is not just about stable... For example, we use them for > > > statistics to see how quickly bugs get fixed etc. > > > > OK. But still do we need fixes tags for bug finding rules? Perhaps if > > the previous version was really broken, and it would be really undesirable > > to use it. > > It's not worth resending a patch for that, but I probably would use the > fixes tag. It depends on your definition of "bug" really... I tell > people not to use Fixes for spelling mistakes and unused variables. But > I do use the Fixes tag for things like "an off by one in a sanity check > which doesn't affect run time because the index is always correct". OK, thanks. julia ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] coccinelle: put_device: reduce false positives 2019-03-26 10:15 ` Julia Lawall @ 2019-03-28 13:08 ` Masahiro Yamada 2019-03-28 14:19 ` Julia Lawall 2019-04-01 6:44 ` Coccinelle: " Markus Elfring 0 siblings, 2 replies; 10+ messages in thread From: Masahiro Yamada @ 2019-03-28 13:08 UTC (permalink / raw) To: Julia Lawall Cc: Yi Wang, Michal Marek, kernel-janitors, Nicolas Palix, Linux Kernel Mailing List, cocci, Markus Elfring, Wen Yang, Dan Carpenter On Tue, Mar 26, 2019 at 7:16 PM Julia Lawall <julia.lawall@lip6.fr> wrote: > > > > On Tue, 26 Mar 2019, Dan Carpenter wrote: > > > On Tue, Mar 26, 2019 at 10:38:43AM +0100, Julia Lawall wrote: > > > > > > > > > On Tue, 26 Mar 2019, Dan Carpenter wrote: > > > > > > > On Sat, Mar 23, 2019 at 09:06:54PM +0100, Julia Lawall wrote: > > > > > > > > > > > > > > > On Sat, 23 Mar 2019, Markus Elfring wrote: > > > > > > > > > > > > Don't complain about a return when this function returns "&pdev->dev". > > > > > > > > > > > > Would this information qualify to add the tag “Fixes” to the commit message? > > > > > > > > > > Fixes tags relate to stable kernels, so that one can see which stable > > > > > kernels a particular patch should be propagated to. There is no need to > > > > > propagate patches on semantic patches to stable kernels. People who run > > > > > stable kernels are interested in their behavior, not the bug finding > > > > > rules that they contain. > > > > > > > > The Fixes tag is not just about stable... For example, we use them for > > > > statistics to see how quickly bugs get fixed etc. > > > > > > OK. But still do we need fixes tags for bug finding rules? Perhaps if > > > the previous version was really broken, and it would be really undesirable > > > to use it. > > > > It's not worth resending a patch for that, but I probably would use the > > fixes tag. It depends on your definition of "bug" really... I tell > > people not to use Fixes for spelling mistakes and unused variables. But > > I do use the Fixes tag for things like "an off by one in a sanity check > > which doesn't affect run time because the index is always correct". > > OK, thanks. > > julia I added Fixes: tag, and applied to linux-kbuild/fixes. Thanks. -- Best Regards Masahiro Yamada ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] coccinelle: put_device: reduce false positives 2019-03-28 13:08 ` Masahiro Yamada @ 2019-03-28 14:19 ` Julia Lawall 2019-04-01 6:44 ` Coccinelle: " Markus Elfring 1 sibling, 0 replies; 10+ messages in thread From: Julia Lawall @ 2019-03-28 14:19 UTC (permalink / raw) To: Masahiro Yamada Cc: Yi Wang, Michal Marek, kernel-janitors, Nicolas Palix, Linux Kernel Mailing List, cocci, Markus Elfring, Wen Yang, Dan Carpenter [-- Attachment #1: Type: text/plain, Size: 1966 bytes --] On Thu, 28 Mar 2019, Masahiro Yamada wrote: > On Tue, Mar 26, 2019 at 7:16 PM Julia Lawall <julia.lawall@lip6.fr> wrote: > > > > > > > > On Tue, 26 Mar 2019, Dan Carpenter wrote: > > > > > On Tue, Mar 26, 2019 at 10:38:43AM +0100, Julia Lawall wrote: > > > > > > > > > > > > On Tue, 26 Mar 2019, Dan Carpenter wrote: > > > > > > > > > On Sat, Mar 23, 2019 at 09:06:54PM +0100, Julia Lawall wrote: > > > > > > > > > > > > > > > > > > On Sat, 23 Mar 2019, Markus Elfring wrote: > > > > > > > > > > > > > > Don't complain about a return when this function returns "&pdev->dev". > > > > > > > > > > > > > > Would this information qualify to add the tag “Fixes” to the commit message? > > > > > > > > > > > > Fixes tags relate to stable kernels, so that one can see which stable > > > > > > kernels a particular patch should be propagated to. There is no need to > > > > > > propagate patches on semantic patches to stable kernels. People who run > > > > > > stable kernels are interested in their behavior, not the bug finding > > > > > > rules that they contain. > > > > > > > > > > The Fixes tag is not just about stable... For example, we use them for > > > > > statistics to see how quickly bugs get fixed etc. > > > > > > > > OK. But still do we need fixes tags for bug finding rules? Perhaps if > > > > the previous version was really broken, and it would be really undesirable > > > > to use it. > > > > > > It's not worth resending a patch for that, but I probably would use the > > > fixes tag. It depends on your definition of "bug" really... I tell > > > people not to use Fixes for spelling mistakes and unused variables. But > > > I do use the Fixes tag for things like "an off by one in a sanity check > > > which doesn't affect run time because the index is always correct". > > > > OK, thanks. > > > > julia > > I added Fixes: tag, > and applied to linux-kbuild/fixes. Thanks! julia > > Thanks. > > -- > Best Regards > Masahiro Yamada > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Coccinelle: put_device: reduce false positives 2019-03-28 13:08 ` Masahiro Yamada 2019-03-28 14:19 ` Julia Lawall @ 2019-04-01 6:44 ` Markus Elfring 2019-04-01 20:04 ` Julia Lawall 1 sibling, 1 reply; 10+ messages in thread From: Markus Elfring @ 2019-04-01 6:44 UTC (permalink / raw) To: Masahiro Yamada, Julia Lawall, Wen Yang, kernel-janitors Cc: Yi Wang, Michal Marek, Nicolas Palix, linux-kernel, cocci, Dan Carpenter > I added Fixes: tag, > and applied to linux-kbuild/fixes. Will this extension trigger further adjustments for similar SmPL scripts? Example: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/scripts/coccinelle/free/pci_free_consistent.cocci?id÷b167113753e95ae61383e234f8d10142782ace Regards, Markus ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Coccinelle: put_device: reduce false positives 2019-04-01 6:44 ` Coccinelle: " Markus Elfring @ 2019-04-01 20:04 ` Julia Lawall 0 siblings, 0 replies; 10+ messages in thread From: Julia Lawall @ 2019-04-01 20:04 UTC (permalink / raw) To: Markus Elfring Cc: Yi Wang, Michal Marek, Nicolas Palix, kernel-janitors, linux-kernel, cocci, Wen Yang, Dan Carpenter On Mon, 1 Apr 2019, Markus Elfring wrote: > > I added Fixes: tag, > > and applied to linux-kbuild/fixes. > > Will this extension trigger further adjustments for similar SmPL scripts? > > Example: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/scripts/coccinelle/free/pci_free_consistent.cocci?id÷b167113753e95ae61383e234f8d10142782ace If there are false positives caused by this or other scripts, feel free to submit a patch. julia ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-04-01 20:04 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1553321671-27749-1-git-send-email-wen.yang99@zte.com.cn>
2019-03-23 19:44 ` [PATCH] coccinelle: put_device: reduce false positives Markus Elfring
2019-03-23 20:06 ` Julia Lawall
2019-03-26 8:45 ` Dan Carpenter
2019-03-26 9:38 ` Julia Lawall
2019-03-26 10:11 ` Dan Carpenter
2019-03-26 10:15 ` Julia Lawall
2019-03-28 13:08 ` Masahiro Yamada
2019-03-28 14:19 ` Julia Lawall
2019-04-01 6:44 ` Coccinelle: " Markus Elfring
2019-04-01 20:04 ` Julia Lawall
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox