* [PATCH] staging: gpib: Fix typo in TTY_LOG message
@ 2025-02-10 12:15 Andrew Kreimer
2025-02-10 12:32 ` Greg KH
2025-02-11 9:30 ` [PATCH v2] staging: gpib: Remove unnecessary TTY_LOG expansion Andrew Kreimer
0 siblings, 2 replies; 5+ messages in thread
From: Andrew Kreimer @ 2025-02-10 12:15 UTC (permalink / raw)
To: Dave Penkler; +Cc: linux-staging, linux-kernel, kernel-janitors, Andrew Kreimer
There is a typo in TTY_LOG message:
- sucesfully -> successfully
Fix it via codespell.
Signed-off-by: Andrew Kreimer <algonell@gmail.com>
---
drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
index 85322af62c23..1c3e5dfcc9ec 100644
--- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
+++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
@@ -542,7 +542,7 @@ static int usb_gpib_attach(gpib_board_t *board, const gpib_board_config_t *confi
return -EIO;
SHOW_STATUS(board);
- TTY_LOG("Module '%s' has been sucesfully configured\n", NAME);
+ TTY_LOG("Module '%s' has been successfully configured\n", NAME);
return 0;
}
--
2.48.1.268.g9520f7d998
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: gpib: Fix typo in TTY_LOG message
2025-02-10 12:15 [PATCH] staging: gpib: Fix typo in TTY_LOG message Andrew Kreimer
@ 2025-02-10 12:32 ` Greg KH
2025-02-11 9:30 ` [PATCH v2] staging: gpib: Remove unnecessary TTY_LOG expansion Andrew Kreimer
1 sibling, 0 replies; 5+ messages in thread
From: Greg KH @ 2025-02-10 12:32 UTC (permalink / raw)
To: Andrew Kreimer; +Cc: Dave Penkler, linux-staging, linux-kernel, kernel-janitors
On Mon, Feb 10, 2025 at 02:15:33PM +0200, Andrew Kreimer wrote:
> There is a typo in TTY_LOG message:
> - sucesfully -> successfully
>
> Fix it via codespell.
>
> Signed-off-by: Andrew Kreimer <algonell@gmail.com>
> ---
> drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
> index 85322af62c23..1c3e5dfcc9ec 100644
> --- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
> +++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
> @@ -542,7 +542,7 @@ static int usb_gpib_attach(gpib_board_t *board, const gpib_board_config_t *confi
> return -EIO;
>
> SHOW_STATUS(board);
> - TTY_LOG("Module '%s' has been sucesfully configured\n", NAME);
> + TTY_LOG("Module '%s' has been successfully configured\n", NAME);
When drivers are successful, they should be quiet, this line should just
be removed.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] staging: gpib: Remove unnecessary TTY_LOG expansion
2025-02-10 12:15 [PATCH] staging: gpib: Fix typo in TTY_LOG message Andrew Kreimer
2025-02-10 12:32 ` Greg KH
@ 2025-02-11 9:30 ` Andrew Kreimer
2025-02-11 10:09 ` Greg KH
1 sibling, 1 reply; 5+ messages in thread
From: Andrew Kreimer @ 2025-02-11 9:30 UTC (permalink / raw)
To: Dave Penkler
Cc: linux-staging, linux-kernel, kernel-janitors, Andrew Kreimer,
Greg KH
When drivers are successful, they should be quiet.
Remove the unnecessary TTY_LOG expansion.
Suggested-by: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Kreimer <algonell@gmail.com>
---
v2:
- Change commit message/body.
- Remove the TTY_LOG line as suggested.
v1:
- Fix a typo in TTY_LOG message.
drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
index 85322af62c23..b2c4d1d26f12 100644
--- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
+++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
@@ -542,7 +542,6 @@ static int usb_gpib_attach(gpib_board_t *board, const gpib_board_config_t *confi
return -EIO;
SHOW_STATUS(board);
- TTY_LOG("Module '%s' has been sucesfully configured\n", NAME);
return 0;
}
Interdiff against v1:
diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
index 1c3e5dfcc9ec..b2c4d1d26f12 100644
--- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
+++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
@@ -542,7 +542,6 @@ static int usb_gpib_attach(gpib_board_t *board, const gpib_board_config_t *confi
return -EIO;
SHOW_STATUS(board);
- TTY_LOG("Module '%s' has been successfully configured\n", NAME);
return 0;
}
Range-diff against v1:
1: 779e59d74722 ! 1: 463e7000d1a7 staging: gpib: Fix typo in TTY_LOG message
@@ Metadata
Author: Andrew Kreimer <algonell@gmail.com>
## Commit message ##
- staging: gpib: Fix typo in TTY_LOG message
+ staging: gpib: Remove unnecessary TTY_LOG expansion
- There is a typo in TTY_LOG message:
- - sucesfully -> successfully
+ When drivers are successful, they should be quiet.
- Fix it via codespell.
+ Remove the unnecessary TTY_LOG expansion.
+ Suggested-by: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Kreimer <algonell@gmail.com>
## drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c ##
@@ drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c: static int usb_gpib_attach(g
SHOW_STATUS(board);
- TTY_LOG("Module '%s' has been sucesfully configured\n", NAME);
-+ TTY_LOG("Module '%s' has been successfully configured\n", NAME);
return 0;
}
--
2.48.1.268.g9520f7d998
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] staging: gpib: Remove unnecessary TTY_LOG expansion
2025-02-11 9:30 ` [PATCH v2] staging: gpib: Remove unnecessary TTY_LOG expansion Andrew Kreimer
@ 2025-02-11 10:09 ` Greg KH
2025-02-11 11:28 ` Andrew Kreimer
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2025-02-11 10:09 UTC (permalink / raw)
To: Andrew Kreimer; +Cc: Dave Penkler, linux-staging, linux-kernel, kernel-janitors
On Tue, Feb 11, 2025 at 11:30:13AM +0200, Andrew Kreimer wrote:
> When drivers are successful, they should be quiet.
>
> Remove the unnecessary TTY_LOG expansion.
>
> Suggested-by: Greg KH <greg@kroah.com>
> Signed-off-by: Andrew Kreimer <algonell@gmail.com>
> ---
> v2:
> - Change commit message/body.
> - Remove the TTY_LOG line as suggested.
>
> v1:
> - Fix a typo in TTY_LOG message.
>
> drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
> index 85322af62c23..b2c4d1d26f12 100644
> --- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
> +++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
> @@ -542,7 +542,6 @@ static int usb_gpib_attach(gpib_board_t *board, const gpib_board_config_t *confi
> return -EIO;
>
> SHOW_STATUS(board);
> - TTY_LOG("Module '%s' has been sucesfully configured\n", NAME);
> return 0;
> }
>
>
> Interdiff against v1:
> diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
> index 1c3e5dfcc9ec..b2c4d1d26f12 100644
> --- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
> +++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
> @@ -542,7 +542,6 @@ static int usb_gpib_attach(gpib_board_t *board, const gpib_board_config_t *confi
> return -EIO;
>
> SHOW_STATUS(board);
> - TTY_LOG("Module '%s' has been successfully configured\n", NAME);
> return 0;
> }
>
>
> Range-diff against v1:
> 1: 779e59d74722 ! 1: 463e7000d1a7 staging: gpib: Fix typo in TTY_LOG message
> @@ Metadata
> Author: Andrew Kreimer <algonell@gmail.com>
>
> ## Commit message ##
> - staging: gpib: Fix typo in TTY_LOG message
> + staging: gpib: Remove unnecessary TTY_LOG expansion
>
> - There is a typo in TTY_LOG message:
> - - sucesfully -> successfully
> + When drivers are successful, they should be quiet.
>
> - Fix it via codespell.
> + Remove the unnecessary TTY_LOG expansion.
>
> + Suggested-by: Greg KH <greg@kroah.com>
> Signed-off-by: Andrew Kreimer <algonell@gmail.com>
>
> ## drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c ##
> @@ drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c: static int usb_gpib_attach(g
>
> SHOW_STATUS(board);
> - TTY_LOG("Module '%s' has been sucesfully configured\n", NAME);
> -+ TTY_LOG("Module '%s' has been successfully configured\n", NAME);
> return 0;
> }
>
> --
> 2.48.1.268.g9520f7d998
>
What is the interdiff at the bottom here for?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] staging: gpib: Remove unnecessary TTY_LOG expansion
2025-02-11 10:09 ` Greg KH
@ 2025-02-11 11:28 ` Andrew Kreimer
0 siblings, 0 replies; 5+ messages in thread
From: Andrew Kreimer @ 2025-02-11 11:28 UTC (permalink / raw)
To: Greg KH; +Cc: Dave Penkler, linux-staging, linux-kernel, kernel-janitors
> What is the interdiff at the bottom here for?
Indeed, it is pointless here.
Should have sent as a separate patch as well.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-02-11 11:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-10 12:15 [PATCH] staging: gpib: Fix typo in TTY_LOG message Andrew Kreimer
2025-02-10 12:32 ` Greg KH
2025-02-11 9:30 ` [PATCH v2] staging: gpib: Remove unnecessary TTY_LOG expansion Andrew Kreimer
2025-02-11 10:09 ` Greg KH
2025-02-11 11:28 ` Andrew Kreimer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox