* [PATCH -next] misc/pvpanic: add missing MODULE_DEVICE_TABLE
@ 2021-05-14 7:01 Qiheng Lin
2021-05-14 7:08 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Qiheng Lin @ 2021-05-14 7:01 UTC (permalink / raw)
To: linqiheng, Arnd Bergmann, Greg Kroah-Hartman, zhenwei pi,
Andy Shevchenko, Mihai Carabas, Paolo Bonzini, Shile Zhang
Cc: linux-kernel, kernel-janitors, Hulk Robot
This patch adds missing MODULE_DEVICE_TABLE definition which generates
correct modalias for automatic loading of this driver when it is built
as an external module.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Qiheng Lin <linqiheng@huawei.com>
---
drivers/misc/pvpanic/pvpanic-pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/misc/pvpanic/pvpanic-pci.c b/drivers/misc/pvpanic/pvpanic-pci.c
index 9ecc4e8559d5..ccd7e32d3f55 100644
--- a/drivers/misc/pvpanic/pvpanic-pci.c
+++ b/drivers/misc/pvpanic/pvpanic-pci.c
@@ -26,6 +26,7 @@ static const struct pci_device_id pvpanic_pci_id_tbl[] = {
{ PCI_DEVICE(PCI_VENDOR_ID_REDHAT, PCI_DEVICE_ID_REDHAT_PVPANIC)},
{}
};
+MODULE_DEVICE_TABLE(pci, pvpanic_pci_id_tbl);
static ssize_t capability_show(struct device *dev,
struct device_attribute *attr, char *buf)
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next] misc/pvpanic: add missing MODULE_DEVICE_TABLE
2021-05-14 7:01 [PATCH -next] misc/pvpanic: add missing MODULE_DEVICE_TABLE Qiheng Lin
@ 2021-05-14 7:08 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2021-05-14 7:08 UTC (permalink / raw)
To: Qiheng Lin
Cc: Arnd Bergmann, zhenwei pi, Andy Shevchenko, Mihai Carabas,
Paolo Bonzini, Shile Zhang, linux-kernel, kernel-janitors,
Hulk Robot
On Fri, May 14, 2021 at 03:01:03PM +0800, Qiheng Lin wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Qiheng Lin <linqiheng@huawei.com>
> ---
> drivers/misc/pvpanic/pvpanic-pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/misc/pvpanic/pvpanic-pci.c b/drivers/misc/pvpanic/pvpanic-pci.c
> index 9ecc4e8559d5..ccd7e32d3f55 100644
> --- a/drivers/misc/pvpanic/pvpanic-pci.c
> +++ b/drivers/misc/pvpanic/pvpanic-pci.c
> @@ -26,6 +26,7 @@ static const struct pci_device_id pvpanic_pci_id_tbl[] = {
> { PCI_DEVICE(PCI_VENDOR_ID_REDHAT, PCI_DEVICE_ID_REDHAT_PVPANIC)},
> {}
> };
> +MODULE_DEVICE_TABLE(pci, pvpanic_pci_id_tbl);
>
> static ssize_t capability_show(struct device *dev,
> struct device_attribute *attr, char *buf)
>
As I have said before, unless you have a user that reports a real
problem with these types of modules not automatically loading, I am not
going to take these patches, and you should probably stop generating
them.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-14 7:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-14 7:01 [PATCH -next] misc/pvpanic: add missing MODULE_DEVICE_TABLE Qiheng Lin
2021-05-14 7:08 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox