* [PATCH] Fix for a small typo
@ 2019-03-12 9:51 Milan P. Gandhi
2019-03-12 10:22 ` Julia Lawall
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Milan P. Gandhi @ 2019-03-12 9:51 UTC (permalink / raw)
To: kernel-janitors
Signed-off-by: Milan P. Gandhi <mgandhi@redhat.com>
---
drivers/scsi/qla2xxx/qla_bsg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bsg.c
index 17d42658ad9a..f2b95f11a71c 100644
--- a/drivers/scsi/qla2xxx/qla_bsg.c
+++ b/drivers/scsi/qla2xxx/qla_bsg.c
@@ -1354,7 +1354,7 @@ qla24xx_iidma(struct bsg_job *bsg_job)
if (rval) {
ql_log(ql_log_warn, vha, 0x704c,
- "iIDMA cmd failed for %8phN -- "
+ "iiDMA cmd failed for %8phN -- "
"%04x %x %04x %04x.\n", fcport->port_name,
rval, fcport->fp_speed, mb[0], mb[1]);
rval = (DID_ERROR << 16);
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] Fix for a small typo
2019-03-12 9:51 [PATCH] Fix for a small typo Milan P. Gandhi
@ 2019-03-12 10:22 ` Julia Lawall
2019-03-12 11:16 ` Dan Carpenter
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Julia Lawall @ 2019-03-12 10:22 UTC (permalink / raw)
To: kernel-janitors
On Tue, 12 Mar 2019, Milan P. Gandhi wrote:
The patch should have a log message. For example, you could point out
where the type is so the reader doesn't have to search for it.
The subject line should also give a hint about what file is affected, so
that the right person will pay attention to it. You can see what subject
lines others have used on this file by:
git log --oneline drivers/scsi/qla2xxx/qla_bsg.c
julia
> Signed-off-by: Milan P. Gandhi <mgandhi@redhat.com>
> ---
> drivers/scsi/qla2xxx/qla_bsg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bsg.c
> index 17d42658ad9a..f2b95f11a71c 100644
> --- a/drivers/scsi/qla2xxx/qla_bsg.c
> +++ b/drivers/scsi/qla2xxx/qla_bsg.c
> @@ -1354,7 +1354,7 @@ qla24xx_iidma(struct bsg_job *bsg_job)
>
> if (rval) {
> ql_log(ql_log_warn, vha, 0x704c,
> - "iIDMA cmd failed for %8phN -- "
> + "iiDMA cmd failed for %8phN -- "
> "%04x %x %04x %04x.\n", fcport->port_name,
> rval, fcport->fp_speed, mb[0], mb[1]);
> rval = (DID_ERROR << 16);
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Fix for a small typo
2019-03-12 9:51 [PATCH] Fix for a small typo Milan P. Gandhi
2019-03-12 10:22 ` Julia Lawall
@ 2019-03-12 11:16 ` Dan Carpenter
2019-03-12 11:32 ` Milan P. Gandhi
2019-03-12 11:36 ` Dan Carpenter
3 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2019-03-12 11:16 UTC (permalink / raw)
To: kernel-janitors
1) Subject
2) No patch description. (What type did you fix?)
3) CC list.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix for a small typo
2019-03-12 9:51 [PATCH] Fix for a small typo Milan P. Gandhi
2019-03-12 10:22 ` Julia Lawall
2019-03-12 11:16 ` Dan Carpenter
@ 2019-03-12 11:32 ` Milan P. Gandhi
2019-03-12 11:36 ` Dan Carpenter
3 siblings, 0 replies; 5+ messages in thread
From: Milan P. Gandhi @ 2019-03-12 11:32 UTC (permalink / raw)
To: kernel-janitors
On 3/12/19 4:46 PM, Dan Carpenter wrote:
> 1) Subject
> 2) No patch description. (What type did you fix?)
> 3) CC list.
>
Hi Dan, Julia,
Thanks for pointing it out.
Let me fix it quickly.
regards,
Milan.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix for a small typo
2019-03-12 9:51 [PATCH] Fix for a small typo Milan P. Gandhi
` (2 preceding siblings ...)
2019-03-12 11:32 ` Milan P. Gandhi
@ 2019-03-12 11:36 ` Dan Carpenter
3 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2019-03-12 11:36 UTC (permalink / raw)
To: kernel-janitors
On Tue, Mar 12, 2019 at 04:50:07PM +0530, Milan P. Gandhi wrote:
> On 3/12/19 4:46 PM, Dan Carpenter wrote:
> > 1) Subject
> > 2) No patch description. (What type did you fix?)
> > 3) CC list.
> >
>
> Hi Dan, Julia,
>
> Thanks for pointing it out.
> Let me fix it quickly.
There is absolutely no need to rush. Please go slowly.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-03-12 11:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-12 9:51 [PATCH] Fix for a small typo Milan P. Gandhi
2019-03-12 10:22 ` Julia Lawall
2019-03-12 11:16 ` Dan Carpenter
2019-03-12 11:32 ` Milan P. Gandhi
2019-03-12 11:36 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox