* Re: mtip32xx: fix crash on surprise removal of the drive
2015-06-20 12:38 mtip32xx: fix crash on surprise removal of the drive Dan Carpenter
@ 2015-06-22 17:24 ` Asai Thambi SP
2015-06-23 7:37 ` Dan Carpenter
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Asai Thambi SP @ 2015-06-22 17:24 UTC (permalink / raw)
To: kernel-janitors
On 6/20/2015 5:38 AM, Dan Carpenter wrote:
> Hello Asai Thambi SP,
>
> The patch 2132a544727e: "mtip32xx: fix crash on surprise removal of
> the drive" from May 11, 2015, leads to the following static checker
> warning:
>
> drivers/block/mtip32xx/mtip32xx.c:4489 mtip_pci_remove()
> warn: 'dd' was already freed.
Thanks Dan.
We got this report as soon as patch was merged. We are testing the fix and if everything ok, will send out a patch today.
> drivers/block/mtip32xx/mtip32xx.c
> 4484 spin_lock_irqsave(&dev_lock, flags);
> 4485 list_del_init(&dd->remove_list);
> 4486 spin_unlock_irqrestore(&dev_lock, flags);
> 4487
> 4488 kfree(dd);
> ^^
> 4489 set_bit(MTIP_DDF_REMOVE_DONE_BIT, &dd->dd_flag);
> ^^^^^^^^^^^
> 4490
> 4491 pcim_iounmap_regions(pdev, 1 << MTIP_ABAR);
> 4492 pci_set_drvdata(pdev, NULL);
> 4493 }
>
> regards,
> dan carpenter
--
Regards,
Asai
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: mtip32xx: fix crash on surprise removal of the drive
2015-06-20 12:38 mtip32xx: fix crash on surprise removal of the drive Dan Carpenter
2015-06-22 17:24 ` Asai Thambi SP
@ 2015-06-23 7:37 ` Dan Carpenter
2015-06-23 8:11 ` Julia Lawall
2015-06-23 9:00 ` Dan Carpenter
3 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2015-06-23 7:37 UTC (permalink / raw)
To: kernel-janitors
On Mon, Jun 22, 2015 at 10:24:51AM -0700, Asai Thambi SP wrote:
>
>
> On 6/20/2015 5:38 AM, Dan Carpenter wrote:
> > Hello Asai Thambi SP,
> >
> > The patch 2132a544727e: "mtip32xx: fix crash on surprise removal of
> > the drive" from May 11, 2015, leads to the following static checker
> > warning:
> >
> > drivers/block/mtip32xx/mtip32xx.c:4489 mtip_pci_remove()
> > warn: 'dd' was already freed.
> Thanks Dan.
> We got this report as soon as patch was merged.
I try to avoid sending duplicates. Who sent you the report? I looked
through my kbuild zero bot emails and I don't think they sent it to you.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: mtip32xx: fix crash on surprise removal of the drive
2015-06-20 12:38 mtip32xx: fix crash on surprise removal of the drive Dan Carpenter
2015-06-22 17:24 ` Asai Thambi SP
2015-06-23 7:37 ` Dan Carpenter
@ 2015-06-23 8:11 ` Julia Lawall
2015-06-23 9:00 ` Dan Carpenter
3 siblings, 0 replies; 5+ messages in thread
From: Julia Lawall @ 2015-06-23 8:11 UTC (permalink / raw)
To: kernel-janitors
On Tue, 23 Jun 2015, Dan Carpenter wrote:
> On Mon, Jun 22, 2015 at 10:24:51AM -0700, Asai Thambi SP wrote:
> >
> >
> > On 6/20/2015 5:38 AM, Dan Carpenter wrote:
> > > Hello Asai Thambi SP,
> > >
> > > The patch 2132a544727e: "mtip32xx: fix crash on surprise removal of
> > > the drive" from May 11, 2015, leads to the following static checker
> > > warning:
> > >
> > > drivers/block/mtip32xx/mtip32xx.c:4489 mtip_pci_remove()
> > > warn: 'dd' was already freed.
> > Thanks Dan.
> > We got this report as soon as patch was merged.
>
> I try to avoid sending duplicates. Who sent you the report? I looked
> through my kbuild zero bot emails and I don't think they sent it to you.
I probably sent it. My emails to the mailing list are probably all still
being rejected.
julia
>
> regards,
> dan carpenter
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: mtip32xx: fix crash on surprise removal of the drive
2015-06-20 12:38 mtip32xx: fix crash on surprise removal of the drive Dan Carpenter
` (2 preceding siblings ...)
2015-06-23 8:11 ` Julia Lawall
@ 2015-06-23 9:00 ` Dan Carpenter
3 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2015-06-23 9:00 UTC (permalink / raw)
To: kernel-janitors
On Tue, Jun 23, 2015 at 10:11:28AM +0200, Julia Lawall wrote:
>
>
> On Tue, 23 Jun 2015, Dan Carpenter wrote:
>
> > On Mon, Jun 22, 2015 at 10:24:51AM -0700, Asai Thambi SP wrote:
> > >
> > >
> > > On 6/20/2015 5:38 AM, Dan Carpenter wrote:
> > > > Hello Asai Thambi SP,
> > > >
> > > > The patch 2132a544727e: "mtip32xx: fix crash on surprise removal of
> > > > the drive" from May 11, 2015, leads to the following static checker
> > > > warning:
> > > >
> > > > drivers/block/mtip32xx/mtip32xx.c:4489 mtip_pci_remove()
> > > > warn: 'dd' was already freed.
> > > Thanks Dan.
> > > We got this report as soon as patch was merged.
> >
> > I try to avoid sending duplicates. Who sent you the report? I looked
> > through my kbuild zero bot emails and I don't think they sent it to you.
>
> I probably sent it. My emails to the mailing list are probably all still
> being rejected.
>
Oh yes. That's it. The other thing is that I was swamped in vacation
email backlog so I missed the original kbuild email.
To be honest, I don't feel bad about duplicates. If people don't like
them, then they should stop introducing bugs! :)
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread