* [patch] sound: oss/dmabuf: remove an unneeded temporary variable
@ 2013-08-09 9:57 Dan Carpenter
2013-08-09 10:38 ` [alsa-devel] " Takashi Iwai
2013-08-09 13:54 ` Takashi Iwai
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2013-08-09 9:57 UTC (permalink / raw)
To: Jaroslav Kysela; +Cc: Takashi Iwai, Arnd Bergmann, alsa-devel, kernel-janitors
We don't actually use the "go" variable so it can be removed.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/oss/dmabuf.c b/sound/oss/dmabuf.c
index a59c888..461d94c 100644
--- a/sound/oss/dmabuf.c
+++ b/sound/oss/dmabuf.c
@@ -557,7 +557,6 @@ int DMAbuf_getrdbuffer(int dev, char **buf, int *len, int dontblock)
unsigned long flags;
int err = 0, n = 0;
struct dma_buffparms *dmap = adev->dmap_in;
- int go;
if (!(adev->open_mode & OPEN_READ))
return -EIO;
@@ -584,7 +583,7 @@ int DMAbuf_getrdbuffer(int dev, char **buf, int *len, int dontblock)
spin_unlock_irqrestore(&dmap->lock,flags);
return -EAGAIN;
}
- if ((go = adev->go))
+ if (adev->go)
timeout = dmabuf_timeout(dmap);
spin_unlock_irqrestore(&dmap->lock,flags);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [alsa-devel] [patch] sound: oss/dmabuf: remove an unneeded temporary variable
2013-08-09 9:57 [patch] sound: oss/dmabuf: remove an unneeded temporary variable Dan Carpenter
@ 2013-08-09 10:38 ` Takashi Iwai
2013-08-09 13:54 ` Takashi Iwai
1 sibling, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2013-08-09 10:38 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Jaroslav Kysela, alsa-devel, kernel-janitors, Arnd Bergmann
At Fri, 9 Aug 2013 12:57:06 +0300,
Dan Carpenter wrote:
>
> We don't actually use the "go" variable so it can be removed.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied.
Takashi
>
> diff --git a/sound/oss/dmabuf.c b/sound/oss/dmabuf.c
> index a59c888..461d94c 100644
> --- a/sound/oss/dmabuf.c
> +++ b/sound/oss/dmabuf.c
> @@ -557,7 +557,6 @@ int DMAbuf_getrdbuffer(int dev, char **buf, int *len, int dontblock)
> unsigned long flags;
> int err = 0, n = 0;
> struct dma_buffparms *dmap = adev->dmap_in;
> - int go;
>
> if (!(adev->open_mode & OPEN_READ))
> return -EIO;
> @@ -584,7 +583,7 @@ int DMAbuf_getrdbuffer(int dev, char **buf, int *len, int dontblock)
> spin_unlock_irqrestore(&dmap->lock,flags);
> return -EAGAIN;
> }
> - if ((go = adev->go))
> + if (adev->go)
> timeout = dmabuf_timeout(dmap);
>
> spin_unlock_irqrestore(&dmap->lock,flags);
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] sound: oss/dmabuf: remove an unneeded temporary variable
2013-08-09 9:57 [patch] sound: oss/dmabuf: remove an unneeded temporary variable Dan Carpenter
2013-08-09 10:38 ` [alsa-devel] " Takashi Iwai
@ 2013-08-09 13:54 ` Takashi Iwai
1 sibling, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2013-08-09 13:54 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Jaroslav Kysela, Arnd Bergmann, alsa-devel, kernel-janitors
At Fri, 9 Aug 2013 12:57:06 +0300,
Dan Carpenter wrote:
>
> We don't actually use the "go" variable so it can be removed.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied.
Takashi
>
> diff --git a/sound/oss/dmabuf.c b/sound/oss/dmabuf.c
> index a59c888..461d94c 100644
> --- a/sound/oss/dmabuf.c
> +++ b/sound/oss/dmabuf.c
> @@ -557,7 +557,6 @@ int DMAbuf_getrdbuffer(int dev, char **buf, int *len, int dontblock)
> unsigned long flags;
> int err = 0, n = 0;
> struct dma_buffparms *dmap = adev->dmap_in;
> - int go;
>
> if (!(adev->open_mode & OPEN_READ))
> return -EIO;
> @@ -584,7 +583,7 @@ int DMAbuf_getrdbuffer(int dev, char **buf, int *len, int dontblock)
> spin_unlock_irqrestore(&dmap->lock,flags);
> return -EAGAIN;
> }
> - if ((go = adev->go))
> + if (adev->go)
> timeout = dmabuf_timeout(dmap);
>
> spin_unlock_irqrestore(&dmap->lock,flags);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-09 13:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-09 9:57 [patch] sound: oss/dmabuf: remove an unneeded temporary variable Dan Carpenter
2013-08-09 10:38 ` [alsa-devel] " Takashi Iwai
2013-08-09 13:54 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox