[Bug #11947] 2.6.28-rc VC switching with Intel graphics broken

[Bug #11947] 2.6.28-rc VC switching with Intel graphics broken

[Rafael J. Wysocki]

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27.  Please verify if it still should be listed and let me know
(either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=11947
Subject		: 2.6.28-rc VC switching with Intel graphics broken
Submitter	: Romano Giannetti <romano.giannetti-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date		: 2008-11-03 12:10 (7 days old)
Handled-By	: Jesse Barnes <jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org>

Re: [Bug #11947] 2.6.28-rc VC switching with Intel graphics broken

[Romano Giannetti]

Rafael J. Wysocki wrote:
> 
> Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=11947
> Subject		: 2.6.28-rc VC switching with Intel graphics broken
> Submitter	: Romano Giannetti <romano.giannetti-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Date		: 2008-11-03 12:10 (7 days old)
> Handled-By	: Jesse Barnes <jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org>

Still here in 2.6.28-rc4. Complete lock switching back from a VC to X.

Romano

[Bug #11947] 2.6.28-rc VC switching with Intel graphics broken

[Rafael J. Wysocki]

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27.  Please verify if it still should be listed and let me know
(either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=11947
Subject		: 2.6.28-rc VC switching with Intel graphics broken
Submitter	: Romano Giannetti <romano.giannetti-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date		: 2008-11-03 12:10 (14 days old)
Handled-By	: Jesse Barnes <jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org>

Re: [Bug #11947] 2.6.28-rc VC switching with Intel graphics broken

[Romano Giannetti (lists)]

Rafael J. Wysocki wrote:

> Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=11947
> Subject		: 2.6.28-rc VC switching with Intel graphics broken

Continue to malfunction. More details on the bugzilla entry. But basically, I had:

- one complete lock on VC switching (not switching back, just pressing ctrl-alt-f1).
- 3 two-plus minutes delay on VC switching
- a complete freeze on resuming from ram (not even SysRq-b working).

OTOH, it seems that VC malfunctioning happens only with "visual effect" aka 
compiz on.

Back to 2.6.27.5. This is quite worrying now... should I try to start a
bisection? Although I know from experience that bisecting over a -rc1 is quite
painful.

Romano


-- 
Sorry for the disclaimer --- ¡I cannot stop it!


--
La presente comunicación tiene carácter confidencial y es para el exclusivo uso del destinatario indicado en la misma. Si Ud. no es el destinatario indicado, le informamos que cualquier forma de distribución, reproducción o uso de esta comunicación y/o de la información contenida en la misma están estrictamente prohibidos por la ley. Si Ud. ha recibido esta comunicación por error, por favor, notifíquelo inmediatamente al remitente contestando a este mensaje y proceda a continuación a destruirlo. Gracias por su colaboración.

This communication contains confidential information. It is for the exclusive use of the intended addressee. If you are not the intended addressee, please note that any form of distribution, copying or use of this communication or the information in it is strictly prohibited by law. If you have received this communication in error, please immediately notify the sender by reply e-mail and destroy this message. Thank you for your cooperation. 

[Bug #11947] 2.6.28-rc VC switching with Intel graphics broken

[Rafael J. Wysocki]

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27.  Please verify if it still should be listed and let me know
(either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=11947
Subject		: 2.6.28-rc VC switching with Intel graphics broken
Submitter	: Romano Giannetti <romano.giannetti-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date		: 2008-11-03 12:10 (20 days old)
Handled-By	: Jesse Barnes <jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org>

Re: [Bug #11947] 2.6.28-rc VC switching with Intel graphics broken

[Romano Giannetti (lists)]

Rafael J. Wysocki wrote:
> 
> Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=11947
> Subject		: 2.6.28-rc VC switching with Intel graphics broken
> Submitter	: Romano Giannetti <romano.giannetti-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Date		: 2008-11-03 12:10 (20 days old)
> Handled-By	: Jesse Barnes <jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org>
> 

Still with us on -rc6, nasty, reproducible, no clues on what can be.

VC switch locks or delay the systems minutes, resuming from suspend locks hard 
the machine.

2.6.28-rc is unusable here.

Jesse, any hints? My suspicion that it can be the same thing happened with bug 
10620 is wrong? (It was a very similar error about vblank...)

Romano

-- 
Sorry for the disclaimer --- ¡I cannot stop it!


--
La presente comunicación tiene carácter confidencial y es para el exclusivo uso del destinatario indicado en la misma. Si Ud. no es el destinatario indicado, le informamos que cualquier forma de distribución, reproducción o uso de esta comunicación y/o de la información contenida en la misma están estrictamente prohibidos por la ley. Si Ud. ha recibido esta comunicación por error, por favor, notifíquelo inmediatamente al remitente contestando a este mensaje y proceda a continuación a destruirlo. Gracias por su colaboración.

This communication contains confidential information. It is for the exclusive use of the intended addressee. If you are not the intended addressee, please note that any form of distribution, copying or use of this communication or the information in it is strictly prohibited by law. If you have received this communication in error, please immediately notify the sender by reply e-mail and destroy this message. Thank you for your cooperation. 

Re: [Bug #11947] 2.6.28-rc VC switching with Intel graphics broken

[Jesse Barnes]

On Monday, November 24, 2008 12:47 am Romano Giannetti (lists) wrote:
> Rafael J. Wysocki wrote:
> > Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=11947
> > Subject		: 2.6.28-rc VC switching with Intel graphics broken
> > Submitter	: Romano Giannetti <romano.giannetti@gmail.com>
> > Date		: 2008-11-03 12:10 (20 days old)
> > Handled-By	: Jesse Barnes <jbarnes@virtuousgeek.org>
>
> Still with us on -rc6, nasty, reproducible, no clues on what can be.
>
> VC switch locks or delay the systems minutes, resuming from suspend locks
> hard the machine.
>
> 2.6.28-rc is unusable here.
>
> Jesse, any hints? My suspicion that it can be the same thing happened with
> bug 10620 is wrong? (It was a very similar error about vblank...)

Just added to the bug, it looks like a DUP of an issue Keith just fixed last 
week (now to make sure the patch makes it upstream quickly).

-- 
Jesse Barnes, Intel Open Source Technology Center

Re: [Bug #11947] 2.6.28-rc VC switching with Intel graphics broken

[Bernhard Schmidt]

Hello,

> On Monday, November 24, 2008 12:47 am Romano Giannetti (lists) wrote:
>> Rafael J. Wysocki wrote:
>>> Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=11947
>>> Subject		: 2.6.28-rc VC switching with Intel graphics broken
>>> Submitter	: Romano Giannetti <romano.giannetti@gmail.com>
>>> Date		: 2008-11-03 12:10 (20 days old)
>>> Handled-By	: Jesse Barnes <jbarnes@virtuousgeek.org>
>> Still with us on -rc6, nasty, reproducible, no clues on what can be.
>>
>> VC switch locks or delay the systems minutes, resuming from suspend locks
>> hard the machine.
>>
>> 2.6.28-rc is unusable here.
>>
>> Jesse, any hints? My suspicion that it can be the same thing happened with
>> bug 10620 is wrong? (It was a very similar error about vblank...)
> 
> Just added to the bug, it looks like a DUP of an issue Keith just fixed last 
> week (now to make sure the patch makes it upstream quickly).

I can confirm that, with the patch from 
http://lists.freedesktop.org/archives/intel-gfx/2008-November/000614.html 
applied on top of current git head (rejected hunk in 
drivers/gpu/drm/i915/915_irq.c due to the additional 
dev_priv->irq_mask_reg = ~0; in git between the removed lines, I kept 
it) I can suspend/resume and do a VC switch again.

Big thanks!

Bernhard

Re: [Bug #11947] 2.6.28-rc VC switching with Intel graphics broken

[Jesse Barnes]

On Monday, November 24, 2008 11:13 am Bernhard Schmidt wrote:
> Hello,
>
> > On Monday, November 24, 2008 12:47 am Romano Giannetti (lists) wrote:
> >> Rafael J. Wysocki wrote:
> >>> Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=11947
> >>> Subject		: 2.6.28-rc VC switching with Intel graphics broken
> >>> Submitter	: Romano Giannetti <romano.giannetti@gmail.com>
> >>> Date		: 2008-11-03 12:10 (20 days old)
> >>> Handled-By	: Jesse Barnes <jbarnes@virtuousgeek.org>
> >>
> >> Still with us on -rc6, nasty, reproducible, no clues on what can be.
> >>
> >> VC switch locks or delay the systems minutes, resuming from suspend
> >> locks hard the machine.
> >>
> >> 2.6.28-rc is unusable here.
> >>
> >> Jesse, any hints? My suspicion that it can be the same thing happened
> >> with bug 10620 is wrong? (It was a very similar error about vblank...)
> >
> > Just added to the bug, it looks like a DUP of an issue Keith just fixed
> > last week (now to make sure the patch makes it upstream quickly).
>
> I can confirm that, with the patch from
> http://lists.freedesktop.org/archives/intel-gfx/2008-November/000614.html
> applied on top of current git head (rejected hunk in
> drivers/gpu/drm/i915/915_irq.c due to the additional
> dev_priv->irq_mask_reg = ~0; in git between the removed lines, I kept
> it) I can suspend/resume and do a VC switch again.
>
> Big thanks!

Excellent, thanks for confirming.  I just pinged the maintainer, hopefully we 
can get this patch pushed quickly.

-- 
Jesse Barnes, Intel Open Source Technology Center

Re: [Bug #11947] 2.6.28-rc VC switching with Intel graphics broken

[Romano Giannetti (lists)]

[resent - sorry, LKML sent it back --- my bad]
Jesse Barnes wrote:
> 
> Just added to the bug, it looks like a DUP of an issue Keith just fixed last 
> week (now to make sure the patch makes it upstream quickly).
> 
Tried the patch and tested, it works ok. VC switching and suspend/resume 
fixed. More details on bugzilla.

Tested-by: Romano Giannetti <romano.giannetti-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Thanks to all!
     Romano

-- 
Sorry for the disclaimer --- ¡I cannot stop it!


--
La presente comunicación tiene carácter confidencial y es para el exclusivo uso del destinatario indicado en la misma. Si Ud. no es el destinatario indicado, le informamos que cualquier forma de distribución, reproducción o uso de esta comunicación y/o de la información contenida en la misma están estrictamente prohibidos por la ley. Si Ud. ha recibido esta comunicación por error, por favor, notifíquelo inmediatamente al remitente contestando a este mensaje y proceda a continuación a destruirlo. Gracias por su colaboración.

This communication contains confidential information. It is for the exclusive use of the intended addressee. If you are not the intended addressee, please note that any form of distribution, copying or use of this communication or the information in it is strictly prohibited by law. If you have received this communication in error, please immediately notify the sender by reply e-mail and destroy this message. Thank you for your cooperation. 

Re: [Bug #11947] 2.6.28-rc VC switching with Intel graphics broken

[Ingo Molnar]

* Bernhard Schmidt <berni-wpePDvIxQxvMZTq/7ZfH4Q@public.gmane.org> wrote:

> Hello,
>
>> On Monday, November 24, 2008 12:47 am Romano Giannetti (lists) wrote:
>>> Rafael J. Wysocki wrote:
>>>> Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=11947
>>>> Subject		: 2.6.28-rc VC switching with Intel graphics broken
>>>> Submitter	: Romano Giannetti <romano.giannetti-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>>> Date		: 2008-11-03 12:10 (20 days old)
>>>> Handled-By	: Jesse Barnes <jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org>
>>> Still with us on -rc6, nasty, reproducible, no clues on what can be.
>>>
>>> VC switch locks or delay the systems minutes, resuming from suspend locks
>>> hard the machine.
>>>
>>> 2.6.28-rc is unusable here.
>>>
>>> Jesse, any hints? My suspicion that it can be the same thing happened with
>>> bug 10620 is wrong? (It was a very similar error about vblank...)
>>
>> Just added to the bug, it looks like a DUP of an issue Keith just fixed 
>> last week (now to make sure the patch makes it upstream quickly).
>
> I can confirm that, with the patch from  
> http://lists.freedesktop.org/archives/intel-gfx/2008-November/000614.html 
> applied on top of current git head (rejected hunk in  
> drivers/gpu/drm/i915/915_irq.c due to the additional  
> dev_priv->irq_mask_reg = ~0; in git between the removed lines, I kept  
> it) I can suspend/resume and do a VC switch again.
>
> Big thanks!

here it is below plaintext as well, merged up to latest -git.

	Ingo

------------------->
From 60174462808051477793776c67282364bc94ded3 Mon Sep 17 00:00:00 2001
From: Keith Packard <keithp-aN4HjG94KOLQT0dZR+AlfA@public.gmane.org>
Date: Tue, 18 Nov 2008 09:30:25 -0800
Subject: [PATCH] drm: move drm vblank initialization/cleanup to driver load/unload

drm vblank initialization keeps track of the changes in driver-supplied
frame counts across vt switch and mode setting, but only if you let it by
not tearing down the drm vblank structure.

Signed-off-by: Keith Packard <keithp-aN4HjG94KOLQT0dZR+AlfA@public.gmane.org>
Signed-off-by: Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>
---
 drivers/gpu/drm/drm_drv.c       |    2 ++
 drivers/gpu/drm/drm_irq.c       |    4 +---
 drivers/gpu/drm/i915/i915_dma.c |    5 +++++
 drivers/gpu/drm/i915/i915_drv.h |    2 ++
 drivers/gpu/drm/i915/i915_irq.c |    5 -----
 include/drm/drmP.h              |    1 +
 6 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
index 3ab1e9c..996097a 100644
--- a/drivers/gpu/drm/drm_drv.c
+++ b/drivers/gpu/drm/drm_drv.c
@@ -305,6 +305,8 @@ static void drm_cleanup(struct drm_device * dev)
 		return;
 	}
 
+	drm_vblank_cleanup(dev);
+
 	drm_lastclose(dev);
 
 	if (drm_core_has_MTRR(dev) && drm_core_has_AGP(dev) &&
diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c
index 15c8dab..1e787f8 100644
--- a/drivers/gpu/drm/drm_irq.c
+++ b/drivers/gpu/drm/drm_irq.c
@@ -94,7 +94,7 @@ static void vblank_disable_fn(unsigned long arg)
 	}
 }
 
-static void drm_vblank_cleanup(struct drm_device *dev)
+void drm_vblank_cleanup(struct drm_device *dev)
 {
 	/* Bail if the driver didn't call drm_vblank_init() */
 	if (dev->num_crtcs == 0)
@@ -278,8 +278,6 @@ int drm_irq_uninstall(struct drm_device * dev)
 
 	free_irq(dev->pdev->irq, dev);
 
-	drm_vblank_cleanup(dev);
-
 	return 0;
 }
 EXPORT_SYMBOL(drm_irq_uninstall);
diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c
index 0d215e3..9a1450e 100644
--- a/drivers/gpu/drm/i915/i915_dma.c
+++ b/drivers/gpu/drm/i915/i915_dma.c
@@ -856,6 +856,11 @@ int i915_driver_load(struct drm_device *dev, unsigned long flags)
 
 	spin_lock_init(&dev_priv->user_irq_lock);
 
+	ret = drm_vblank_init(dev, I915_NUM_PIPE);
+
+	if (ret)
+		return ret;
+
 	return ret;
 }
 
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index ef1c0b8..ec78190 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -47,6 +47,8 @@ enum pipe {
 	PIPE_B,
 };
 
+#define I915_NUM_PIPE	2
+
 /* Interface history:
  *
  * 1.1: Original.
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 82752d6..a60af31 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -483,14 +483,9 @@ void i915_driver_irq_preinstall(struct drm_device * dev)
 int i915_driver_irq_postinstall(struct drm_device *dev)
 {
 	drm_i915_private_t *dev_priv = (drm_i915_private_t *) dev->dev_private;
-	int ret, num_pipes = 2;
-
 	/* Set initial unmasked IRQs to just the selected vblank pipes. */
 	dev_priv->irq_mask_reg = ~0;
 
-	ret = drm_vblank_init(dev, num_pipes);
-	if (ret)
-		return ret;
 
 	dev_priv->vblank_pipe = DRM_I915_VBLANK_PIPE_A | DRM_I915_VBLANK_PIPE_B;
 	dev_priv->irq_mask_reg &= ~I915_DISPLAY_PIPE_A_VBLANK_INTERRUPT;
diff --git a/include/drm/drmP.h b/include/drm/drmP.h
index 28c7f16..d5e8e5c 100644
--- a/include/drm/drmP.h
+++ b/include/drm/drmP.h
@@ -1151,6 +1151,7 @@ extern u32 drm_vblank_count(struct drm_device *dev, int crtc);
 extern void drm_handle_vblank(struct drm_device *dev, int crtc);
 extern int drm_vblank_get(struct drm_device *dev, int crtc);
 extern void drm_vblank_put(struct drm_device *dev, int crtc);
+extern void drm_vblank_cleanup(struct drm_device *dev);
 /* Modesetting support */
 extern int drm_modeset_ctl(struct drm_device *dev, void *data,
 			   struct drm_file *file_priv);

Re: [Bug #11947] 2.6.28-rc VC switching with Intel graphics broken

[Rafael J. Wysocki]

On Wednesday, 26 of November 2008, Ingo Molnar wrote:
> 
> * Bernhard Schmidt <berni-wpePDvIxQxvMZTq/7ZfH4Q@public.gmane.org> wrote:
> 
> > Hello,
> >
> >> On Monday, November 24, 2008 12:47 am Romano Giannetti (lists) wrote:
> >>> Rafael J. Wysocki wrote:
> >>>> Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=11947
> >>>> Subject		: 2.6.28-rc VC switching with Intel graphics broken
> >>>> Submitter	: Romano Giannetti <romano.giannetti-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >>>> Date		: 2008-11-03 12:10 (20 days old)
> >>>> Handled-By	: Jesse Barnes <jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org>
> >>> Still with us on -rc6, nasty, reproducible, no clues on what can be.
> >>>
> >>> VC switch locks or delay the systems minutes, resuming from suspend locks
> >>> hard the machine.
> >>>
> >>> 2.6.28-rc is unusable here.
> >>>
> >>> Jesse, any hints? My suspicion that it can be the same thing happened with
> >>> bug 10620 is wrong? (It was a very similar error about vblank...)
> >>
> >> Just added to the bug, it looks like a DUP of an issue Keith just fixed 
> >> last week (now to make sure the patch makes it upstream quickly).
> >
> > I can confirm that, with the patch from  
> > http://lists.freedesktop.org/archives/intel-gfx/2008-November/000614.html 
> > applied on top of current git head (rejected hunk in  
> > drivers/gpu/drm/i915/915_irq.c due to the additional  
> > dev_priv->irq_mask_reg = ~0; in git between the removed lines, I kept  
> > it) I can suspend/resume and do a VC switch again.
> >
> > Big thanks!
> 
> here it is below plaintext as well, merged up to latest -git.

Well, I still have a resume issue with this patch applied on Toshiba Portege
R500 (please see http://bugzilla.kernel.org/show_bug.cgi?id=12031#c9 for
details).

Thanks,
Rafael

 
> ------------------->
> From 60174462808051477793776c67282364bc94ded3 Mon Sep 17 00:00:00 2001
> From: Keith Packard <keithp-aN4HjG94KOLQT0dZR+AlfA@public.gmane.org>
> Date: Tue, 18 Nov 2008 09:30:25 -0800
> Subject: [PATCH] drm: move drm vblank initialization/cleanup to driver load/unload
> 
> drm vblank initialization keeps track of the changes in driver-supplied
> frame counts across vt switch and mode setting, but only if you let it by
> not tearing down the drm vblank structure.
> 
> Signed-off-by: Keith Packard <keithp-aN4HjG94KOLQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>
> ---
>  drivers/gpu/drm/drm_drv.c       |    2 ++
>  drivers/gpu/drm/drm_irq.c       |    4 +---
>  drivers/gpu/drm/i915/i915_dma.c |    5 +++++
>  drivers/gpu/drm/i915/i915_drv.h |    2 ++
>  drivers/gpu/drm/i915/i915_irq.c |    5 -----
>  include/drm/drmP.h              |    1 +
>  6 files changed, 11 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
> index 3ab1e9c..996097a 100644
> --- a/drivers/gpu/drm/drm_drv.c
> +++ b/drivers/gpu/drm/drm_drv.c
> @@ -305,6 +305,8 @@ static void drm_cleanup(struct drm_device * dev)
>  		return;
>  	}
>  
> +	drm_vblank_cleanup(dev);
> +
>  	drm_lastclose(dev);
>  
>  	if (drm_core_has_MTRR(dev) && drm_core_has_AGP(dev) &&
> diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c
> index 15c8dab..1e787f8 100644
> --- a/drivers/gpu/drm/drm_irq.c
> +++ b/drivers/gpu/drm/drm_irq.c
> @@ -94,7 +94,7 @@ static void vblank_disable_fn(unsigned long arg)
>  	}
>  }
>  
> -static void drm_vblank_cleanup(struct drm_device *dev)
> +void drm_vblank_cleanup(struct drm_device *dev)
>  {
>  	/* Bail if the driver didn't call drm_vblank_init() */
>  	if (dev->num_crtcs == 0)
> @@ -278,8 +278,6 @@ int drm_irq_uninstall(struct drm_device * dev)
>  
>  	free_irq(dev->pdev->irq, dev);
>  
> -	drm_vblank_cleanup(dev);
> -
>  	return 0;
>  }
>  EXPORT_SYMBOL(drm_irq_uninstall);
> diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c
> index 0d215e3..9a1450e 100644
> --- a/drivers/gpu/drm/i915/i915_dma.c
> +++ b/drivers/gpu/drm/i915/i915_dma.c
> @@ -856,6 +856,11 @@ int i915_driver_load(struct drm_device *dev, unsigned long flags)
>  
>  	spin_lock_init(&dev_priv->user_irq_lock);
>  
> +	ret = drm_vblank_init(dev, I915_NUM_PIPE);
> +
> +	if (ret)
> +		return ret;
> +
>  	return ret;
>  }
>  
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index ef1c0b8..ec78190 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -47,6 +47,8 @@ enum pipe {
>  	PIPE_B,
>  };
>  
> +#define I915_NUM_PIPE	2
> +
>  /* Interface history:
>   *
>   * 1.1: Original.
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index 82752d6..a60af31 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -483,14 +483,9 @@ void i915_driver_irq_preinstall(struct drm_device * dev)
>  int i915_driver_irq_postinstall(struct drm_device *dev)
>  {
>  	drm_i915_private_t *dev_priv = (drm_i915_private_t *) dev->dev_private;
> -	int ret, num_pipes = 2;
> -
>  	/* Set initial unmasked IRQs to just the selected vblank pipes. */
>  	dev_priv->irq_mask_reg = ~0;
>  
> -	ret = drm_vblank_init(dev, num_pipes);
> -	if (ret)
> -		return ret;
>  
>  	dev_priv->vblank_pipe = DRM_I915_VBLANK_PIPE_A | DRM_I915_VBLANK_PIPE_B;
>  	dev_priv->irq_mask_reg &= ~I915_DISPLAY_PIPE_A_VBLANK_INTERRUPT;
> diff --git a/include/drm/drmP.h b/include/drm/drmP.h
> index 28c7f16..d5e8e5c 100644
> --- a/include/drm/drmP.h
> +++ b/include/drm/drmP.h
> @@ -1151,6 +1151,7 @@ extern u32 drm_vblank_count(struct drm_device *dev, int crtc);
>  extern void drm_handle_vblank(struct drm_device *dev, int crtc);
>  extern int drm_vblank_get(struct drm_device *dev, int crtc);
>  extern void drm_vblank_put(struct drm_device *dev, int crtc);
> +extern void drm_vblank_cleanup(struct drm_device *dev);
>  /* Modesetting support */
>  extern int drm_modeset_ctl(struct drm_device *dev, void *data,
>  			   struct drm_file *file_priv);
> 
> 



-- 
Everyone knows that debugging is twice as hard as writing a program
in the first place.  So if you're as clever as you can be when you write it,
how will you ever debug it? --- Brian Kernighan

[Bug #11947] 2.6.28-rc VC switching with Intel graphics broken

[Rafael J. Wysocki]

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27.  Please verify if it still should be listed and let me know
(either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=11947
Subject		: 2.6.28-rc VC switching with Intel graphics broken
Submitter	: Romano Giannetti <romano.giannetti-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date		: 2008-11-03 12:10 (31 days old)
Handled-By	: Jesse Barnes <jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org>

Re: [Bug #11947] 2.6.28-rc VC switching with Intel graphics broken

[Romano Giannetti (lists)]

Rafael J. Wysocki wrote:
> 
> Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=11947
> Subject		: 2.6.28-rc VC switching with Intel graphics broken
> Submitter	: Romano Giannetti <romano.giannetti-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Date		: 2008-11-03 12:10 (31 days old)
> Handled-By	: Jesse Barnes <jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org>
> 

It is fixed for me in -rc7-105 (to be exact, it seems that commit 52440211dc 
fixed it), but there are more people with a very similar problem still unfixed.

Romano

-- 
Sorry for the disclaimer --- ¡I cannot stop it!


--
La presente comunicación tiene carácter confidencial y es para el exclusivo uso del destinatario indicado en la misma. Si Ud. no es el destinatario indicado, le informamos que cualquier forma de distribución, reproducción o uso de esta comunicación y/o de la información contenida en la misma están estrictamente prohibidos por la ley. Si Ud. ha recibido esta comunicación por error, por favor, notifíquelo inmediatamente al remitente contestando a este mensaje y proceda a continuación a destruirlo. Gracias por su colaboración.

This communication contains confidential information. It is for the exclusive use of the intended addressee. If you are not the intended addressee, please note that any form of distribution, copying or use of this communication or the information in it is strictly prohibited by law. If you have received this communication in error, please immediately notify the sender by reply e-mail and destroy this message. Thank you for your cooperation. 

2.6.28-rc8-git5: Reported regressions from 2.6.27

[Rafael J. Wysocki]

This message contains a list of some regressions from 2.6.27, for which there
are no fixes in the mainline I know of.  If any of them have been fixed already,
please let me know.

If you know of any other unresolved regressions from 2.6.27, please let me know
either and I'll add them to the list.  Also, please let me know if any of the
entries below are invalid.

Each entry from the list will be sent additionally in an automatic reply to
this message with CCs to the people involved in reporting and handling the
issue.


Listed regressions statistics:

  Date          Total  Pending  Unresolved
  ----------------------------------------
  2008-12-07      106       20          17
  2008-12-04      106       29          21
  2008-11-22       93       25          15
  2008-11-16       89       32          18
  2008-11-09       73       40          27
  2008-11-02       55       41          29
  2008-10-25       26       25          20


Unresolved regressions
----------------------

Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=12178
Subject		: Xorg crash at first start
Submitter	: Cédric Godin <cedric-x1Cn44Nr1HaZIoH1IeqzKA@public.gmane.org>
Date		: 2008-12-04 14:26 (4 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=52440211dcdc52c0b757f8b34d122e11b12cdd50
References	: http://marc.info/?l=linux-kernel&m=122840082828098&w=4


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=12161
Subject		: [i915 drm] irq 16: nobody cared with latest git kernels
Submitter	: fredi ml <mailinglists.fredi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date		: 2008-12-02 13:26 (6 days old)
References	: http://marc.info/?l=linux-kernel&m=122822444615724&w=4


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=12160
Subject		: networking oops after resume from s2ram (2.6.28-rc6)
Submitter	: Marcin Slusarz <marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date		: 2008-11-28 21:15 (10 days old)
References	: http://marc.info/?l=linux-kernel&m=122790701615723&w=4


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=12159
Subject		: 2.6.28-rc6-git1 -- No sound produced from Intel HDA ALSA driver
Submitter	: Miles Lane <miles.lane-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date		: 2008-11-27 20:33 (11 days old)
References	: http://marc.info/?l=linux-kernel&m=122781805620212&w=4
Handled-By	: Takashi Iwai <tiwai-l3A5Bk7waGM@public.gmane.org>


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=12158
Subject		: commit b1ee26b freezes system on switching from X to text console
Submitter	: Gaudenz Steinlin <gaudenz-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
Date		: 2008-11-25 19:44 (13 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=b1ee26bab14886350ba12a5c10cbc0696ac679bf
References	: http://marc.info/?l=linux-kernel&m=122764344231140&w=4
Handled-By	: Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=12156
Subject		: v2.6.28-rc2: x86_32 relocation regression?
Submitter	: Vegard Nossum <vegard.nossum-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date		: 2008-11-24 21:19 (14 days old)
References	: http://marc.info/?l=linux-kernel&m=122756158220966&w=4


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=12155
Subject		: Regression in 2.6.28-rc and 2.6.27-stable - hibernate related
Submitter	: Fabio Comolli <fabio.comolli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date		: 2008-11-23 16:17 (15 days old)
References	: http://marc.info/?l=linux-kernel&m=122745709926361&w=4


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=12152
Subject		: Huge wakeups number from i1915
Submitter	: Yves-Alexis Perez <corsac-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
Date		: 2008-12-02 16:48 (6 days old)
References	: http://marc.info/?l=linux-acpi&m=122823656702994&w=4


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=12100
Subject		: resume (S2R) broken by Intel microcode module, on A110L
Submitter	: Andreas Mohr <andi-5+Cda9B46AM@public.gmane.org>
Date		: 2008-11-25 08:48 (13 days old)


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=12061
Subject		: snd_hda_intel: power_save: sound cracks on powerdown
Submitter	: Jens Weibler <bugzilla-kernel-6hJTtV8wudIr9FUcG+3rRQ@public.gmane.org>
Date		: 2008-11-18 12:07 (20 days old)
Handled-By	: Takashi Iwai <tiwai-l3A5Bk7waGM@public.gmane.org>


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=12034
Subject		: snd-hda-intel on Realtek ALC268 chip shows only Master volume (for playback)
Submitter	: Sergey <azure-IGUVrPOATOfsG83rWm+8vg@public.gmane.org>
Date		: 2008-11-15 04:20 (23 days old)
Handled-By	: Takashi Iwai <tiwai-l3A5Bk7waGM@public.gmane.org>


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=12028
Subject		: i915 DRM is broken in 2.6.28-rc4
Submitter	: Adam Tkac <vonsch-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date		: 2008-11-14 01:50 (24 days old)


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=11958
Subject		: [2.6.27.x =&gt; 2.6.28-rc3] Xorg crash with xf86MapVidMem error
Submitter	: Tomasz Chmielewski <tch-Nem3ZqsbT/g@public.gmane.org>
Date		: 2008-11-05 05:37 (33 days old)


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=11947
Subject		: 2.6.28-rc VC switching with Intel graphics broken
Submitter	: Romano Giannetti <romano.giannetti-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date		: 2008-11-03 12:10 (35 days old)
Handled-By	: Jesse Barnes <jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org>


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=11906
Subject		: 2.6.28-rc2 seems to fail at powering down the monitor when it should
Submitter	: Gene Heskett <gene.heskett-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date		: 2008-10-30 6:39 (39 days old)
References	: http://marc.info/?l=linux-kernel&m=122534879721424&w=4


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=11858
Subject		: Timeout regression introduced by 242f9dcb8ba6f68fcd217a119a7648a4f69290e9
Submitter	: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Date		: 2008-10-26 9:46 (43 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=242f9dcb8ba6f68fcd217a119a7648a4f69290e9
References	: http://marc.info/?l=linux-kernel&m=122501447326698&w=4


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=11849
Subject		: default IRQ affinity change in v2.6.27 (breaking several SMP PPC based systems)
Submitter	: Kumar Gala <galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
Date		: 2008-10-24 12:45 (45 days old)
References	: http://marc.info/?l=linux-kernel&m=122485245924125&w=4


Regressions with patches
------------------------

Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=12177
Subject		: [memcg BUG ?] failed to boot on IA64 with CONFIG_DISCONTIGMEM=y
Submitter	: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
Date		: 2008-12-05 3:09 (3 days old)
References	: http://marc.info/?l=linux-kernel&m=122844668532752&w=4
Handled-By	: KAMEZAWA Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
Patch		: http://marc.info/?l=linux-kernel&m=122844757701505&w=4


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=12047
Subject		: ACPI toshiba: only register rfkill if bt is enabled
Submitter	: Andrey Borzenkov <arvidjaar-JGs/UdohzUI@public.gmane.org>
Date		: 2008-10-28 19:10 (41 days old)
References	: http://marc.info/?l=linux-kernel&m=122522113619025&w=2
Handled-By	: Frederik Deweerdt <frederik.deweerdt-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Patch		: http://marc.info/?l=linux-kernel&m=122526843117478&w=2


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=11898
Subject		: mke2fs hang on AIC79 device.
Submitter	: alexs <alex.shi-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Date		: 2008-10-30 01:17 (39 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=f0c0a376d0fcd4c5579ecf5e95f88387cba85211
Handled-By	: James Bottomley <James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
		  Mike Christie <michaelc-hcNo3dDEHLuVc3sceRu5cw@public.gmane.org>
Patch		: http://bugzilla.kernel.org/show_bug.cgi?id=11898#c28
		  http://bugzilla.kernel.org/show_bug.cgi?id=11898#c36


For details, please visit the bug entries and follow the links given in
references.

As you can see, there is a Bugzilla entry for each of the listed regressions.
There also is a Bugzilla entry used for tracking the regressions from 2.6.27,
unresolved as well as resolved, at:

http://bugzilla.kernel.org/show_bug.cgi?id=11808

Please let me know if there are any Bugzilla entries that should be added to
the list in there.

Thanks,
Rafael

[Bug #11849] default IRQ affinity change in v2.6.27 (breaking several SMP PPC based systems)

[Rafael J. Wysocki]

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27.  Please verify if it still should be listed and let me know
(either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=11849
Subject		: default IRQ affinity change in v2.6.27 (breaking several SMP PPC based systems)
Submitter	: Kumar Gala <galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
Date		: 2008-10-24 12:45 (45 days old)
References	: http://marc.info/?l=linux-kernel&m=122485245924125&w=4

[Bug #11858] Timeout regression introduced by 242f9dcb8ba6f68fcd217a119a7648a4f69290e9

[Rafael J. Wysocki]

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27.  Please verify if it still should be listed and let me know
(either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=11858
Subject		: Timeout regression introduced by 242f9dcb8ba6f68fcd217a119a7648a4f69290e9
Submitter	: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Date		: 2008-10-26 9:46 (43 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=242f9dcb8ba6f68fcd217a119a7648a4f69290e9
References	: http://marc.info/?l=linux-kernel&m=122501447326698&w=4

[Bug #11906] 2.6.28-rc2 seems to fail at powering down the monitor when it should

[Rafael J. Wysocki]

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27.  Please verify if it still should be listed and let me know
(either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=11906
Subject		: 2.6.28-rc2 seems to fail at powering down the monitor when it should
Submitter	: Gene Heskett <gene.heskett-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date		: 2008-10-30 6:39 (39 days old)
References	: http://marc.info/?l=linux-kernel&m=122534879721424&w=4

[Bug #11898] mke2fs hang on AIC79 device.

[Rafael J. Wysocki]

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27.  Please verify if it still should be listed and let me know
(either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=11898
Subject		: mke2fs hang on AIC79 device.
Submitter	: alexs <alex.shi-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Date		: 2008-10-30 01:17 (39 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=f0c0a376d0fcd4c5579ecf5e95f88387cba85211
Handled-By	: James Bottomley <James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
		  Mike Christie <michaelc-hcNo3dDEHLuVc3sceRu5cw@public.gmane.org>
Patch		: http://bugzilla.kernel.org/show_bug.cgi?id=11898#c28
		  http://bugzilla.kernel.org/show_bug.cgi?id=11898#c36

[Bug #11958] [2.6.27.x => 2.6.28-rc3] Xorg crash with xf86MapVidMem error

[Rafael J. Wysocki]

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27.  Please verify if it still should be listed and let me know
(either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=11958
Subject		: [2.6.27.x => 2.6.28-rc3] Xorg crash with xf86MapVidMem error
Submitter	: Tomasz Chmielewski <tch-Nem3ZqsbT/g@public.gmane.org>
Date		: 2008-11-05 05:37 (33 days old)

[Bug #12028] i915 DRM is broken in 2.6.28-rc4

[Rafael J. Wysocki]

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27.  Please verify if it still should be listed and let me know
(either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=12028
Subject		: i915 DRM is broken in 2.6.28-rc4
Submitter	: Adam Tkac <vonsch-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date		: 2008-11-14 01:50 (24 days old)

[Bug #12034] snd-hda-intel on Realtek ALC268 chip shows only Master volume (for playback)

[Rafael J. Wysocki]

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27.  Please verify if it still should be listed and let me know
(either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=12034
Subject		: snd-hda-intel on Realtek ALC268 chip shows only Master volume (for playback)
Submitter	: Sergey <azure-IGUVrPOATOfsG83rWm+8vg@public.gmane.org>
Date		: 2008-11-15 04:20 (23 days old)
Handled-By	: Takashi Iwai <tiwai-l3A5Bk7waGM@public.gmane.org>

[Bug #11947] 2.6.28-rc VC switching with Intel graphics broken

[Rafael J. Wysocki]

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27.  Please verify if it still should be listed and let me know
(either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=11947
Subject		: 2.6.28-rc VC switching with Intel graphics broken
Submitter	: Romano Giannetti <romano.giannetti-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date		: 2008-11-03 12:10 (35 days old)
Handled-By	: Jesse Barnes <jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org>

[Bug #12100] resume (S2R) broken by Intel microcode module, on A110L

[Rafael J. Wysocki]

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27.  Please verify if it still should be listed and let me know
(either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=12100
Subject		: resume (S2R) broken by Intel microcode module, on A110L
Submitter	: Andreas Mohr <andi-5+Cda9B46AM@public.gmane.org>
Date		: 2008-11-25 08:48 (13 days old)

[Bug #12061] snd_hda_intel: power_save: sound cracks on powerdown

[Rafael J. Wysocki]

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27.  Please verify if it still should be listed and let me know
(either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=12061
Subject		: snd_hda_intel: power_save: sound cracks on powerdown
Submitter	: Jens Weibler <bugzilla-kernel-6hJTtV8wudIr9FUcG+3rRQ@public.gmane.org>
Date		: 2008-11-18 12:07 (20 days old)
Handled-By	: Takashi Iwai <tiwai-l3A5Bk7waGM@public.gmane.org>

[Bug #12152] Huge wakeups number from i1915

[Rafael J. Wysocki]

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27.  Please verify if it still should be listed and let me know
(either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=12152
Subject		: Huge wakeups number from i1915
Submitter	: Yves-Alexis Perez <corsac-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
Date		: 2008-12-02 16:48 (6 days old)
References	: http://marc.info/?l=linux-acpi&m=122823656702994&w=4

[Bug #12047] ACPI toshiba: only register rfkill if bt is enabled

[Rafael J. Wysocki]

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27.  Please verify if it still should be listed and let me know
(either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=12047
Subject		: ACPI toshiba: only register rfkill if bt is enabled
Submitter	: Andrey Borzenkov <arvidjaar-JGs/UdohzUI@public.gmane.org>
Date		: 2008-10-28 19:10 (41 days old)
References	: http://marc.info/?l=linux-kernel&m=122522113619025&w=2
Handled-By	: Frederik Deweerdt <frederik.deweerdt-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Patch		: http://marc.info/?l=linux-kernel&m=122526843117478&w=2

[Bug #12155] Regression in 2.6.28-rc and 2.6.27-stable - hibernate related

[Rafael J. Wysocki]

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27.  Please verify if it still should be listed and let me know
(either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=12155
Subject		: Regression in 2.6.28-rc and 2.6.27-stable - hibernate related
Submitter	: Fabio Comolli <fabio.comolli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date		: 2008-11-23 16:17 (15 days old)
References	: http://marc.info/?l=linux-kernel&m=122745709926361&w=4

[Bug #12156] v2.6.28-rc2: x86_32 relocation regression?

[Rafael J. Wysocki]

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27.  Please verify if it still should be listed and let me know
(either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=12156
Subject		: v2.6.28-rc2: x86_32 relocation regression?
Submitter	: Vegard Nossum <vegard.nossum-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date		: 2008-11-24 21:19 (14 days old)
References	: http://marc.info/?l=linux-kernel&m=122756158220966&w=4

[Bug #12160] networking oops after resume from s2ram (2.6.28-rc6)

[Rafael J. Wysocki]

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27.  Please verify if it still should be listed and let me know
(either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=12160
Subject		: networking oops after resume from s2ram (2.6.28-rc6)
Submitter	: Marcin Slusarz <marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date		: 2008-11-28 21:15 (10 days old)
References	: http://marc.info/?l=linux-kernel&m=122790701615723&w=4

[Bug #12159] 2.6.28-rc6-git1 -- No sound produced from Intel HDA ALSA driver

[Rafael J. Wysocki]

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27.  Please verify if it still should be listed and let me know
(either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=12159
Subject		: 2.6.28-rc6-git1 -- No sound produced from Intel HDA ALSA driver
Submitter	: Miles Lane <miles.lane-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date		: 2008-11-27 20:33 (11 days old)
References	: http://marc.info/?l=linux-kernel&m=122781805620212&w=4
Handled-By	: Takashi Iwai <tiwai-l3A5Bk7waGM@public.gmane.org>

[Bug #12158] commit b1ee26b freezes system on switching from X to text console

[Rafael J. Wysocki]

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27.  Please verify if it still should be listed and let me know
(either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=12158
Subject		: commit b1ee26b freezes system on switching from X to text console
Submitter	: Gaudenz Steinlin <gaudenz-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
Date		: 2008-11-25 19:44 (13 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=b1ee26bab14886350ba12a5c10cbc0696ac679bf
References	: http://marc.info/?l=linux-kernel&m=122764344231140&w=4
Handled-By	: Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>

[Bug #12178] Xorg crash at first start

[Rafael J. Wysocki]

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27.  Please verify if it still should be listed and let me know
(either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=12178
Subject		: Xorg crash at first start
Submitter	: Cédric Godin <cedric-x1Cn44Nr1HaZIoH1IeqzKA@public.gmane.org>
Date		: 2008-12-04 14:26 (4 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=52440211dcdc52c0b757f8b34d122e11b12cdd50
References	: http://marc.info/?l=linux-kernel&m=122840082828098&w=4

[Bug #12161] [i915 drm] irq 16: nobody cared with latest git kernels

[Rafael J. Wysocki]

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27.  Please verify if it still should be listed and let me know
(either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=12161
Subject		: [i915 drm] irq 16: nobody cared with latest git kernels
Submitter	: fredi ml <mailinglists.fredi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date		: 2008-12-02 13:26 (6 days old)
References	: http://marc.info/?l=linux-kernel&m=122822444615724&w=4

[Bug #12177] [memcg BUG ?] failed to boot on IA64 with CONFIG_DISCONTIGMEM=y

[Rafael J. Wysocki]

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27.  Please verify if it still should be listed and let me know
(either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=12177
Subject		: [memcg BUG ?] failed to boot on IA64 with CONFIG_DISCONTIGMEM=y
Submitter	: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
Date		: 2008-12-05 3:09 (3 days old)
References	: http://marc.info/?l=linux-kernel&m=122844668532752&w=4
Handled-By	: KAMEZAWA Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
Patch		: http://marc.info/?l=linux-kernel&m=122844757701505&w=4

Re: [Bug #12152] Huge wakeups number from i1915

[Arjan van de Ven]

On Sun,  7 Dec 2008 21:32:54 +0100 (CET)
"Rafael J. Wysocki" <rjw-KKrjLPT3xs0@public.gmane.org> wrote:

> This message has been generated automatically as a part of a report
> of recent regressions.
> 
> The following bug entry is on the current list of known regressions
> from 2.6.27.  Please verify if it still should be listed and let me
> know (either way).
> 
> 
> Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=12152
> Subject		: Huge wakeups number from i1915
> Submitter	: Yves-Alexis Perez <corsac-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
> Date		: 2008-12-02 16:48 (6 days old)
> References	:
> http://marc.info/?l=linux-acpi&m=122823656702994&w=4
> 

at least in some of the cases where this has been seen the cause is the
following:
The i915 DRM driver used to do polling for completion, busy waiting. It
moved to be interrupt driven, which is usually better for power, but it
will show up as more wakeups in powertop....


-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org

Re: [Bug #12152] Huge wakeups number from i1915

[Rafael J. Wysocki]

On Sunday, 7 of December 2008, Arjan van de Ven wrote:
> On Sun,  7 Dec 2008 21:32:54 +0100 (CET)
> "Rafael J. Wysocki" <rjw-KKrjLPT3xs0@public.gmane.org> wrote:
> 
> > This message has been generated automatically as a part of a report
> > of recent regressions.
> > 
> > The following bug entry is on the current list of known regressions
> > from 2.6.27.  Please verify if it still should be listed and let me
> > know (either way).
> > 
> > 
> > Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=12152
> > Subject		: Huge wakeups number from i1915
> > Submitter	: Yves-Alexis Perez <corsac-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
> > Date		: 2008-12-02 16:48 (6 days old)
> > References	:
> > http://marc.info/?l=linux-acpi&m=122823656702994&w=4
> > 
> 
> at least in some of the cases where this has been seen the cause is the
> following:
> The i915 DRM driver used to do polling for completion, busy waiting. It
> moved to be interrupt driven, which is usually better for power, but it
> will show up as more wakeups in powertop....

IOW, this is not a regression?

Rafael

Re: [Bug #12152] Huge wakeups number from i1915

[Arjan van de Ven]

On Sun, 7 Dec 2008 23:52:06 +0100
"Rafael J. Wysocki" <rjw-KKrjLPT3xs0@public.gmane.org> wrote:

> On Sunday, 7 of December 2008, Arjan van de Ven wrote:
> > On Sun,  7 Dec 2008 21:32:54 +0100 (CET)
> > "Rafael J. Wysocki" <rjw-KKrjLPT3xs0@public.gmane.org> wrote:
> > 
> > > This message has been generated automatically as a part of a
> > > report of recent regressions.
> > > 
> > > The following bug entry is on the current list of known
> > > regressions from 2.6.27.  Please verify if it still should be
> > > listed and let me know (either way).
> > > 
> > > 
> > > Bug-Entry	:
> > > http://bugzilla.kernel.org/show_bug.cgi?id=12152
> > > Subject		: Huge wakeups number from i1915
> > > Submitter	: Yves-Alexis Perez <corsac-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
> > > Date		: 2008-12-02 16:48 (6 days old)
> > > References	:
> > > http://marc.info/?l=linux-acpi&m=122823656702994&w=4
> > > 
> > 
> > at least in some of the cases where this has been seen the cause is
> > the following:
> > The i915 DRM driver used to do polling for completion, busy
> > waiting. It moved to be interrupt driven, which is usually better
> > for power, but it will show up as more wakeups in powertop....
> 
> IOW, this is not a regression?

I don't know about this specifc case (not enough information) but for
the case I described it's not a regression. Going to interrupt driven
from busy waiting is an improvement not a regression :)

-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org

Re: [Bug #12152] Huge wakeups number from i1915

[Rafael J. Wysocki]

On Monday, 8 of December 2008, Arjan van de Ven wrote:
> On Sun, 7 Dec 2008 23:52:06 +0100
> "Rafael J. Wysocki" <rjw-KKrjLPT3xs0@public.gmane.org> wrote:
> 
> > On Sunday, 7 of December 2008, Arjan van de Ven wrote:
> > > On Sun,  7 Dec 2008 21:32:54 +0100 (CET)
> > > "Rafael J. Wysocki" <rjw-KKrjLPT3xs0@public.gmane.org> wrote:
> > > 
> > > > This message has been generated automatically as a part of a
> > > > report of recent regressions.
> > > > 
> > > > The following bug entry is on the current list of known
> > > > regressions from 2.6.27.  Please verify if it still should be
> > > > listed and let me know (either way).
> > > > 
> > > > 
> > > > Bug-Entry	:
> > > > http://bugzilla.kernel.org/show_bug.cgi?id=12152
> > > > Subject		: Huge wakeups number from i1915
> > > > Submitter	: Yves-Alexis Perez <corsac-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
> > > > Date		: 2008-12-02 16:48 (6 days old)
> > > > References	:
> > > > http://marc.info/?l=linux-acpi&m=122823656702994&w=4
> > > > 
> > > 
> > > at least in some of the cases where this has been seen the cause is
> > > the following:
> > > The i915 DRM driver used to do polling for completion, busy
> > > waiting. It moved to be interrupt driven, which is usually better
> > > for power, but it will show up as more wakeups in powertop....
> > 
> > IOW, this is not a regression?
> 
> I don't know about this specifc case (not enough information) but for
> the case I described it's not a regression. Going to interrupt driven
> from busy waiting is an improvement not a regression :)

Sure it is. :-)

Let's wait for the reporter to respond.

Re: [Bug #12152] Huge wakeups number from i1915

[Yves-Alexis Perez]

[-- Attachment #1: Type: text/plain, Size: 987 bytes --]

On dim, 2008-12-07 at 15:12 -0800, Arjan van de Ven wrote:
> 
> > > at least in some of the cases where this has been seen the cause
> is
> > > the following:
> > > The i915 DRM driver used to do polling for completion, busy
> > > waiting. It moved to be interrupt driven, which is usually better
> > > for power, but it will show up as more wakeups in powertop....
> > 
> > IOW, this is not a regression?
> 
> I don't know about this specifc case (not enough information) but for
> the case I described it's not a regression. Going to interrupt driven
> from busy waiting is an improvement not a regression :)

Well, several thousand or more interrupts really seems like a
regression :). But it seems that's the same thing as the “IRQ
spinning” (there was a thread on dri-devel about that).

It seems fixed with a patch from Matthew Garrett applied to
drm-intel/for-airlied but I don't think this has been applied to Linus
master.

Cheers,
-- 
Yves-Alexis

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [Bug #12152] Huge wakeups number from i1915

[Yves-Alexis Perez]

[-- Attachment #1: Type: text/plain, Size: 1178 bytes --]

On lun, 2008-12-08 at 07:24 +0100, Yves-Alexis Perez wrote:
> On dim, 2008-12-07 at 15:12 -0800, Arjan van de Ven wrote:
> > 
> > > > at least in some of the cases where this has been seen the cause
> > is
> > > > the following:
> > > > The i915 DRM driver used to do polling for completion, busy
> > > > waiting. It moved to be interrupt driven, which is usually better
> > > > for power, but it will show up as more wakeups in powertop....
> > > 
> > > IOW, this is not a regression?
> > 
> > I don't know about this specifc case (not enough information) but for
> > the case I described it's not a regression. Going to interrupt driven
> > from busy waiting is an improvement not a regression :)
> 
> Well, several thousand or more interrupts really seems like a
> regression :). But it seems that's the same thing as the “IRQ
> spinning” (there was a thread on dri-devel about that).
> 
> It seems fixed with a patch from Matthew Garrett applied to
> drm-intel/for-airlied but I don't think this has been applied to Linus
> master.

And it seems the same thing as
https://bugs.freedesktop.org/show_bug.cgi?id=18609

Cheers,
-- 
Yves-Alexis

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [Bug #12177] [memcg BUG ?] failed to boot on IA64 with CONFIG_DISCONTIGMEM=y

[Balbir Singh]

* Rafael J. Wysocki <rjw-KKrjLPT3xs0@public.gmane.org> [2008-12-07 21:32:57]:

> This message has been generated automatically as a part of a report
> of recent regressions.
> 
> The following bug entry is on the current list of known regressions
> from 2.6.27.  Please verify if it still should be listed and let me know
> (either way).
> 
> 
> Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=12177
> Subject		: [memcg BUG ?] failed to boot on IA64 with CONFIG_DISCONTIGMEM=y
> Submitter	: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
> Date		: 2008-12-05 3:09 (3 days old)
> References	: http://marc.info/?l=linux-kernel&m=122844668532752&w=4
> Handled-By	: KAMEZAWA Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
> Patch		: http://marc.info/?l=linux-kernel&m=122844757701505&w=4

Kamezawa has a fix that Li has tested. We need to polish the changelog
and resend the patch.

-- 
	Balbir

Re: [Bug #12152] Huge wakeups number from i1915

[Rafael J. Wysocki]

On Monday, 8 of December 2008, Yves-Alexis Perez wrote:
> On dim, 2008-12-07 at 15:12 -0800, Arjan van de Ven wrote:
> > 
> > > > at least in some of the cases where this has been seen the cause
> > is
> > > > the following:
> > > > The i915 DRM driver used to do polling for completion, busy
> > > > waiting. It moved to be interrupt driven, which is usually better
> > > > for power, but it will show up as more wakeups in powertop....
> > > 
> > > IOW, this is not a regression?
> > 
> > I don't know about this specifc case (not enough information) but for
> > the case I described it's not a regression. Going to interrupt driven
> > from busy waiting is an improvement not a regression :)
> 
> Well, several thousand or more interrupts really seems like a
> regression :). But it seems that's the same thing as the “IRQ
> spinning” (there was a thread on dri-devel about that).
> 
> It seems fixed with a patch from Matthew Garrett applied to
> drm-intel/for-airlied but I don't think this has been applied to Linus
> master.

Any pointers to the patch, please?

Rafael

Re: [Bug #12177] [memcg BUG ?] failed to boot on IA64 with CONFIG_DISCONTIGMEM=y

[Rafael J. Wysocki]

On Monday, 8 of December 2008, Balbir Singh wrote:
> * Rafael J. Wysocki <rjw-KKrjLPT3xs0@public.gmane.org> [2008-12-07 21:32:57]:
> 
> > This message has been generated automatically as a part of a report
> > of recent regressions.
> > 
> > The following bug entry is on the current list of known regressions
> > from 2.6.27.  Please verify if it still should be listed and let me know
> > (either way).
> > 
> > 
> > Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=12177
> > Subject		: [memcg BUG ?] failed to boot on IA64 with CONFIG_DISCONTIGMEM=y
> > Submitter	: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
> > Date		: 2008-12-05 3:09 (3 days old)
> > References	: http://marc.info/?l=linux-kernel&m=122844668532752&w=4
> > Handled-By	: KAMEZAWA Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
> > Patch		: http://marc.info/?l=linux-kernel&m=122844757701505&w=4
> 
> Kamezawa has a fix that Li has tested. We need to polish the changelog
> and resend the patch.

Thanks for the update.

Rafael

Re: [Bug #12152] Huge wakeups number from i1915

[Yves-Alexis Perez]

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

On lun, 2008-12-08 at 08:28 +0100, Rafael J. Wysocki wrote:
> Any pointers to the patch, please?

The patch I had success with was the one enabling MSI on 965. You can
find it there:

http://marc.info/?l=dri-devel&m=122843874524733&w=2

Not sure if it's “the one” really usable, but at least it fixes the
problem for now.

Cheers,
-- 
Yves-Alexis

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [Bug #12152] Huge wakeups number from i1915

[Matthew Garrett]

On Mon, Dec 08, 2008 at 08:28:07AM +0100, Rafael J. Wysocki wrote:
> On Monday, 8 of December 2008, Yves-Alexis Perez wrote:
> > On dim, 2008-12-07 at 15:12 -0800, Arjan van de Ven wrote:
> > > 
> > > > > at least in some of the cases where this has been seen the cause
> > > is
> > > > > the following:
> > > > > The i915 DRM driver used to do polling for completion, busy
> > > > > waiting. It moved to be interrupt driven, which is usually better
> > > > > for power, but it will show up as more wakeups in powertop....
> > > > 
> > > > IOW, this is not a regression?
> > > 
> > > I don't know about this specifc case (not enough information) but for
> > > the case I described it's not a regression. Going to interrupt driven
> > > from busy waiting is an improvement not a regression :)
> > 
> > Well, several thousand or more interrupts really seems like a
> > regression :). But it seems that's the same thing as the “IRQ
> > spinning” (there was a thread on dri-devel about that).
> > 
> > It seems fixed with a patch from Matthew Garrett applied to
> > drm-intel/for-airlied but I don't think this has been applied to Linus
> > master.
> 
> Any pointers to the patch, please?

Doesn't ring any bells for me...

-- 
Matthew Garrett | mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org

Re: [Bug #12152] Huge wakeups number from i1915

[Yves-Alexis Perez]

> Doesn't ring any bells for me...

This was the “irq spinning” thread on dri-devel.
-- 
Yves-Alexis

Re: [Bug #12152] Huge wakeups number from i1915

[Matthew Garrett]

On Mon, Dec 08, 2008 at 05:19:49PM +0100, Yves-Alexis Perez wrote:
> > Doesn't ring any bells for me...
> 
> This was the “irq spinning” thread on dri-devel.

Looks like the patch was from Keith, not me?

Unrelatedly, I didn't get the Cc:ed copy of this mail. Did you get a 
bounce?
-- 
Matthew Garrett | mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org