Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Kiper <daniel.kiper@oracle.com>
To: andrew.cooper3@citrix.com, david.vrabel@citrix.com,
	kumagai-atsushi@mxc.nes.nec.co.jp, kexec@lists.infradead.org,
	xen-devel@lists.xen.org
Cc: Daniel Kiper <daniel.kiper@oracle.com>
Subject: [PATCH v2 3/4] makedumpfile/xen: Fail immediately on every architecture if dump level is invalid
Date: Mon,  2 Dec 2013 15:16:43 +0100	[thread overview]
Message-ID: <1385993804-27721-4-git-send-email-daniel.kiper@oracle.com> (raw)
In-Reply-To: <1385993804-27721-1-git-send-email-daniel.kiper@oracle.com>

Do not try to process Xen crash dump on every architecture if dump level
is invalid. Fail immediately and print relevant error message.

Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
---
 makedumpfile.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/makedumpfile.c b/makedumpfile.c
index 5a378d1..45f96aa 100644
--- a/makedumpfile.c
+++ b/makedumpfile.c
@@ -7637,14 +7637,14 @@ initial_xen(void)
 		MSG("Try `makedumpfile --help' for more information.\n");
 		return FALSE;
 	}
-#ifndef __x86_64__
+
 	if (DL_EXCLUDE_ZERO < info->max_dump_level) {
 		MSG("Dump_level is invalid. It should be 0 or 1.\n");
 		MSG("Commandline parameter is invalid.\n");
 		MSG("Try `makedumpfile --help' for more information.\n");
 		return FALSE;
 	}
-#endif
+
 	if (!init_xen_crash_info())
 		return FALSE;
 	/*
-- 
1.7.10.4


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  parent reply	other threads:[~2013-12-02 14:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-02 14:16 [PATCH v2 0/4] makedumpfile: Xen fixes and cleanups Daniel Kiper
2013-12-02 14:16 ` [PATCH v2 1/4] makedumpfile/xen: Add cache_init() call to initial_xen() Daniel Kiper
2013-12-02 14:16 ` [PATCH v2 2/4] makedumpfile/xen: Disable cyclic mode for every Xen crash dump Daniel Kiper
2013-12-02 14:16 ` Daniel Kiper [this message]
2013-12-03  5:27   ` [PATCH v2 3/4] makedumpfile/xen: Fail immediately on every architecture if dump level is invalid Atsushi Kumagai
2013-12-03 19:45     ` Daniel Kiper
2013-12-09  2:45       ` Atsushi Kumagai
2013-12-10 10:39         ` Daniel Kiper
2013-12-13  6:59           ` Atsushi Kumagai
2013-12-17 20:28             ` Daniel Kiper
2014-08-29  6:42             ` Atsushi Kumagai
2014-09-01 21:30               ` Daniel Kiper
2013-12-02 14:16 ` [PATCH v2 4/4] makedumpfile/xen: Move cyclic mode check from initial() to initial_xen() Daniel Kiper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1385993804-27721-4-git-send-email-daniel.kiper@oracle.com \
    --to=daniel.kiper@oracle.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=david.vrabel@citrix.com \
    --cc=kexec@lists.infradead.org \
    --cc=kumagai-atsushi@mxc.nes.nec.co.jp \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox