From: Daniel Kiper <daniel.kiper@oracle.com>
To: andrew.cooper3@citrix.com, david.vrabel@citrix.com,
kumagai-atsushi@mxc.nes.nec.co.jp, kexec@lists.infradead.org,
xen-devel@lists.xen.org
Cc: Daniel Kiper <daniel.kiper@oracle.com>
Subject: [PATCH v2 2/4] makedumpfile/xen: Disable cyclic mode for every Xen crash dump
Date: Mon, 2 Dec 2013 15:16:42 +0100 [thread overview]
Message-ID: <1385993804-27721-3-git-send-email-daniel.kiper@oracle.com> (raw)
In-Reply-To: <1385993804-27721-1-git-send-email-daniel.kiper@oracle.com>
Disable cyclic mode for every Xen crash dump not only when -X option
is used. This way makedumpfile is much more flexible and different
modes could be used to dump whole system memory (e.g. zero pages
could be striped without requiring -X option).
Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
---
makedumpfile.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/makedumpfile.c b/makedumpfile.c
index 55e53b7..5a378d1 100644
--- a/makedumpfile.c
+++ b/makedumpfile.c
@@ -2928,20 +2928,20 @@ initial(void)
}
#endif
- if (info->flag_exclude_xen_dom) {
+ if (is_xen_memory()) {
if(info->flag_cyclic) {
info->flag_cyclic = FALSE;
MSG("Switched running mode from cyclic to non-cyclic,\n");
MSG("because the cyclic mode doesn't support Xen.\n");
}
+ }
- if (!is_xen_memory()) {
- MSG("'-X' option is disable,");
- MSG("because %s is not Xen's memory core image.\n", info->name_memory);
- MSG("Commandline parameter is invalid.\n");
- MSG("Try `makedumpfile --help' for more information.\n");
- return FALSE;
- }
+ if (info->flag_exclude_xen_dom && !is_xen_memory()) {
+ MSG("'-X' option is disable,");
+ MSG("because %s is not Xen's memory core image.\n", info->name_memory);
+ MSG("Commandline parameter is invalid.\n");
+ MSG("Try `makedumpfile --help' for more information.\n");
+ return FALSE;
}
if (info->flag_refiltering) {
--
1.7.10.4
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2013-12-02 14:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 14:16 [PATCH v2 0/4] makedumpfile: Xen fixes and cleanups Daniel Kiper
2013-12-02 14:16 ` [PATCH v2 1/4] makedumpfile/xen: Add cache_init() call to initial_xen() Daniel Kiper
2013-12-02 14:16 ` Daniel Kiper [this message]
2013-12-02 14:16 ` [PATCH v2 3/4] makedumpfile/xen: Fail immediately on every architecture if dump level is invalid Daniel Kiper
2013-12-03 5:27 ` Atsushi Kumagai
2013-12-03 19:45 ` Daniel Kiper
2013-12-09 2:45 ` Atsushi Kumagai
2013-12-10 10:39 ` Daniel Kiper
2013-12-13 6:59 ` Atsushi Kumagai
2013-12-17 20:28 ` Daniel Kiper
2014-08-29 6:42 ` Atsushi Kumagai
2014-09-01 21:30 ` Daniel Kiper
2013-12-02 14:16 ` [PATCH v2 4/4] makedumpfile/xen: Move cyclic mode check from initial() to initial_xen() Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385993804-27721-3-git-send-email-daniel.kiper@oracle.com \
--to=daniel.kiper@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=david.vrabel@citrix.com \
--cc=kexec@lists.infradead.org \
--cc=kumagai-atsushi@mxc.nes.nec.co.jp \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox