Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Kiper <daniel.kiper@oracle.com>
To: Atsushi Kumagai <kumagai-atsushi@mxc.nes.nec.co.jp>
Cc: Kenichi Oomichi <oomichi@mxs.nes.nec.co.jp>,
	"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
	"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
	"david.vrabel@citrix.com" <david.vrabel@citrix.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH v2 3/4] makedumpfile/xen: Fail immediately on every architecture if dump level is invalid
Date: Tue, 17 Dec 2013 21:28:07 +0100	[thread overview]
Message-ID: <20131217202807.GJ3401@olila.local.net-space.pl> (raw)
In-Reply-To: <0910DD04CBD6DE4193FCF86B9C00BE971D10DF@BPXM01GP.gisp.nec.co.jp>

On Fri, Dec 13, 2013 at 06:59:06AM +0000, Atsushi Kumagai wrote:
> On 2013/12/10 19:41:54, kexec <kexec-bounces@lists.infradead.org> wrote:

[...]

> > Docs are not consistent because man and help displayed from makedumpfile
> > are different. Additionally, even man says nothing how to use this feature
> > on Xen vmcore file. If you use makedumpfile e.g.
> >
> > makedumpfile -Ed 2 /proc/vmcore vmcore
> >
> > it will not work because it uses VMCOREINFO_XEN instead of VMCOREINFO.
> > I discovered that if you would like to use feature from above mentioned
> > patch you must run makedumpfile in following way:
> >
> > makedumpfile -Ed 2 -x vmlinux /proc/vmcore vmcore
> >
> > Then makedumpfile will get info about dom0 directly from vmlinux.
>
> Certainly the documents should be fixed as you said, I'll do it.

Thanks.

> > However, It looks that there is another bug which prevents usage
> > of this feature. It looks it is related to change in P2M tree Linux
> > code. Once P2M levels where changed from 2 to 3. I fixed similar
> > issue in crash tool once.
>
> Thanks for your pointing out, I hope that you will fix that issue
> also in makedumpfile.

Yes, I am going to do that but not now. I am just very busy. Additionally,
I have discovered that this feature code is broken in more places because
it was not maintained more than four years. So, to be honest, it is simply
unusable right now.

> > When are you going to make a new makedumpfile release? I am going
> > to fix this issue before next release but now I am quite busy
> > with other stuff.
>
> I must release the new version(v1.5.5) in the next week at the latest
> because I announced the release date will be the beginning of December
> and there are already many patches for v1.5.5.
> So I would like to slip that fix you mentioned to v1.5.6.

OK.

> > Could you apply patches 1, 2 and 4 from this patch series?
> > It looks that they are not controversial.
>
> Sure, the three patches will be merged into v1.5.5.

Thanks.

Daniel

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2013-12-17 20:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-02 14:16 [PATCH v2 0/4] makedumpfile: Xen fixes and cleanups Daniel Kiper
2013-12-02 14:16 ` [PATCH v2 1/4] makedumpfile/xen: Add cache_init() call to initial_xen() Daniel Kiper
2013-12-02 14:16 ` [PATCH v2 2/4] makedumpfile/xen: Disable cyclic mode for every Xen crash dump Daniel Kiper
2013-12-02 14:16 ` [PATCH v2 3/4] makedumpfile/xen: Fail immediately on every architecture if dump level is invalid Daniel Kiper
2013-12-03  5:27   ` Atsushi Kumagai
2013-12-03 19:45     ` Daniel Kiper
2013-12-09  2:45       ` Atsushi Kumagai
2013-12-10 10:39         ` Daniel Kiper
2013-12-13  6:59           ` Atsushi Kumagai
2013-12-17 20:28             ` Daniel Kiper [this message]
2014-08-29  6:42             ` Atsushi Kumagai
2014-09-01 21:30               ` Daniel Kiper
2013-12-02 14:16 ` [PATCH v2 4/4] makedumpfile/xen: Move cyclic mode check from initial() to initial_xen() Daniel Kiper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131217202807.GJ3401@olila.local.net-space.pl \
    --to=daniel.kiper@oracle.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=david.vrabel@citrix.com \
    --cc=kexec@lists.infradead.org \
    --cc=kumagai-atsushi@mxc.nes.nec.co.jp \
    --cc=oomichi@mxs.nes.nec.co.jp \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox