From: Baoquan He <bhe@redhat.com>
To: kexec@lists.infradead.org
Cc: kumagai-atsushi@mxc.nes.nec.co.jp, Baoquan He <bhe@redhat.com>,
vgoyal@redhat.com
Subject: [PATCH v4 1/8] initialize pfn_memhole in get_num_dumpable_cyclic
Date: Mon, 25 Aug 2014 11:33:05 +0800 [thread overview]
Message-ID: <1408937592-2609-2-git-send-email-bhe@redhat.com> (raw)
In-Reply-To: <1408937592-2609-1-git-send-email-bhe@redhat.com>
This is a code bug. In initialize_2nd_bitmap_cyclic pfn_memhole is
calculated, however it's not initialized before that. If an available
pfn_memhole is wanted after get_num_dumpable_cyclic invocation,
initializing pfn_memhole in get_num_dumpable_cyclic is necessary.
Signed-off-by: Baoquan He <bhe@redhat.com>
---
makedumpfile.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/makedumpfile.c b/makedumpfile.c
index b4b6eca..a01703e 100644
--- a/makedumpfile.c
+++ b/makedumpfile.c
@@ -5651,6 +5651,8 @@ get_num_dumpable_cyclic(void)
mdf_pfn_t pfn, num_dumpable=0;
struct cycle cycle = {0};
+ pfn_memhole = info->max_mapnr;
+
for_each_cycle(0, info->max_mapnr, &cycle)
{
if (!exclude_unnecessary_pages_cyclic(&cycle))
--
1.8.5.3
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2014-08-25 3:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 3:33 [PATCH v4 0/8] add a new interface to show the memory usage of 1st kernel Baoquan He
2014-08-25 3:33 ` Baoquan He [this message]
2014-08-25 3:33 ` [PATCH v4 2/8] functions to get crashkernel memory range Baoquan He
2014-08-25 3:33 ` [PATCH v4 3/8] preparation functions for parsing vmcoreinfo Baoquan He
2014-08-25 5:45 ` [PATCH v5 " Baoquan He
2014-08-25 6:33 ` [PATCH v4 " Baoquan He
2014-08-25 3:33 ` [PATCH v4 4/8] set vmcoreinfo for kcore Baoquan He
2014-08-25 3:33 ` [PATCH v4 5/8] prepare the dump loads for kcore analysis Baoquan He
2014-08-25 3:33 ` [PATCH v4 6/8] introduce a function exclude_zero_pages_cyclic() Baoquan He
2014-08-25 3:33 ` [PATCH v4 7/8] implement a function to print the memory usage Baoquan He
2014-08-25 3:33 ` [PATCH v4 8/8] add a new interface to show the memory usage of 1st kernel Baoquan He
2014-08-25 6:36 ` [PATCH v5 " Baoquan He
2014-08-25 20:04 ` Vivek Goyal
2014-08-26 6:37 ` Baoquan He
2014-08-26 13:10 ` Vivek Goyal
2014-08-27 0:32 ` Atsushi Kumagai
2014-08-29 9:37 ` bhe
2014-08-25 7:03 ` [PATCH v4 " Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408937592-2609-2-git-send-email-bhe@redhat.com \
--to=bhe@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=kumagai-atsushi@mxc.nes.nec.co.jp \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox