Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Baoquan He <bhe@redhat.com>
Cc: kumagai-atsushi@mxc.nes.nec.co.jp, kexec@lists.infradead.org
Subject: Re: [PATCH v5 8/8] add a new interface to show the memory usage of 1st kernel
Date: Mon, 25 Aug 2014 16:04:18 -0400	[thread overview]
Message-ID: <20140825200418.GK14379@redhat.com> (raw)
In-Reply-To: <20140825063622.GB1501@dhcp-16-105.nay.redhat.com>

On Mon, Aug 25, 2014 at 02:36:22PM +0800, Baoquan He wrote:
> Recently people complained that they don't know how to decide how
> much disk size need be reserved for kdump. E.g there are lots of
> machines with different memory size, if the memory usage information
> of current system can be shown, that can help them to make an estimate
> how much storage space need be reserved.
> 
> In this patch, a new interface is added into makedumpfile. By the
> help of this, people can know the page number of memory in different
> use. The implementation is analyzing the "System Ram" and "kernel text"
> program segment of /proc/kcore excluding the crashkernel range, then
> calculating the page number of different kind per vmcoreinfo.
> 
> The print is like below:
> 
> ~$ ./makedumpfile --mem-usage /proc/kcore
> The kernel version is not supported.
> The created dumpfile may be incomplete.

I still think that above messages should go. It does not make
any sense with --mem-usage. No dumpfile is being created here.

> Excluding unnecessary pages        : [100.0 %] |


> 
> Page number of memory in different use
> --------------------------------------------------

I think above header can completely go away.  It kind of looks odd.

> TYPE		PAGES			EXCLUDABLE	DESCRIPTION
> ZERO		29149           	yes		Pages filled with zero
> CACHE		171288          	yes		Cache pages
> CACHE_PRIVATE	12051           	yes		Cache pages + private
> USER		31816           	yes		User process pages
> FREE		3700059         	yes		Free pages
> KERN_DATA	105305          	no		Dumpable kernel data 
> 
> Total pages on system:	4049668         
> 
> Showing page number of memory in different use successfully.

I think we don't need above line. I am not even sure what does it mean.
> 
> makedumpfile Completed.

We don't need above line either.

In output we should just show the actual table. If there is an error, 
we should output error and exit (no table).

Thanks
Vivek

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2014-08-25 20:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-25  3:33 [PATCH v4 0/8] add a new interface to show the memory usage of 1st kernel Baoquan He
2014-08-25  3:33 ` [PATCH v4 1/8] initialize pfn_memhole in get_num_dumpable_cyclic Baoquan He
2014-08-25  3:33 ` [PATCH v4 2/8] functions to get crashkernel memory range Baoquan He
2014-08-25  3:33 ` [PATCH v4 3/8] preparation functions for parsing vmcoreinfo Baoquan He
2014-08-25  5:45   ` [PATCH v5 " Baoquan He
2014-08-25  6:33   ` [PATCH v4 " Baoquan He
2014-08-25  3:33 ` [PATCH v4 4/8] set vmcoreinfo for kcore Baoquan He
2014-08-25  3:33 ` [PATCH v4 5/8] prepare the dump loads for kcore analysis Baoquan He
2014-08-25  3:33 ` [PATCH v4 6/8] introduce a function exclude_zero_pages_cyclic() Baoquan He
2014-08-25  3:33 ` [PATCH v4 7/8] implement a function to print the memory usage Baoquan He
2014-08-25  3:33 ` [PATCH v4 8/8] add a new interface to show the memory usage of 1st kernel Baoquan He
2014-08-25  6:36   ` [PATCH v5 " Baoquan He
2014-08-25 20:04     ` Vivek Goyal [this message]
2014-08-26  6:37       ` Baoquan He
2014-08-26 13:10         ` Vivek Goyal
2014-08-27  0:32         ` Atsushi Kumagai
2014-08-29  9:37           ` bhe
2014-08-25  7:03   ` [PATCH v4 " Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140825200418.GK14379@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=bhe@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=kumagai-atsushi@mxc.nes.nec.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox