Re: [PATCH v5 8/8] add a new interface to show the memory usage of 1st kernel

[Vivek Goyal <vgoyal@redhat.com>]

On Tue, Aug 26, 2014 at 02:37:09PM +0800, Baoquan He wrote:
> On 08/25/14 at 04:04pm, Vivek Goyal wrote:
> > On Mon, Aug 25, 2014 at 02:36:22PM +0800, Baoquan He wrote:
>  
> > > The print is like below:
> > > 
> > > ~$ ./makedumpfile --mem-usage /proc/kcore
> > > The kernel version is not supported.
> > > The created dumpfile may be incomplete.
> > 
> > I still think that above messages should go. It does not make
> > any sense with --mem-usage. No dumpfile is being created here.
> 
> This is printed by function get_kernel_version(), it will be used by
> other makedumpfile main code flows too. This message is used to warn
> users that users' using kernel may not be tested suffciently. I think
> those tests are mainly taken by Atsushi. When he finished sufficient
> tests on a new version of kernel, the LATEST_VERSION will be changed to
> be a larger value. I am fine with this message, since it won't occur on
> our distribution, anyway kernel for distribution are all tested. And if
> LATEST_VERSION is older than our distribution kernel, maintainer may be
> pushed to take tests and update this value. So don't worry about this
> message.
> 
> But I would like to change the message like below to clean up
> misunderstanding if Atsushi doesn't object, this mostly occur when
> people working on latest upstream kernel.
> -------------------------------------------------
> The kernel version is not supported.
> The makedumpfile operation may not be successful.
> --------------------------------------------------

I think you might have to create a gloabl variable somewhere which tells
what mode makedumpfile is operating in. And messages might have to be
changed accordingly.

In this case, I think a single line of following message might be
sufficient.

"Warning: This kernel version is not supported."

[..]
> > > 
> > > makedumpfile Completed.
> > 
> > We don't need above line either.
> 
> This is also a public message printing, means if makedumpfile operation
> is successful or not. Maybe I can add a check like below:

Generally commands return code either "0" or "1" to designate success
or failure. And they don't display to user whether they succeeded or
failed.

> 
> @@ -9546,7 +9553,7 @@ main(int argc, char *argv[])
>         retcd = COMPLETED;
>  out:
>         MSG("\n");
> -       if (retcd == COMPLETED)
> +       if ((retcd == COMPLETED) && (!info->flag_mem_usage))
>                 MSG("makedumpfile Completed.\n");
>         else
>                 MSG("makedumpfile Failed.\n");

I think this will work. This will display failure message but in case
of success only table is displayed.

Thanks
Vivek

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec