From: Prarit Bhargava <prarit@redhat.com>
To: kexec@lists.infradead.org
Cc: Prarit Bhargava <prarit@redhat.com>,
Dave Young <dyoung@redhat.com>, WANG Chao <chaowang@redhat.com>,
Vivek Goyal <vgoyal@redhat.com>
Subject: [PATCH] kexec, remove panic_on_warn kernel parameter from kdump situations
Date: Tue, 30 Dec 2014 09:57:51 -0500 [thread overview]
Message-ID: <1419951471-19765-1-git-send-email-prarit@redhat.com> (raw)
panic_on_warn kernel parameter will cause the kernel to panic when a
WARN() is hit in the kernel. This is not a good situation for the kdump
kernel because then it would be possible for the kdump kernel to panic in
a non-fatal WARN().
This patch removes panic_on_warn as a kernel parameter for the kdump
kernel.
Signed-off-by: Prarit Bhargava <prarit@redhat.com>
Cc: Dave Young <dyoung@redhat.com>
Cc: Vivek Goyal <vgoyal@redhat.com>
Cc: WANG Chao <chaowang@redhat.com>
---
kexec/kexec.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/kexec/kexec.c b/kexec/kexec.c
index b088916..323cafb 100644
--- a/kexec/kexec.c
+++ b/kexec/kexec.c
@@ -1048,8 +1048,10 @@ char *get_command_line(void)
line[strlen(line) - 1] = '\0';
remove_parameter(line, "BOOT_IMAGE");
- if (kexec_flags & KEXEC_ON_CRASH)
+ if (kexec_flags & KEXEC_ON_CRASH) {
remove_parameter(line, "crashkernel");
+ remove_parameter(line, "panic_on_warn");
+ }
return line;
}
--
1.7.9.3
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next reply other threads:[~2014-12-30 14:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-30 14:57 Prarit Bhargava [this message]
2015-01-02 12:54 ` [PATCH] kexec, remove panic_on_warn kernel parameter from kdump situations Vivek Goyal
2015-01-02 13:07 ` Prarit Bhargava
2015-01-02 13:17 ` Vivek Goyal
2015-01-05 1:49 ` Simon Horman
2015-01-06 1:44 ` Dave Young
2015-01-06 1:54 ` Vivek Goyal
2015-01-06 8:05 ` Dave Young
2015-01-06 12:46 ` Baoquan He
2015-01-06 13:07 ` Vivek Goyal
2015-01-06 13:06 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1419951471-19765-1-git-send-email-prarit@redhat.com \
--to=prarit@redhat.com \
--cc=chaowang@redhat.com \
--cc=dyoung@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox