From: Geoff Levand <geoff@infradead.org>
To: Pratyush Anand <panand@redhat.com>
Cc: kexec@lists.infradead.org, kexec@lists.fedoraproject.org
Subject: Re: [PATCH RFC 6/6] arm64: wait for transmit completion before next character transmission
Date: Fri, 17 Apr 2015 10:22:23 -0700 [thread overview]
Message-ID: <1429291343.5479.22.camel@infradead.org> (raw)
In-Reply-To: <6c8a63f701e98cb7cf4ddd96ab5b509115ebdc41.1429201849.git.panand@redhat.com>
On Thu, 2015-04-16 at 22:17 +0530, Pratyush Anand wrote:
> Previous transmission must be completed before next character to be
> transmitted, otherwise TX buffer may saturate and we will not see all
> the characters on screen.
>
> @@ -34,6 +38,8 @@ static const char arm64_opts_usage[] __attribute__ ((unused)) =
> " --lite Fast reboot, no memory integrity checks.\n"
> " --page-offset Kernel page-offset for binary image load.\n"
> " --port=ADDRESS Purgatory output to port ADDRESS.\n"
> +" --port-lsr=ADDRESS Purgatory output port line status ADDRESS.\n"
> +" --port-lsr-val=VALUE Purgatory output port Line status expected SET value when TX empty.\n"
> " --ramdisk=FILE Use FILE as the kernel initial ramdisk.\n"
> " --reuse-cmdline Use command line arg of primary kernel.\n";
We just need to put some chars to the screen, so I want to avoid a lot
of parameters.
Usually the status register is at a fixed offset from the TX port. Is
that not the case for the ARM uarts?
Can't we just poll port-lsr until empty then start writing again? That
will at least eliminate port-lsr-val.
-Geoff
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2015-04-17 17:22 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-16 16:47 [PATCH RFC 0/6] Various fixes for purgatory and ARM64 Pratyush Anand
2015-04-16 16:47 ` [PATCH RFC 1/6] purgatory: Fix memcmp for src address increment Pratyush Anand
2015-04-17 16:55 ` Geoff Levand
2015-04-20 0:25 ` Simon Horman
2015-04-22 11:19 ` Pratyush Anand
2015-04-23 2:23 ` Simon Horman
2015-04-16 16:47 ` [PATCH RFC 2/6] purgatory: No need to sha256 update if ptr->len is zero Pratyush Anand
2015-04-17 16:58 ` Geoff Levand
2015-04-17 23:26 ` Pratyush Anand
2015-04-20 3:01 ` Baoquan He
2015-04-20 3:18 ` Pratyush Anand
2015-04-16 16:47 ` [PATCH RFC 3/6] arm64: allocate memory for other segments after kernel Pratyush Anand
2015-04-17 16:59 ` Geoff Levand
2015-04-20 3:21 ` Baoquan He
2015-04-21 4:19 ` Pratyush Anand
2015-04-21 10:06 ` AKASHI Takahiro
2015-04-22 6:16 ` AKASHI Takahiro
2015-04-16 16:47 ` [PATCH RFC 4/6] arm64: support reuse-cmdline option Pratyush Anand
2015-04-17 17:02 ` Geoff Levand
2015-04-16 16:47 ` [PATCH RFC 5/6] arm64: Add support for binary image Pratyush Anand
2015-04-17 17:07 ` Geoff Levand
2015-04-17 18:00 ` Geoff Levand
2015-04-17 23:27 ` Pratyush Anand
2015-04-20 7:24 ` Baoquan He
2015-04-21 4:42 ` Pratyush Anand
2015-04-22 2:53 ` Baoquan He
2015-04-22 11:19 ` Pratyush Anand
2015-04-16 16:47 ` [PATCH RFC 6/6] arm64: wait for transmit completion before next character transmission Pratyush Anand
2015-04-17 5:36 ` Minfei Huang
2015-04-17 5:37 ` Pratyush Anand
2015-04-20 2:58 ` Baoquan He
2015-04-20 3:34 ` Pratyush Anand
2015-04-17 17:22 ` Geoff Levand [this message]
2015-04-17 23:31 ` Pratyush Anand
2015-04-16 23:54 ` [PATCH RFC 0/6] Various fixes for purgatory and ARM64 Simon Horman
2015-04-17 1:27 ` Dave Young
2015-04-17 2:48 ` Pratyush Anand
2015-04-17 17:27 ` Geoff Levand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429291343.5479.22.camel@infradead.org \
--to=geoff@infradead.org \
--cc=kexec@lists.fedoraproject.org \
--cc=kexec@lists.infradead.org \
--cc=panand@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox