Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Pratyush Anand <panand@redhat.com>
To: Baoquan He <bhe@redhat.com>
Cc: Minfei Huang <mhuang@redhat.com>,
	kexec@lists.infradead.org, kexec@lists.fedoraproject.org
Subject: Re: [PATCH RFC 6/6] arm64: wait for transmit completion before next character transmission
Date: Mon, 20 Apr 2015 09:04:01 +0530	[thread overview]
Message-ID: <553473A9.7060303@redhat.com> (raw)
In-Reply-To: <20150420025828.GD15033@dhcp-16-116.nay.redhat.com>



On Monday 20 April 2015 08:28 AM, Baoquan He wrote:
> On 04/17/15 at 11:07am, Pratyush Anand wrote:
>>
>>
>> On Friday 17 April 2015 11:06 AM, Minfei Huang wrote:
>>>>   	.quad	0
>>>>>   size arm64_dtb_addr
>>>>> +
>>>>> +.globl arm64_sink_lsr_val
>>>>> +arm64_sink_lsr_val:
>>>>> +	.word	0
>>> Since arm64_sink_lsr_val is declared as uint32_t, it is better to keep
>>> the same format here.
>
> ".word" only stores 16bit, doesn't it? Should it be ".int" or ".long"?

I see that .word, .int and .long all reserve 4 bytes for ARM64. But may 
be using .int could be better.

However, as Geoff suggested to remove port-lsr and port-lsr-val, so we 
will not need these.

~Pratyush

> You can check gnu as manual for reference.
>
> Thanks
> Baoquan
>
>>>
>>
>> I thought .word will do the same. But may be I am wrong. What is the
>> good syntax for uint32_t.
>>
>> ~Pratyush
>>
>> _______________________________________________
>> kexec mailing list
>> kexec@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/kexec
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
>

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2015-04-20  3:34 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-16 16:47 [PATCH RFC 0/6] Various fixes for purgatory and ARM64 Pratyush Anand
2015-04-16 16:47 ` [PATCH RFC 1/6] purgatory: Fix memcmp for src address increment Pratyush Anand
2015-04-17 16:55   ` Geoff Levand
2015-04-20  0:25     ` Simon Horman
2015-04-22 11:19       ` Pratyush Anand
2015-04-23  2:23         ` Simon Horman
2015-04-16 16:47 ` [PATCH RFC 2/6] purgatory: No need to sha256 update if ptr->len is zero Pratyush Anand
2015-04-17 16:58   ` Geoff Levand
2015-04-17 23:26     ` Pratyush Anand
2015-04-20  3:01   ` Baoquan He
2015-04-20  3:18     ` Pratyush Anand
2015-04-16 16:47 ` [PATCH RFC 3/6] arm64: allocate memory for other segments after kernel Pratyush Anand
2015-04-17 16:59   ` Geoff Levand
2015-04-20  3:21   ` Baoquan He
2015-04-21  4:19     ` Pratyush Anand
2015-04-21 10:06       ` AKASHI Takahiro
2015-04-22  6:16         ` AKASHI Takahiro
2015-04-16 16:47 ` [PATCH RFC 4/6] arm64: support reuse-cmdline option Pratyush Anand
2015-04-17 17:02   ` Geoff Levand
2015-04-16 16:47 ` [PATCH RFC 5/6] arm64: Add support for binary image Pratyush Anand
2015-04-17 17:07   ` Geoff Levand
2015-04-17 18:00     ` Geoff Levand
2015-04-17 23:27       ` Pratyush Anand
2015-04-20  7:24   ` Baoquan He
2015-04-21  4:42     ` Pratyush Anand
2015-04-22  2:53       ` Baoquan He
2015-04-22 11:19         ` Pratyush Anand
2015-04-16 16:47 ` [PATCH RFC 6/6] arm64: wait for transmit completion before next character transmission Pratyush Anand
2015-04-17  5:36   ` Minfei Huang
2015-04-17  5:37     ` Pratyush Anand
2015-04-20  2:58       ` Baoquan He
2015-04-20  3:34         ` Pratyush Anand [this message]
2015-04-17 17:22   ` Geoff Levand
2015-04-17 23:31     ` Pratyush Anand
2015-04-16 23:54 ` [PATCH RFC 0/6] Various fixes for purgatory and ARM64 Simon Horman
2015-04-17  1:27 ` Dave Young
2015-04-17  2:48   ` Pratyush Anand
2015-04-17 17:27 ` Geoff Levand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=553473A9.7060303@redhat.com \
    --to=panand@redhat.com \
    --cc=bhe@redhat.com \
    --cc=kexec@lists.fedoraproject.org \
    --cc=kexec@lists.infradead.org \
    --cc=mhuang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox