* [PATCH] kexec-tools: ppc/ppc64: cleanup: Remove never reached return
@ 2013-05-26 10:02 Zhang Yanfei
2013-05-26 13:34 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: Zhang Yanfei @ 2013-05-26 10:02 UTC (permalink / raw)
To: Simon Horman; +Cc: kexec@lists.infradead.org
From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
The return will never be reached, so remove it.
Signed-off-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
---
kexec/arch/ppc/kexec-ppc.c | 1 -
kexec/arch/ppc64/kexec-ppc64.c | 1 -
2 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/kexec/arch/ppc/kexec-ppc.c b/kexec/arch/ppc/kexec-ppc.c
index 5a2966e..d046110 100644
--- a/kexec/arch/ppc/kexec-ppc.c
+++ b/kexec/arch/ppc/kexec-ppc.c
@@ -736,7 +736,6 @@ static int get_devtree_details(unsigned long kexec_flags)
!= 1) {
perror(fname);
goto error_openfile;
- return -1;
}
memset(fname, 0, sizeof(fname));
sprintf(fname, "%s%s%s",
diff --git a/kexec/arch/ppc64/kexec-ppc64.c b/kexec/arch/ppc64/kexec-ppc64.c
index 389741a..21bd0a8 100644
--- a/kexec/arch/ppc64/kexec-ppc64.c
+++ b/kexec/arch/ppc64/kexec-ppc64.c
@@ -590,7 +590,6 @@ static int get_devtree_details(unsigned long kexec_flags)
if (fread(&tce_base, sizeof(uint64_t), 1, file) != 1) {
perror(fname);
goto error_openfile;
- return -1;
}
memset(fname, 0, sizeof(fname));
strcpy(fname, device_tree);
--
1.7.1
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kexec-tools: ppc/ppc64: cleanup: Remove never reached return
2013-05-26 10:02 [PATCH] kexec-tools: ppc/ppc64: cleanup: Remove never reached return Zhang Yanfei
@ 2013-05-26 13:34 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2013-05-26 13:34 UTC (permalink / raw)
To: Zhang Yanfei; +Cc: kexec@lists.infradead.org
On Sun, May 26, 2013 at 06:02:37PM +0800, Zhang Yanfei wrote:
> From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
>
> The return will never be reached, so remove it.
Thanks, applied.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-26 13:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-26 10:02 [PATCH] kexec-tools: ppc/ppc64: cleanup: Remove never reached return Zhang Yanfei
2013-05-26 13:34 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox