* [PATCH] ppc64/purgatory: Disabling GCC's stack protection
@ 2014-03-25 9:55 Laurent Dufour
2014-04-08 14:44 ` [RESEND PATCH] " Laurent Dufour
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Dufour @ 2014-03-25 9:55 UTC (permalink / raw)
To: Simon Horman, kexec; +Cc: dvaleev
Some Linux distributions, like Suse, are turning on the GCC's stack
protection mechanism by default (-fstack-protector). When building the
purgatory with this option, this leads to link issues that are revealed at
runtime when the purgatory is loaded because symbols like __stack_chk_fail
are unresolved.
This patch forces this stack protection mechanism to be turned off when
building the purgatory on ppc64 BE and LE.
Signed-off-by: Laurent Dufour <ldufour@linux.vnet.ibm.com>
---
purgatory/arch/ppc64/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/purgatory/arch/ppc64/Makefile b/purgatory/arch/ppc64/Makefile
index 31076e9..712e2b1 100644
--- a/purgatory/arch/ppc64/Makefile
+++ b/purgatory/arch/ppc64/Makefile
@@ -9,7 +9,7 @@ ppc64_PURGATORY_SRCS += purgatory/arch/ppc64/console-ppc64.c
ppc64_PURGATORY_SRCS += purgatory/arch/ppc64/crashdump_backup.c
ppc64_PURGATORY_SRCS += purgatory/arch/ppc64/misc.S
-ppc64_PURGATORY_EXTRA_CFLAGS += -m64 -msoft-float
+ppc64_PURGATORY_EXTRA_CFLAGS += -m64 -msoft-float -fno-stack-protector
ppc64_PURGATORY_EXTRA_ASFLAGS += -m64
ifeq ($(SUBARCH),BE)
ppc64_PURGATORY_EXTRA_LDFLAGS += -melf64ppc
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [RESEND PATCH] ppc64/purgatory: Disabling GCC's stack protection
2014-03-25 9:55 [PATCH] ppc64/purgatory: Disabling GCC's stack protection Laurent Dufour
@ 2014-04-08 14:44 ` Laurent Dufour
2014-04-09 23:07 ` Simon Horman
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Dufour @ 2014-04-08 14:44 UTC (permalink / raw)
To: Simon Horman, kexec; +Cc: dvaleev
Some Linux distributions, like Suse, are turning on the GCC's stack
protection mechanism by default (-fstack-protector). When building the
purgatory with this option, this leads to link issues that are revealed at
runtime when the purgatory is loaded because symbols like __stack_chk_fail
are unresolved.
This patch forces this stack protection mechanism to be turned off when
building the purgatory on ppc64 BE and LE.
Signed-off-by: Laurent Dufour <ldufour@linux.vnet.ibm.com>
---
purgatory/arch/ppc64/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/purgatory/arch/ppc64/Makefile b/purgatory/arch/ppc64/Makefile
index 31076e9..712e2b1 100644
--- a/purgatory/arch/ppc64/Makefile
+++ b/purgatory/arch/ppc64/Makefile
@@ -9,7 +9,7 @@ ppc64_PURGATORY_SRCS += purgatory/arch/ppc64/console-ppc64.c
ppc64_PURGATORY_SRCS += purgatory/arch/ppc64/crashdump_backup.c
ppc64_PURGATORY_SRCS += purgatory/arch/ppc64/misc.S
-ppc64_PURGATORY_EXTRA_CFLAGS += -m64 -msoft-float
+ppc64_PURGATORY_EXTRA_CFLAGS += -m64 -msoft-float -fno-stack-protector
ppc64_PURGATORY_EXTRA_ASFLAGS += -m64
ifeq ($(SUBARCH),BE)
ppc64_PURGATORY_EXTRA_LDFLAGS += -melf64ppc
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RESEND PATCH] ppc64/purgatory: Disabling GCC's stack protection
2014-04-08 14:44 ` [RESEND PATCH] " Laurent Dufour
@ 2014-04-09 23:07 ` Simon Horman
0 siblings, 0 replies; 3+ messages in thread
From: Simon Horman @ 2014-04-09 23:07 UTC (permalink / raw)
To: Laurent Dufour; +Cc: dvaleev, kexec
On Tue, Apr 08, 2014 at 04:44:45PM +0200, Laurent Dufour wrote:
> Some Linux distributions, like Suse, are turning on the GCC's stack
> protection mechanism by default (-fstack-protector). When building the
> purgatory with this option, this leads to link issues that are revealed at
> runtime when the purgatory is loaded because symbols like __stack_chk_fail
> are unresolved.
>
> This patch forces this stack protection mechanism to be turned off when
> building the purgatory on ppc64 BE and LE.
>
> Signed-off-by: Laurent Dufour <ldufour@linux.vnet.ibm.com>
Thanks, applied.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-09 23:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-25 9:55 [PATCH] ppc64/purgatory: Disabling GCC's stack protection Laurent Dufour
2014-04-08 14:44 ` [RESEND PATCH] " Laurent Dufour
2014-04-09 23:07 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox