Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Drop release date from kexec-tools version output
@ 2015-09-02  1:24 Dave Young
  2015-09-02  2:22 ` Simon Horman
  0 siblings, 1 reply; 2+ messages in thread
From: Dave Young @ 2015-09-02  1:24 UTC (permalink / raw)
  To: horms; +Cc: kexec

kexec --version reports like below:
kexec-tools 2.0.7 released 05 February 2015

The date string is generated when one run bootstrap script, thus
it is more like a build date instead of release date.
Even for distribution like Fedora it will make more sense if it can
report something like "kexec-tools 2.0.7-1 released 05 February 2015"

In case building from git tree, the date cause more confusion.
So let's remove it from version string unless there is better idea
to resolve the issue.

Signed-off-by: Dave Young <dyoung@redhat.com>
---
 configure.ac  |    3 ---
 kexec/kexec.c |    2 +-
 2 files changed, 1 insertion(+), 4 deletions(-)

--- kexec-tools.orig/configure.ac
+++ kexec-tools/configure.ac
@@ -10,9 +10,6 @@ AC_CONFIG_HEADERS([include/config.h])
 AC_LANG(C)
 AC_PROG_CC
 
-AC_DEFINE_UNQUOTED(PACKAGE_DATE, "`date '+%d %B %Y'`",
-		[Define to the release date of this package])
-
 
 dnl -- Compilation platform configuration
 dnl -- the host specifices the host machine for the kexec binary, the
--- kexec-tools.orig/kexec/kexec.c
+++ kexec-tools/kexec/kexec.c
@@ -897,7 +897,7 @@ static int my_load_jump_back_helper(unsi
 
 static void version(void)
 {
-	printf(PACKAGE_STRING " released " PACKAGE_DATE "\n");
+	printf(PACKAGE_STRING "\n");
 }
 
 void usage(void)

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Drop release date from kexec-tools version output
  2015-09-02  1:24 [PATCH] Drop release date from kexec-tools version output Dave Young
@ 2015-09-02  2:22 ` Simon Horman
  0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2015-09-02  2:22 UTC (permalink / raw)
  To: Dave Young; +Cc: kexec

On Wed, Sep 02, 2015 at 09:24:12AM +0800, Dave Young wrote:
> kexec --version reports like below:
> kexec-tools 2.0.7 released 05 February 2015
> 
> The date string is generated when one run bootstrap script, thus
> it is more like a build date instead of release date.
> Even for distribution like Fedora it will make more sense if it can
> report something like "kexec-tools 2.0.7-1 released 05 February 2015"
> 
> In case building from git tree, the date cause more confusion.
> So let's remove it from version string unless there is better idea
> to resolve the issue.
> 
> Signed-off-by: Dave Young <dyoung@redhat.com>

Thanks, applied.

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-09-02  2:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-02  1:24 [PATCH] Drop release date from kexec-tools version output Dave Young
2015-09-02  2:22 ` Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox