* [PATCH] purgatory: Change default sha256 optimization to -O2
@ 2016-11-23 17:57 Geoff Levand
2016-11-24 7:53 ` Simon Horman
2016-12-01 19:09 ` [PATCH V2] " Geoff Levand
0 siblings, 2 replies; 8+ messages in thread
From: Geoff Levand @ 2016-11-23 17:57 UTC (permalink / raw)
To: Simon Horman; +Cc: Pratyush Anand, kexec
Change the default purgatory sha256 code optimization from -O0 to -O2, and add a
new arch specific makefile variable $(ARCH)_PURGATORY_SHA256_CFLAGS which can
over ride this default. Set ia64_PURGATORY_SHA256_CFLAGS to -O0 to retain the
previous optimization level for ia64.
The purgatory sha256 code needs the be built with -O0 for the ia64
architecture. Currently this code is built with -O0 for all architectures,
which slows down the calculations for architectures which could otherwise
use -O2.
Signed-off-by: Geoff Levand <geoff@infradead.org>
---
purgatory/Makefile | 4 +---
purgatory/arch/ia64/Makefile | 4 ++++
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/purgatory/Makefile b/purgatory/Makefile
index ca0443c..328904e 100644
--- a/purgatory/Makefile
+++ b/purgatory/Makefile
@@ -38,9 +38,7 @@ clean += $(PURGATORY_OBJS) $(PURGATORY_DEPS) $(PURGATORY)
-include $(PURGATORY_DEPS)
-# sha256.c needs to be compiled without optimization, else
-# purgatory fails to execute on ia64.
-purgatory/sha256.o: CFLAGS += -O0
+purgatory/sha256.o: CFLAGS += -O2 $($(ARCH)_PURGATORY_SHA256_CFLAGS)
purgatory/sha256.o: $(srcdir)/util_lib/sha256.c
mkdir -p $(@D)
diff --git a/purgatory/arch/ia64/Makefile b/purgatory/arch/ia64/Makefile
index 32c3d97..4a2564c 100644
--- a/purgatory/arch/ia64/Makefile
+++ b/purgatory/arch/ia64/Makefile
@@ -8,6 +8,10 @@ ia64_PURGATORY_SRCS += purgatory/arch/ia64/vga.c
ia64_PURGATORY_EXTRA_CFLAGS = -ffixed-r28
+# sha256.c needs to be compiled without optimization, else
+# purgatory fails to execute on ia64.
+ia64_PURGATORY_SHA256_CFLAGS = -O0
+
dist += purgatory/arch/ia64/Makefile $(ia64_PURGATORY_SRCS) \
purgatory/arch/ia64/io.h purgatory/arch/ia64/purgatory-ia64.h
--
2.7.4
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] purgatory: Change default sha256 optimization to -O2
2016-11-23 17:57 [PATCH] purgatory: Change default sha256 optimization to -O2 Geoff Levand
@ 2016-11-24 7:53 ` Simon Horman
2016-11-28 5:44 ` Pratyush Anand
2016-12-01 19:09 ` [PATCH V2] " Geoff Levand
1 sibling, 1 reply; 8+ messages in thread
From: Simon Horman @ 2016-11-24 7:53 UTC (permalink / raw)
To: Geoff Levand; +Cc: Pratyush Anand, kexec
On Wed, Nov 23, 2016 at 09:57:09AM -0800, Geoff Levand wrote:
> Change the default purgatory sha256 code optimization from -O0 to -O2, and add a
> new arch specific makefile variable $(ARCH)_PURGATORY_SHA256_CFLAGS which can
> over ride this default. Set ia64_PURGATORY_SHA256_CFLAGS to -O0 to retain the
> previous optimization level for ia64.
>
> The purgatory sha256 code needs the be built with -O0 for the ia64
> architecture. Currently this code is built with -O0 for all architectures,
> which slows down the calculations for architectures which could otherwise
> use -O2.
Could you give an indication of the performance improvement you expect,
e.g. on arm64?
> Signed-off-by: Geoff Levand <geoff@infradead.org>
> ---
> purgatory/Makefile | 4 +---
> purgatory/arch/ia64/Makefile | 4 ++++
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/purgatory/Makefile b/purgatory/Makefile
> index ca0443c..328904e 100644
> --- a/purgatory/Makefile
> +++ b/purgatory/Makefile
> @@ -38,9 +38,7 @@ clean += $(PURGATORY_OBJS) $(PURGATORY_DEPS) $(PURGATORY)
> -include $(PURGATORY_DEPS)
> -# sha256.c needs to be compiled without optimization, else
> -# purgatory fails to execute on ia64.
> -purgatory/sha256.o: CFLAGS += -O0
> +purgatory/sha256.o: CFLAGS += -O2 $($(ARCH)_PURGATORY_SHA256_CFLAGS)
> purgatory/sha256.o: $(srcdir)/util_lib/sha256.c
> mkdir -p $(@D)
> diff --git a/purgatory/arch/ia64/Makefile b/purgatory/arch/ia64/Makefile
> index 32c3d97..4a2564c 100644
> --- a/purgatory/arch/ia64/Makefile
> +++ b/purgatory/arch/ia64/Makefile
> @@ -8,6 +8,10 @@ ia64_PURGATORY_SRCS += purgatory/arch/ia64/vga.c
> ia64_PURGATORY_EXTRA_CFLAGS = -ffixed-r28
> +# sha256.c needs to be compiled without optimization, else
> +# purgatory fails to execute on ia64.
> +ia64_PURGATORY_SHA256_CFLAGS = -O0
> +
> dist += purgatory/arch/ia64/Makefile $(ia64_PURGATORY_SRCS) \
> purgatory/arch/ia64/io.h purgatory/arch/ia64/purgatory-ia64.h
> --
> 2.7.4
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] purgatory: Change default sha256 optimization to -O2
2016-11-24 7:53 ` Simon Horman
@ 2016-11-28 5:44 ` Pratyush Anand
2016-11-30 11:02 ` Simon Horman
0 siblings, 1 reply; 8+ messages in thread
From: Pratyush Anand @ 2016-11-28 5:44 UTC (permalink / raw)
To: Simon Horman; +Cc: Geoff Levand, Kexec Mailing List
On Thu, Nov 24, 2016 at 1:23 PM, Simon Horman <horms@verge.net.au> wrote:
> On Wed, Nov 23, 2016 at 09:57:09AM -0800, Geoff Levand wrote:
>> Change the default purgatory sha256 code optimization from -O0 to -O2, and add a
>> new arch specific makefile variable $(ARCH)_PURGATORY_SHA256_CFLAGS which can
>> over ride this default. Set ia64_PURGATORY_SHA256_CFLAGS to -O0 to retain the
>> previous optimization level for ia64.
>>
>> The purgatory sha256 code needs the be built with -O0 for the ia64
>> architecture. Currently this code is built with -O0 for all architectures,
>> which slows down the calculations for architectures which could otherwise
>> use -O2.
>
> Could you give an indication of the performance improvement you expect,
> e.g. on arm64?
>
It takes around 20 second to verify SHA in purgatory when vmlinuz
image is around 13MB and initramfs is around 30M with -O2 enables.
Otherwise, it takes more than 2 minutes.
~Pratyush
>> Signed-off-by: Geoff Levand <geoff@infradead.org>
>> ---
>> purgatory/Makefile | 4 +---
>> purgatory/arch/ia64/Makefile | 4 ++++
>> 2 files changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/purgatory/Makefile b/purgatory/Makefile
>> index ca0443c..328904e 100644
>> --- a/purgatory/Makefile
>> +++ b/purgatory/Makefile
>> @@ -38,9 +38,7 @@ clean += $(PURGATORY_OBJS) $(PURGATORY_DEPS) $(PURGATORY)
>> -include $(PURGATORY_DEPS)
>> -# sha256.c needs to be compiled without optimization, else
>> -# purgatory fails to execute on ia64.
>> -purgatory/sha256.o: CFLAGS += -O0
>> +purgatory/sha256.o: CFLAGS += -O2 $($(ARCH)_PURGATORY_SHA256_CFLAGS)
>> purgatory/sha256.o: $(srcdir)/util_lib/sha256.c
>> mkdir -p $(@D)
>> diff --git a/purgatory/arch/ia64/Makefile b/purgatory/arch/ia64/Makefile
>> index 32c3d97..4a2564c 100644
>> --- a/purgatory/arch/ia64/Makefile
>> +++ b/purgatory/arch/ia64/Makefile
>> @@ -8,6 +8,10 @@ ia64_PURGATORY_SRCS += purgatory/arch/ia64/vga.c
>> ia64_PURGATORY_EXTRA_CFLAGS = -ffixed-r28
>> +# sha256.c needs to be compiled without optimization, else
>> +# purgatory fails to execute on ia64.
>> +ia64_PURGATORY_SHA256_CFLAGS = -O0
>> +
>> dist += purgatory/arch/ia64/Makefile $(ia64_PURGATORY_SRCS) \
>> purgatory/arch/ia64/io.h purgatory/arch/ia64/purgatory-ia64.h
>> --
>> 2.7.4
>>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] purgatory: Change default sha256 optimization to -O2
2016-11-28 5:44 ` Pratyush Anand
@ 2016-11-30 11:02 ` Simon Horman
2016-12-01 19:09 ` Geoff Levand
0 siblings, 1 reply; 8+ messages in thread
From: Simon Horman @ 2016-11-30 11:02 UTC (permalink / raw)
To: Pratyush Anand; +Cc: Geoff Levand, Kexec Mailing List
On Mon, Nov 28, 2016 at 11:14:38AM +0530, Pratyush Anand wrote:
> On Thu, Nov 24, 2016 at 1:23 PM, Simon Horman <horms@verge.net.au> wrote:
> > On Wed, Nov 23, 2016 at 09:57:09AM -0800, Geoff Levand wrote:
> >> Change the default purgatory sha256 code optimization from -O0 to -O2, and add a
> >> new arch specific makefile variable $(ARCH)_PURGATORY_SHA256_CFLAGS which can
> >> over ride this default. Set ia64_PURGATORY_SHA256_CFLAGS to -O0 to retain the
> >> previous optimization level for ia64.
> >>
> >> The purgatory sha256 code needs the be built with -O0 for the ia64
> >> architecture. Currently this code is built with -O0 for all architectures,
> >> which slows down the calculations for architectures which could otherwise
> >> use -O2.
> >
> > Could you give an indication of the performance improvement you expect,
> > e.g. on arm64?
> >
>
> It takes around 20 second to verify SHA in purgatory when vmlinuz
> image is around 13MB and initramfs is around 30M with -O2 enables.
> Otherwise, it takes more than 2 minutes.
Thanks.
This patch doesn't seem to apply against the master branch.
I'm wondering if you or Geoff could:
1. Rebase the patch
2. Include some text about the performance improvement.
Something like what is above would be fine from my pov.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] purgatory: Change default sha256 optimization to -O2
2016-11-30 11:02 ` Simon Horman
@ 2016-12-01 19:09 ` Geoff Levand
0 siblings, 0 replies; 8+ messages in thread
From: Geoff Levand @ 2016-12-01 19:09 UTC (permalink / raw)
To: Simon Horman, Pratyush Anand; +Cc: Kexec Mailing List
Hi Simon,
On 11/30/2016 03:02 AM, Simon Horman wrote:
> This patch doesn't seem to apply against the master branch.
> I'm wondering if you or Geoff could:
>
> 1. Rebase the patch
> 2. Include some text about the performance improvement.
> Something like what is above would be fine from my pov.
I have this patch based on your master at
git://git.kernel.org/pub/scm/utils/kernel/kexec/kexec-tools.git.
The problem could be the settings of my new mail client.
I'll add the comment and try a re-post.
-Geoff
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH V2] purgatory: Change default sha256 optimization to -O2
2016-11-23 17:57 [PATCH] purgatory: Change default sha256 optimization to -O2 Geoff Levand
2016-11-24 7:53 ` Simon Horman
@ 2016-12-01 19:09 ` Geoff Levand
2016-12-02 8:21 ` Simon Horman
1 sibling, 1 reply; 8+ messages in thread
From: Geoff Levand @ 2016-12-01 19:09 UTC (permalink / raw)
To: Simon Horman; +Cc: Pratyush Anand, kexec
Change the default purgatory sha256 code optimization from -O0 to -O2, and add a
new arch specific makefile variable $(ARCH)_PURGATORY_SHA256_CFLAGS which can
over ride this default. Set ia64_PURGATORY_SHA256_CFLAGS to -O0 to retain the
previous optimization level for ia64.
The purgatory sha256 code needs the be built with -O0 for the ia64
architecture. Currently this code is built with -O0 for all architectures,
which slows down the calculations for architectures which could otherwise
use -O2.
On arm64, it takes around 20 second to verify SHA in purgatory when
vmlinuz image is around 13MB and initramfs is around 30M with -O2
enabled. Otherwise, it takes more than 2 minutes.
Cc: Pratyush Anand <panand@redhat.com>
Signed-off-by: Geoff Levand <geoff@infradead.org>
---
purgatory/Makefile | 4 +---
purgatory/arch/ia64/Makefile | 4 ++++
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/purgatory/Makefile b/purgatory/Makefile
index ca0443c..328904e 100644
--- a/purgatory/Makefile
+++ b/purgatory/Makefile
@@ -38,9 +38,7 @@ clean += $(PURGATORY_OBJS) $(PURGATORY_DEPS) $(PURGATORY)
-include $(PURGATORY_DEPS)
-# sha256.c needs to be compiled without optimization, else
-# purgatory fails to execute on ia64.
-purgatory/sha256.o: CFLAGS += -O0
+purgatory/sha256.o: CFLAGS += -O2 $($(ARCH)_PURGATORY_SHA256_CFLAGS)
purgatory/sha256.o: $(srcdir)/util_lib/sha256.c
mkdir -p $(@D)
diff --git a/purgatory/arch/ia64/Makefile b/purgatory/arch/ia64/Makefile
index 32c3d97..4a2564c 100644
--- a/purgatory/arch/ia64/Makefile
+++ b/purgatory/arch/ia64/Makefile
@@ -8,6 +8,10 @@ ia64_PURGATORY_SRCS += purgatory/arch/ia64/vga.c
ia64_PURGATORY_EXTRA_CFLAGS = -ffixed-r28
+# sha256.c needs to be compiled without optimization, else
+# purgatory fails to execute on ia64.
+ia64_PURGATORY_SHA256_CFLAGS = -O0
+
dist += purgatory/arch/ia64/Makefile $(ia64_PURGATORY_SRCS) \
purgatory/arch/ia64/io.h purgatory/arch/ia64/purgatory-ia64.h
--
2.9.3
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH V2] purgatory: Change default sha256 optimization to -O2
2016-12-01 19:09 ` [PATCH V2] " Geoff Levand
@ 2016-12-02 8:21 ` Simon Horman
0 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2016-12-02 8:21 UTC (permalink / raw)
To: Geoff Levand; +Cc: Pratyush Anand, kexec
On Thu, Dec 01, 2016 at 11:09:37AM -0800, Geoff Levand wrote:
> Change the default purgatory sha256 code optimization from -O0 to -O2, and add a
> new arch specific makefile variable $(ARCH)_PURGATORY_SHA256_CFLAGS which can
> over ride this default. Set ia64_PURGATORY_SHA256_CFLAGS to -O0 to retain the
> previous optimization level for ia64.
>
> The purgatory sha256 code needs the be built with -O0 for the ia64
> architecture. Currently this code is built with -O0 for all architectures,
> which slows down the calculations for architectures which could otherwise
> use -O2.
>
> On arm64, it takes around 20 second to verify SHA in purgatory when
> vmlinuz image is around 13MB and initramfs is around 30M with -O2
> enabled. Otherwise, it takes more than 2 minutes.
>
> Cc: Pratyush Anand <panand@redhat.com>
> Signed-off-by: Geoff Levand <geoff@infradead.org>
Thanks, applied.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] purgatory: Change default sha256 optimization to -O2
@ 2015-11-06 20:36 Geoff Levand
0 siblings, 0 replies; 8+ messages in thread
From: Geoff Levand @ 2015-11-06 20:36 UTC (permalink / raw)
To: Simon Horman; +Cc: Scott Wood, kexec, Petitboot
Change the default purgatory sha256 code optimization from -O0 to -O2, and add a
new arch specific makefile variable $(ARCH)_PURGATORY_SHA256_CFLAGS which can
over ride this default. Set ia64_PURGATORY_SHA256_CFLAGS to -O0 to retain the
previous optimization level for ia64.
The purgatory sha256 code needs the be built with -O0 for the ia64
architecture. Currently this code is built with -O0 for all architectures,
which slows down the calculations for architectures which could otherwise
use -O2.
Signed-off-by: Geoff Levand <geoff@infradead.org>
---
Tested on arm64. Seems to work OK.
purgatory/Makefile | 4 +---
purgatory/arch/ia64/Makefile | 4 ++++
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/purgatory/Makefile b/purgatory/Makefile
index ca0443c..328904e 100644
--- a/purgatory/Makefile
+++ b/purgatory/Makefile
@@ -38,9 +38,7 @@ clean += $(PURGATORY_OBJS) $(PURGATORY_DEPS) $(PURGATORY)
-include $(PURGATORY_DEPS)
-# sha256.c needs to be compiled without optimization, else
-# purgatory fails to execute on ia64.
-purgatory/sha256.o: CFLAGS += -O0
+purgatory/sha256.o: CFLAGS += -O2 $($(ARCH)_PURGATORY_SHA256_CFLAGS)
purgatory/sha256.o: $(srcdir)/util_lib/sha256.c
mkdir -p $(@D)
diff --git a/purgatory/arch/ia64/Makefile b/purgatory/arch/ia64/Makefile
index 32c3d97..4a2564c 100644
--- a/purgatory/arch/ia64/Makefile
+++ b/purgatory/arch/ia64/Makefile
@@ -8,6 +8,10 @@ ia64_PURGATORY_SRCS += purgatory/arch/ia64/vga.c
ia64_PURGATORY_EXTRA_CFLAGS = -ffixed-r28
+# sha256.c needs to be compiled without optimization, else
+# purgatory fails to execute on ia64.
+ia64_PURGATORY_SHA256_CFLAGS = -O0
+
dist += purgatory/arch/ia64/Makefile $(ia64_PURGATORY_SRCS) \
purgatory/arch/ia64/io.h purgatory/arch/ia64/purgatory-ia64.h
--
2.5.0
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-12-02 8:22 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-23 17:57 [PATCH] purgatory: Change default sha256 optimization to -O2 Geoff Levand
2016-11-24 7:53 ` Simon Horman
2016-11-28 5:44 ` Pratyush Anand
2016-11-30 11:02 ` Simon Horman
2016-12-01 19:09 ` Geoff Levand
2016-12-01 19:09 ` [PATCH V2] " Geoff Levand
2016-12-02 8:21 ` Simon Horman
-- strict thread matches above, loose matches on Subject: below --
2015-11-06 20:36 [PATCH] " Geoff Levand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox