From: Lianbo Jiang <lijiang@redhat.com>
To: kexec@lists.infradead.org
Cc: dyoung@redhat.com, k-hagio@ab.jp.nec.com, anderson@redhat.com,
bhe@redhat.com
Subject: [PATCH 2/2] Remove the memory encryption mask to obtain the true physical address
Date: Tue, 22 Jan 2019 16:03:57 +0800 [thread overview]
Message-ID: <20190122080357.23381-3-lijiang@redhat.com> (raw)
In-Reply-To: <20190122080357.23381-1-lijiang@redhat.com>
For AMD machine with SME feature, if SME is enabled in the first
kernel, the crashed kernel's page table(pgd/pud/pmd/pte) contains
the memory encryption mask, so makedumpfile needs to remove the
memory encryption mask to obtain the true physical address.
Signed-off-by: Lianbo Jiang <lijiang@redhat.com>
---
arch/x86_64.c | 3 +++
makedumpfile.c | 1 +
2 files changed, 4 insertions(+)
diff --git a/arch/x86_64.c b/arch/x86_64.c
index 537fb78..7651d36 100644
--- a/arch/x86_64.c
+++ b/arch/x86_64.c
@@ -346,6 +346,7 @@ __vtop4_x86_64(unsigned long vaddr, unsigned long pagetable)
return NOT_PADDR;
}
pud_paddr = pgd & ENTRY_MASK;
+ pud_paddr = pud_paddr & ~(NUMBER(sme_mask));
}
/*
@@ -371,6 +372,7 @@ __vtop4_x86_64(unsigned long vaddr, unsigned long pagetable)
* Get PMD.
*/
pmd_paddr = pud_pte & ENTRY_MASK;
+ pmd_paddr = pmd_paddr & ~(NUMBER(sme_mask));
pmd_paddr += pmd_index(vaddr) * sizeof(unsigned long);
if (!readmem(PADDR, pmd_paddr, &pmd_pte, sizeof pmd_pte)) {
ERRMSG("Can't get pmd_pte (pmd_paddr:%lx).\n", pmd_paddr);
@@ -391,6 +393,7 @@ __vtop4_x86_64(unsigned long vaddr, unsigned long pagetable)
* Get PTE.
*/
pte_paddr = pmd_pte & ENTRY_MASK;
+ pte_paddr = pte_paddr & ~(NUMBER(sme_mask));
pte_paddr += pte_index(vaddr) * sizeof(unsigned long);
if (!readmem(PADDR, pte_paddr, &pte, sizeof pte)) {
ERRMSG("Can't get pte (pte_paddr:%lx).\n", pte_paddr);
diff --git a/makedumpfile.c b/makedumpfile.c
index a03aaa1..81c7bb4 100644
--- a/makedumpfile.c
+++ b/makedumpfile.c
@@ -977,6 +977,7 @@ next_page:
read_size = MIN(info->page_size - PAGEOFFSET(paddr), size);
pgaddr = PAGEBASE(paddr);
+ pgaddr = pgaddr & ~(NUMBER(sme_mask));
pgbuf = cache_search(pgaddr, read_size);
if (!pgbuf) {
++cache_miss;
--
2.17.1
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2019-01-22 8:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 8:03 [PATCH 0/2] makedumpfile needs to remove the memory encryption Lianbo Jiang
2019-01-22 8:03 ` [PATCH 1/2] Makedumpfile: add a new variable 'sme_mask' to number_table Lianbo Jiang
2019-01-23 21:51 ` Kazuhito Hagio
2019-01-24 9:23 ` lijiang
2019-01-22 8:03 ` Lianbo Jiang [this message]
2019-01-23 22:16 ` [PATCH 2/2] Remove the memory encryption mask to obtain the true physical address Kazuhito Hagio
2019-01-24 19:33 ` Kazuhito Hagio
2019-01-25 3:17 ` lijiang
2019-01-25 3:06 ` lijiang
2019-01-25 3:55 ` dyoung
2019-01-25 14:32 ` Lendacky, Thomas
2019-01-28 1:55 ` lijiang
2019-01-28 3:15 ` lijiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122080357.23381-3-lijiang@redhat.com \
--to=lijiang@redhat.com \
--cc=anderson@redhat.com \
--cc=bhe@redhat.com \
--cc=dyoung@redhat.com \
--cc=k-hagio@ab.jp.nec.com \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox