From: lijiang <lijiang@redhat.com>
To: Kazuhito Hagio <k-hagio@ab.jp.nec.com>
Cc: "anderson@redhat.com" <anderson@redhat.com>,
"dyoung@redhat.com" <dyoung@redhat.com>,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
"bhe@redhat.com" <bhe@redhat.com>
Subject: Re: [PATCH 1/2] Makedumpfile: add a new variable 'sme_mask' to number_table
Date: Thu, 24 Jan 2019 17:23:48 +0800 [thread overview]
Message-ID: <c41a8c7d-eb48-4f6e-208e-a3df8b40cde9@redhat.com> (raw)
In-Reply-To: <4AE2DC15AC0B8543882A74EA0D43DBEC03566D77@BPXM09GP.gisp.nec.co.jp>
在 2019年01月24日 05:51, Kazuhito Hagio 写道:
> Hi Lianbo,
>
> On 1/22/2019 3:03 AM, Lianbo Jiang wrote:
>> It will be used to store the sme mask for crashed kernel, the
>> sme_mask denotes whether the old memory is encrypted or not.
>>
>> Signed-off-by: Lianbo Jiang <lijiang@redhat.com>
>> ---
>> makedumpfile.c | 3 +++
>> makedumpfile.h | 1 +
>> 2 files changed, 4 insertions(+)
>>
>> diff --git a/makedumpfile.c b/makedumpfile.c
>> index 8923538..a03aaa1 100644
>> --- a/makedumpfile.c
>> +++ b/makedumpfile.c
>> @@ -1743,6 +1743,7 @@ get_structure_info(void)
>> ENUM_NUMBER_INIT(NR_FREE_PAGES, "NR_FREE_PAGES");
>> ENUM_NUMBER_INIT(N_ONLINE, "N_ONLINE");
>> ENUM_NUMBER_INIT(pgtable_l5_enabled, "pgtable_l5_enabled");
>> + ENUM_NUMBER_INIT(sme_mask, "sme_mask");
>
> This is useless because the sme_mask is not enum number.
> Please remove it.
> Ok. Thanks for your comment.
> And, dividing this patchset into the two patches doesn't make sense
> to me in this case. Could you merge them into a patch?
>
Sure, they will be merged into a patch in next post.
Regards,
Lianbo
> Thanks,
> Kazu
>
>>
>> ENUM_NUMBER_INIT(PG_lru, "PG_lru");
>> ENUM_NUMBER_INIT(PG_private, "PG_private");
>> @@ -2276,6 +2277,7 @@ write_vmcoreinfo_data(void)
>> WRITE_NUMBER("NR_FREE_PAGES", NR_FREE_PAGES);
>> WRITE_NUMBER("N_ONLINE", N_ONLINE);
>> WRITE_NUMBER("pgtable_l5_enabled", pgtable_l5_enabled);
>> + WRITE_NUMBER("sme_mask", sme_mask);
>>
>> WRITE_NUMBER("PG_lru", PG_lru);
>> WRITE_NUMBER("PG_private", PG_private);
>> @@ -2672,6 +2674,7 @@ read_vmcoreinfo(void)
>> READ_NUMBER("NR_FREE_PAGES", NR_FREE_PAGES);
>> READ_NUMBER("N_ONLINE", N_ONLINE);
>> READ_NUMBER("pgtable_l5_enabled", pgtable_l5_enabled);
>> + READ_NUMBER("sme_mask", sme_mask);
>>
>> READ_NUMBER("PG_lru", PG_lru);
>> READ_NUMBER("PG_private", PG_private);
>> diff --git a/makedumpfile.h b/makedumpfile.h
>> index 73813ed..e97b2e7 100644
>> --- a/makedumpfile.h
>> +++ b/makedumpfile.h
>> @@ -1912,6 +1912,7 @@ struct number_table {
>> long NR_FREE_PAGES;
>> long N_ONLINE;
>> long pgtable_l5_enabled;
>> + long sme_mask;
>>
>> /*
>> * Page flags
>> --
>> 2.17.1
>>
>
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2019-01-24 9:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 8:03 [PATCH 0/2] makedumpfile needs to remove the memory encryption Lianbo Jiang
2019-01-22 8:03 ` [PATCH 1/2] Makedumpfile: add a new variable 'sme_mask' to number_table Lianbo Jiang
2019-01-23 21:51 ` Kazuhito Hagio
2019-01-24 9:23 ` lijiang [this message]
2019-01-22 8:03 ` [PATCH 2/2] Remove the memory encryption mask to obtain the true physical address Lianbo Jiang
2019-01-23 22:16 ` Kazuhito Hagio
2019-01-24 19:33 ` Kazuhito Hagio
2019-01-25 3:17 ` lijiang
2019-01-25 3:06 ` lijiang
2019-01-25 3:55 ` dyoung
2019-01-25 14:32 ` Lendacky, Thomas
2019-01-28 1:55 ` lijiang
2019-01-28 3:15 ` lijiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c41a8c7d-eb48-4f6e-208e-a3df8b40cde9@redhat.com \
--to=lijiang@redhat.com \
--cc=anderson@redhat.com \
--cc=bhe@redhat.com \
--cc=dyoung@redhat.com \
--cc=k-hagio@ab.jp.nec.com \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox