[PATCH 1/1] kdump: append uts_namespace.name offset to VMCOREINFO

[PATCH 1/1] kdump: append uts_namespace.name offset to VMCOREINFO

[Alexander Egorenkov]

The offset of the field 'init_uts_ns.name' has changed
since commit 9a56493f6942c0e2df1579986128721da96e00d8.
Make the offset of the field 'uts_namespace.name' available
in VMCOREINFO because tools like 'crash-utility' and
'makedumpfile' must be able to read it from crash dumps.

Signed-off-by: Alexander Egorenkov <egorenar@linux.ibm.com>
---
 kernel/crash_core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/crash_core.c b/kernel/crash_core.c
index 106e4500fd53..173fdc261882 100644
--- a/kernel/crash_core.c
+++ b/kernel/crash_core.c
@@ -447,6 +447,7 @@ static int __init crash_save_vmcoreinfo_init(void)
 	VMCOREINFO_PAGESIZE(PAGE_SIZE);
 
 	VMCOREINFO_SYMBOL(init_uts_ns);
+	VMCOREINFO_OFFSET(uts_namespace, name);
 	VMCOREINFO_SYMBOL(node_online_map);
 #ifdef CONFIG_MMU
 	VMCOREINFO_SYMBOL_ARRAY(swapper_pg_dir);
-- 
2.26.2


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

RE: [PATCH 1/1] kdump: append uts_namespace.name offset to VMCOREINFO

[HAGIO KAZUHITO(萩尾 一仁)]

Hi Dave,

sorry to bother you.  We need this kernel patch to fix a makedumpfile issue
with the current linux-next.  Should we send this to the addresses below, right?
I'm not sure whether they are enough.

Alex,

Thanks for the patch.  Since this patch is for kernel, it needs to be sent
to kernel maintainers and mailing lists, and I think you can get their
addresses with scripts/get_maintainer.pl in the kernel tree.

$ scripts/get_maintainer.pl /tmp/a.patch 
Dave Young <dyoung@redhat.com> (maintainer:KDUMP)
Baoquan He <bhe@redhat.com> (maintainer:KDUMP)
Vivek Goyal <vgoyal@redhat.com> (reviewer:KDUMP)
kexec@lists.infradead.org (open list:KDUMP)
linux-kernel@vger.kernel.org (open list)

Thanks,
Kazu

-----Original Message-----
> The offset of the field 'init_uts_ns.name' has changed
> since commit 9a56493f6942c0e2df1579986128721da96e00d8.
> Make the offset of the field 'uts_namespace.name' available
> in VMCOREINFO because tools like 'crash-utility' and
> 'makedumpfile' must be able to read it from crash dumps.
> 
> Signed-off-by: Alexander Egorenkov <egorenar@linux.ibm.com>
> ---
>  kernel/crash_core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/crash_core.c b/kernel/crash_core.c
> index 106e4500fd53..173fdc261882 100644
> --- a/kernel/crash_core.c
> +++ b/kernel/crash_core.c
> @@ -447,6 +447,7 @@ static int __init crash_save_vmcoreinfo_init(void)
>  	VMCOREINFO_PAGESIZE(PAGE_SIZE);
> 
>  	VMCOREINFO_SYMBOL(init_uts_ns);
> +	VMCOREINFO_OFFSET(uts_namespace, name);
>  	VMCOREINFO_SYMBOL(node_online_map);
>  #ifdef CONFIG_MMU
>  	VMCOREINFO_SYMBOL_ARRAY(swapper_pg_dir);
> --
> 2.26.2
> 
> 
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH 1/1] kdump: append uts_namespace.name offset to VMCOREINFO

[dyoung]

Hi Kazu,
On 09/23/20 at 04:37am, HAGIO KAZUHITO(萩尾 一仁) wrote:
> Hi Dave,
> 
> sorry to bother you.  We need this kernel patch to fix a makedumpfile issue
> with the current linux-next.  Should we send this to the addresses below, right?
> I'm not sure whether they are enough.

It is good, but I suggest also cc Eric:
"Eric W. Biederman" <ebiederm@xmission.com>

BTW, the -next commit log should mention which branch the commit stays, and it
would be better to add the original discussion link eg. the patch link on
lore.kernel.org
 
> 
> Alex,
> 
> Thanks for the patch.  Since this patch is for kernel, it needs to be sent
> to kernel maintainers and mailing lists, and I think you can get their
> addresses with scripts/get_maintainer.pl in the kernel tree.
> 
> $ scripts/get_maintainer.pl /tmp/a.patch 
> Dave Young <dyoung@redhat.com> (maintainer:KDUMP)
> Baoquan He <bhe@redhat.com> (maintainer:KDUMP)
> Vivek Goyal <vgoyal@redhat.com> (reviewer:KDUMP)
> kexec@lists.infradead.org (open list:KDUMP)
> linux-kernel@vger.kernel.org (open list)
> 
> Thanks,
> Kazu
> 
> -----Original Message-----
> > The offset of the field 'init_uts_ns.name' has changed
> > since commit 9a56493f6942c0e2df1579986128721da96e00d8.
> > Make the offset of the field 'uts_namespace.name' available
> > in VMCOREINFO because tools like 'crash-utility' and
> > 'makedumpfile' must be able to read it from crash dumps.
> > 
> > Signed-off-by: Alexander Egorenkov <egorenar@linux.ibm.com>
> > ---
> >  kernel/crash_core.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/kernel/crash_core.c b/kernel/crash_core.c
> > index 106e4500fd53..173fdc261882 100644
> > --- a/kernel/crash_core.c
> > +++ b/kernel/crash_core.c
> > @@ -447,6 +447,7 @@ static int __init crash_save_vmcoreinfo_init(void)
> >  	VMCOREINFO_PAGESIZE(PAGE_SIZE);
> > 
> >  	VMCOREINFO_SYMBOL(init_uts_ns);
> > +	VMCOREINFO_OFFSET(uts_namespace, name);
> >  	VMCOREINFO_SYMBOL(node_online_map);
> >  #ifdef CONFIG_MMU
> >  	VMCOREINFO_SYMBOL_ARRAY(swapper_pg_dir);
> > --
> > 2.26.2
> > 
> > 
> > _______________________________________________
> > kexec mailing list
> > kexec@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/kexec
> 
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
> 

Thanks
Dave


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH 1/1] kdump: append uts_namespace.name offset to VMCOREINFO

[dyoung]

On 09/23/20 at 02:00pm, Dave Young wrote:
> Hi Kazu,
> On 09/23/20 at 04:37am, HAGIO KAZUHITO(萩尾 一仁) wrote:
> > Hi Dave,
> > 
> > sorry to bother you.  We need this kernel patch to fix a makedumpfile issue
> > with the current linux-next.  Should we send this to the addresses below, right?
> > I'm not sure whether they are enough.
> 
> It is good, but I suggest also cc Eric:
> "Eric W. Biederman" <ebiederm@xmission.com>

And also Andrew Morton <akpm@linux-foundation.org> since usually Andrew
takes them.

Thanks
Dave


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

RE: [PATCH 1/1] kdump: append uts_namespace.name offset to VMCOREINFO

[HAGIO KAZUHITO(萩尾 一仁)]

-----Original Message-----
> On 09/23/20 at 02:00pm, Dave Young wrote:
> > Hi Kazu,
> > On 09/23/20 at 04:37am, HAGIO KAZUHITO(萩尾 一仁) wrote:
> > > Hi Dave,
> > >
> > > sorry to bother you.  We need this kernel patch to fix a makedumpfile issue
> > > with the current linux-next.  Should we send this to the addresses below, right?
> > > I'm not sure whether they are enough.
> >
> > It is good, but I suggest also cc Eric:
> > "Eric W. Biederman" <ebiederm@xmission.com>
> 
> And also Andrew Morton <akpm@linux-foundation.org> since usually Andrew
> takes them.

Dave, thank you for the comments.

Alex, could you resend it according to Dave's comments?

> BTW, the -next commit log should mention which branch the commit stays, and it
> would be better to add the original discussion link eg. the patch link on
> lore.kernel.org

it seems the branch in which the commit that changed struct uts_namespace
stays is 'pidfd-fixes/fixes'.

commit 67228dffbdaf088d93c75645b8953d15479ab9ba
Merge: ab8cd6331daf bda4c60d02e9
Author: Stephen Rothwell <sfr@canb.auug.org.au>
Date:   Thu Aug 20 08:56:26 2020 +1000

    Merge remote-tracking branch 'pidfd-fixes/fixes' into master

It might be better to cc Christian Brauner <christian.brauner@ubuntu.com>
as well, the branch's maintainer just in case.

Thanks,
Kazu
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec