* kexec,x86: Use macro CRASH_MAX_MEMMAP_NR for clarification
@ 2013-02-26 10:12 Zhang Yanfei
2013-03-05 1:43 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: Zhang Yanfei @ 2013-02-26 10:12 UTC (permalink / raw)
To: Simon Horman; +Cc: HATAYAMA Daisuke, kexec@lists.infradead.org
For the allocation, using CRASH_MAX_MEMMAP_NR instead of KEXEC_MAX_SEGMENTS + 1
seems more understandable.
Signed-off-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
---
kexec/arch/i386/crashdump-x86.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kexec/arch/i386/crashdump-x86.c b/kexec/arch/i386/crashdump-x86.c
index 245402c..e4b8be3 100644
--- a/kexec/arch/i386/crashdump-x86.c
+++ b/kexec/arch/i386/crashdump-x86.c
@@ -975,7 +975,7 @@ int load_crashdump_segments(struct kexec_info *info, char* mod_cmdline,
return -1;
/* Memory regions which panic kernel can safely use to boot into */
- sz = (sizeof(struct memory_range) * (KEXEC_MAX_SEGMENTS + 1));
+ sz = (sizeof(struct memory_range) * CRASH_MAX_MEMMAP_NR);
memmap_p = xmalloc(sz);
memset(memmap_p, 0, sz);
add_memmap(memmap_p, info->backup_src_start, info->backup_src_size);
--
1.7.1
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: kexec,x86: Use macro CRASH_MAX_MEMMAP_NR for clarification
2013-02-26 10:12 kexec,x86: Use macro CRASH_MAX_MEMMAP_NR for clarification Zhang Yanfei
@ 2013-03-05 1:43 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2013-03-05 1:43 UTC (permalink / raw)
To: Zhang Yanfei; +Cc: HATAYAMA Daisuke, kexec@lists.infradead.org
On Tue, Feb 26, 2013 at 06:12:54PM +0800, Zhang Yanfei wrote:
> For the allocation, using CRASH_MAX_MEMMAP_NR instead of KEXEC_MAX_SEGMENTS + 1
> seems more understandable.
Thanks, applied.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-05 1:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-26 10:12 kexec,x86: Use macro CRASH_MAX_MEMMAP_NR for clarification Zhang Yanfei
2013-03-05 1:43 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox