* failed to compile kexec from git
@ 2013-03-13 2:52 CAI Qian
2013-03-13 3:08 ` CAI Qian
2013-03-13 3:19 ` Zhang Yanfei
0 siblings, 2 replies; 7+ messages in thread
From: CAI Qian @ 2013-03-13 2:52 UTC (permalink / raw)
To: kexec
Looks like this is broken recently. I cloned the tree
at the top commit been,
e73d481c4add17ee953c80bb4be72372d90d93d3
ppc/uImage: Add support for RAM Disks
Then, error out.
kexec/arch/i386/x86-linux-setup.c: In function ‘setup_linux_system_parameters’:
kexec/arch/i386/x86-linux-setup.c:511:9: error: ‘kexec_flags’ undeclared (first use in this function)
kexec/arch/i386/x86-linux-setup.c:511:9: note: each undeclared identifier is reported only once for each function it appears in
make: *** [kexec/arch/i386/x86-linux-setup.o] Error 1
CAI Qian
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: failed to compile kexec from git
2013-03-13 2:52 failed to compile kexec from git CAI Qian
@ 2013-03-13 3:08 ` CAI Qian
2013-03-13 9:52 ` Simon Horman
2013-03-13 3:19 ` Zhang Yanfei
1 sibling, 1 reply; 7+ messages in thread
From: CAI Qian @ 2013-03-13 3:08 UTC (permalink / raw)
To: kexec; +Cc: Simon Horman, Cliff Wickman
If I revert this commit,
6df15d1cca55b2cd59c79aed69f004e1b2a6ba36
kexec x86: drop truncation warning for crash kernel
Everything is fine again.
CAI Qian
----- Original Message -----
> From: "CAI Qian" <caiqian@redhat.com>
> To: "kexec" <kexec@lists.infradead.org>
> Sent: Wednesday, March 13, 2013 10:52:52 AM
> Subject: failed to compile kexec from git
>
> Looks like this is broken recently. I cloned the tree
> at the top commit been,
>
> e73d481c4add17ee953c80bb4be72372d90d93d3
> ppc/uImage: Add support for RAM Disks
>
> Then, error out.
>
> kexec/arch/i386/x86-linux-setup.c: In function
> ‘setup_linux_system_parameters’:
> kexec/arch/i386/x86-linux-setup.c:511:9: error: ‘kexec_flags’
> undeclared (first use in this function)
> kexec/arch/i386/x86-linux-setup.c:511:9: note: each undeclared
> identifier is reported only once for each function it appears in
> make: *** [kexec/arch/i386/x86-linux-setup.o] Error 1
>
> CAI Qian
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: failed to compile kexec from git
2013-03-13 3:08 ` CAI Qian
@ 2013-03-13 9:52 ` Simon Horman
2013-03-13 9:57 ` Zhang Yanfei
0 siblings, 1 reply; 7+ messages in thread
From: Simon Horman @ 2013-03-13 9:52 UTC (permalink / raw)
To: CAI Qian; +Cc: kexec, Cliff Wickman
On Tue, Mar 12, 2013 at 11:08:17PM -0400, CAI Qian wrote:
> If I revert this commit,
> 6df15d1cca55b2cd59c79aed69f004e1b2a6ba36
> kexec x86: drop truncation warning for crash kernel
>
> Everything is fine again.
Thanks. I have applied the following patch which I believe resolves
the problem. Cliff, could you test this?
commit 51438a32f6a0f09a358742f06196d14e4ad0ccab
Author: Simon Horman <horms@verge.net.au>
Date: Wed Mar 13 10:48:48 2013 +0100
Correct build failure in init_linux_parameters()
This fixes a build failure introduced by
"kexec x86: drop truncation warning for crash kernel".
Reported-by: CAI Qian <caiqian@redhat.com>
Cc: Cliff Wickman <cpw@sgi.com>
Signed-off-by: Simon Horman <horms@verge.net.au>
diff --git a/kexec/arch/i386/x86-linux-setup.c b/kexec/arch/i386/x86-linux-setup.c
index b903d43..454fad6 100644
--- a/kexec/arch/i386/x86-linux-setup.c
+++ b/kexec/arch/i386/x86-linux-setup.c
@@ -508,7 +508,7 @@ void setup_linux_system_parameters(struct kexec_info *info,
range = info->memory_range;
ranges = info->memory_ranges;
if (ranges > E820MAX) {
- if (!(kexec_flags & KEXEC_ON_CRASH))
+ if (!(info->kexec_flags & KEXEC_ON_CRASH))
/*
* this e820 not used for capture kernel, see
* do_bzImage_load()
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: failed to compile kexec from git
2013-03-13 9:52 ` Simon Horman
@ 2013-03-13 9:57 ` Zhang Yanfei
2013-03-13 15:16 ` Simon Horman
0 siblings, 1 reply; 7+ messages in thread
From: Zhang Yanfei @ 2013-03-13 9:57 UTC (permalink / raw)
To: Simon Horman; +Cc: kexec, CAI Qian, Cliff Wickman
于 2013年03月13日 17:52, Simon Horman 写道:
> On Tue, Mar 12, 2013 at 11:08:17PM -0400, CAI Qian wrote:
>> If I revert this commit,
>> 6df15d1cca55b2cd59c79aed69f004e1b2a6ba36
>> kexec x86: drop truncation warning for crash kernel
>>
>> Everything is fine again.
>
> Thanks. I have applied the following patch which I believe resolves
> the problem. Cliff, could you test this?
oops...I've sent the same patch before and WANG chao <chaowang@redhat.com>
tested it and it is ok now.
Thanks
Zhang
>
> commit 51438a32f6a0f09a358742f06196d14e4ad0ccab
> Author: Simon Horman <horms@verge.net.au>
> Date: Wed Mar 13 10:48:48 2013 +0100
>
> Correct build failure in init_linux_parameters()
>
> This fixes a build failure introduced by
> "kexec x86: drop truncation warning for crash kernel".
>
> Reported-by: CAI Qian <caiqian@redhat.com>
> Cc: Cliff Wickman <cpw@sgi.com>
> Signed-off-by: Simon Horman <horms@verge.net.au>
>
> diff --git a/kexec/arch/i386/x86-linux-setup.c b/kexec/arch/i386/x86-linux-setup.c
> index b903d43..454fad6 100644
> --- a/kexec/arch/i386/x86-linux-setup.c
> +++ b/kexec/arch/i386/x86-linux-setup.c
> @@ -508,7 +508,7 @@ void setup_linux_system_parameters(struct kexec_info *info,
> range = info->memory_range;
> ranges = info->memory_ranges;
> if (ranges > E820MAX) {
> - if (!(kexec_flags & KEXEC_ON_CRASH))
> + if (!(info->kexec_flags & KEXEC_ON_CRASH))
> /*
> * this e820 not used for capture kernel, see
> * do_bzImage_load()
>
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: failed to compile kexec from git
2013-03-13 9:57 ` Zhang Yanfei
@ 2013-03-13 15:16 ` Simon Horman
0 siblings, 0 replies; 7+ messages in thread
From: Simon Horman @ 2013-03-13 15:16 UTC (permalink / raw)
To: Zhang Yanfei; +Cc: kexec, CAI Qian, Cliff Wickman
On Wed, Mar 13, 2013 at 05:57:58PM +0800, Zhang Yanfei wrote:
> 于 2013年03月13日 17:52, Simon Horman 写道:
> > On Tue, Mar 12, 2013 at 11:08:17PM -0400, CAI Qian wrote:
> >> If I revert this commit,
> >> 6df15d1cca55b2cd59c79aed69f004e1b2a6ba36
> >> kexec x86: drop truncation warning for crash kernel
> >>
> >> Everything is fine again.
> >
> > Thanks. I have applied the following patch which I believe resolves
> > the problem. Cliff, could you test this?
>
> oops...I've sent the same patch before and WANG chao <chaowang@redhat.com>
> tested it and it is ok now.
Sorry for missing that. Thanks for the confirmation.
>
> Thanks
> Zhang
>
> >
> > commit 51438a32f6a0f09a358742f06196d14e4ad0ccab
> > Author: Simon Horman <horms@verge.net.au>
> > Date: Wed Mar 13 10:48:48 2013 +0100
> >
> > Correct build failure in init_linux_parameters()
> >
> > This fixes a build failure introduced by
> > "kexec x86: drop truncation warning for crash kernel".
> >
> > Reported-by: CAI Qian <caiqian@redhat.com>
> > Cc: Cliff Wickman <cpw@sgi.com>
> > Signed-off-by: Simon Horman <horms@verge.net.au>
> >
> > diff --git a/kexec/arch/i386/x86-linux-setup.c b/kexec/arch/i386/x86-linux-setup.c
> > index b903d43..454fad6 100644
> > --- a/kexec/arch/i386/x86-linux-setup.c
> > +++ b/kexec/arch/i386/x86-linux-setup.c
> > @@ -508,7 +508,7 @@ void setup_linux_system_parameters(struct kexec_info *info,
> > range = info->memory_range;
> > ranges = info->memory_ranges;
> > if (ranges > E820MAX) {
> > - if (!(kexec_flags & KEXEC_ON_CRASH))
> > + if (!(info->kexec_flags & KEXEC_ON_CRASH))
> > /*
> > * this e820 not used for capture kernel, see
> > * do_bzImage_load()
> >
> >
> > _______________________________________________
> > kexec mailing list
> > kexec@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/kexec
> >
>
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: failed to compile kexec from git
2013-03-13 2:52 failed to compile kexec from git CAI Qian
2013-03-13 3:08 ` CAI Qian
@ 2013-03-13 3:19 ` Zhang Yanfei
2013-03-13 4:23 ` WANG Chao
1 sibling, 1 reply; 7+ messages in thread
From: Zhang Yanfei @ 2013-03-13 3:19 UTC (permalink / raw)
To: CAI Qian; +Cc: kexec
于 2013年03月13日 10:52, CAI Qian 写道:
> Looks like this is broken recently. I cloned the tree
> at the top commit been,
>
> e73d481c4add17ee953c80bb4be72372d90d93d3
> ppc/uImage: Add support for RAM Disks
>
> Then, error out.
>
> kexec/arch/i386/x86-linux-setup.c: In function ‘setup_linux_system_parameters’:
> kexec/arch/i386/x86-linux-setup.c:511:9: error: ‘kexec_flags’ undeclared (first use in this function)
> kexec/arch/i386/x86-linux-setup.c:511:9: note: each undeclared identifier is reported only once for each function it appears in
> make: *** [kexec/arch/i386/x86-linux-setup.o] Error 1
>
> CAI Qian
>
Hello CAI,
The below patch should fix the bug.
---
From 3511ddae28f50ec13f73c0d124c587ae5fe78048 Mon Sep 17 00:00:00 2001
From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
Date: Wed, 13 Mar 2013 11:10:36 +0800
Subject: [PATCH] kexec: i386: fix a bug due to parameter change
The kexec-tools fails to be compiled and here is the error message:
kexec/arch/i386/x86-linux-setup.c: In function ‘setup_linux_system_parameters’:
kexec/arch/i386/x86-linux-setup.c:511:9: error: ‘kexec_flags’ undeclared (first use in this function)
kexec/arch/i386/x86-linux-setup.c:511:9: note: each undeclared identifier is reported only once for each function it appears in
make: *** [kexec/arch/i386/x86-linux-setup.o] Error 1
This is due to the parameter change of function setup_linux_system_parameters,
and the bug was imported by commit 6df15d1cca55b2cd59c79aed69f004e1b2a6ba36
kexec x86: drop truncation warning for crash kernel
The patch fix the bug.
Reported-by: "CAI Qian" <caiqian@redhat.com>
Signed-off-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
---
kexec/arch/i386/x86-linux-setup.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kexec/arch/i386/x86-linux-setup.c b/kexec/arch/i386/x86-linux-setup.c
index b903d43..454fad6 100644
--- a/kexec/arch/i386/x86-linux-setup.c
+++ b/kexec/arch/i386/x86-linux-setup.c
@@ -508,7 +508,7 @@ void setup_linux_system_parameters(struct kexec_info *info,
range = info->memory_range;
ranges = info->memory_ranges;
if (ranges > E820MAX) {
- if (!(kexec_flags & KEXEC_ON_CRASH))
+ if (!(info->kexec_flags & KEXEC_ON_CRASH))
/*
* this e820 not used for capture kernel, see
* do_bzImage_load()
--
1.7.1
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: failed to compile kexec from git
2013-03-13 3:19 ` Zhang Yanfei
@ 2013-03-13 4:23 ` WANG Chao
0 siblings, 0 replies; 7+ messages in thread
From: WANG Chao @ 2013-03-13 4:23 UTC (permalink / raw)
To: Zhang Yanfei; +Cc: kexec, CAI Qian
On 03/13/2013 11:19 AM, Zhang Yanfei wrote:
> 于 2013年03月13日 10:52, CAI Qian 写道:
>> Looks like this is broken recently. I cloned the tree
>> at the top commit been,
>>
>> e73d481c4add17ee953c80bb4be72372d90d93d3
>> ppc/uImage: Add support for RAM Disks
>>
>> Then, error out.
>>
>> kexec/arch/i386/x86-linux-setup.c: In function ‘setup_linux_system_parameters’:
>> kexec/arch/i386/x86-linux-setup.c:511:9: error: ‘kexec_flags’ undeclared (first use in this function)
>> kexec/arch/i386/x86-linux-setup.c:511:9: note: each undeclared identifier is reported only once for each function it appears in
>> make: *** [kexec/arch/i386/x86-linux-setup.o] Error 1
>>
>> CAI Qian
>>
>
> Hello CAI,
>
> The below patch should fix the bug.
>
> ---
> From 3511ddae28f50ec13f73c0d124c587ae5fe78048 Mon Sep 17 00:00:00 2001
> From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
> Date: Wed, 13 Mar 2013 11:10:36 +0800
> Subject: [PATCH] kexec: i386: fix a bug due to parameter change
>
> The kexec-tools fails to be compiled and here is the error message:
>
> kexec/arch/i386/x86-linux-setup.c: In function ‘setup_linux_system_parameters’:
> kexec/arch/i386/x86-linux-setup.c:511:9: error: ‘kexec_flags’ undeclared (first use in this function)
> kexec/arch/i386/x86-linux-setup.c:511:9: note: each undeclared identifier is reported only once for each function it appears in
> make: *** [kexec/arch/i386/x86-linux-setup.o] Error 1
>
> This is due to the parameter change of function setup_linux_system_parameters,
> and the bug was imported by commit 6df15d1cca55b2cd59c79aed69f004e1b2a6ba36
> kexec x86: drop truncation warning for crash kernel
>
> The patch fix the bug.
>
> Reported-by: "CAI Qian" <caiqian@redhat.com>
> Signed-off-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
> ---
> kexec/arch/i386/x86-linux-setup.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kexec/arch/i386/x86-linux-setup.c b/kexec/arch/i386/x86-linux-setup.c
> index b903d43..454fad6 100644
> --- a/kexec/arch/i386/x86-linux-setup.c
> +++ b/kexec/arch/i386/x86-linux-setup.c
> @@ -508,7 +508,7 @@ void setup_linux_system_parameters(struct kexec_info *info,
> range = info->memory_range;
> ranges = info->memory_ranges;
> if (ranges > E820MAX) {
> - if (!(kexec_flags & KEXEC_ON_CRASH))
> + if (!(info->kexec_flags & KEXEC_ON_CRASH))
> /*
> * this e820 not used for capture kernel, see
> * do_bzImage_load()
>
It works for me.
Thanks,
WANG Chao
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-03-13 15:16 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-13 2:52 failed to compile kexec from git CAI Qian
2013-03-13 3:08 ` CAI Qian
2013-03-13 9:52 ` Simon Horman
2013-03-13 9:57 ` Zhang Yanfei
2013-03-13 15:16 ` Simon Horman
2013-03-13 3:19 ` Zhang Yanfei
2013-03-13 4:23 ` WANG Chao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox