From: "H. Peter Anvin" <hpa@zytor.com>
To: Dave Young <dyoung@redhat.com>, Matthew Garrett <mjg59@srcf.ucam.org>
Cc: kexec@lists.infradead.org, vgoyal@redhat.com,
James.Bottomley@HansenPartnership.com, horms@verge.net.au,
bp@alien8.de, ebiederm@xmission.com,
kexec@lists.fedoraproject.org
Subject: Re: [patch 2/4] remove extra acpi_rsdp command line for efi
Date: Tue, 29 Oct 2013 07:57:37 -0700 [thread overview]
Message-ID: <698b34fe-77c0-4924-bc10-b713f46b5f46@email.android.com> (raw)
In-Reply-To: <20131029085036.GB16009@dhcp-16-126.nay.redhat.com>
Seems reasonable to me.
Dave Young <dyoung@redhat.com> wrote:
>On 10/29/13 at 11:34am, Dave Young wrote:
>> On 10/29/13 at 11:05am, Dave Young wrote:
>> > On 10/28/13 at 06:53pm, Dave Young wrote:
>> > > On 10/28/13 at 10:51am, Matthew Garrett wrote:
>> > > > On Mon, Oct 28, 2013 at 06:45:32PM +0800, Dave Young wrote:
>> > > > > On 10/28/13 at 10:39am, Matthew Garrett wrote:
>> > > > > > On Mon, Oct 28, 2013 at 06:34:12PM +0800, Dave Young wrote:
>> > > > > > > On 10/28/13 at 10:12am, Matthew Garrett wrote:
>> > > > > > > > Right, but previously acpi_rsdp was passed
>automatically and now it
>> > > > > > > > won't be?
>> > > > > > >
>> > > > > > > Yes, it was. I'm removing them in kexec-tools patches for
>efi runtime support.
>> > > > > >
>> > > > > > If I upgrade kexec-tools and try to launch an old kernel, I
>now need to
>> > > > > > add an extra parameter?
>> > > > >
>> > > > > Yes, it should work by passing the acpi_rsdp= via --append
>> > > >
>> > > > Yes, that's my point. You're breaking old configurations by
>requiring
>> > > > the user to pass an additional argument.
>> > >
>> > > Hmm, I will do some test without this patch, if it works well
>it's not
>> > > harmful to drop this one.
>> >
>> > Removing this patch does not work because in this series efi_info
>is passed into
>> > 2nd kernel thus 2nd kernel will initilize efi but it does not have
>related code
>> > to handle the converted talbe addresses and it will endter virtual
>mode again.
>> >
>> > I will think about how to solve this problem.
>> >
>>
>> The only way what I can think out is introduce a flag in x86 setup
>header.
>> Will try this way, the userspace code will use old logic if the
>kernel is old.
>
>Firstly I want to ask opinion from HPA, what do you think about adding
>a flag to
>xloadflags for this purpose?
--
Sent from my mobile phone. Please pardon brevity and lack of formatting.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2013-10-29 15:00 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-27 4:04 [patch 0/4] kexec-tools: efi runtime support on kexec kernel dyoung
2013-10-27 4:04 ` [patch 1/4] Add function get_bootparam dyoung
2013-10-28 0:38 ` Simon Horman
2013-10-28 1:13 ` Dave Young
2013-10-28 2:30 ` Dave Young
2013-10-28 4:20 ` Simon Horman
2013-10-28 5:06 ` Dave Young
2013-10-28 6:08 ` Simon Horman
2013-10-27 4:04 ` [patch 2/4] remove extra acpi_rsdp command line for efi dyoung
2013-10-28 0:39 ` Simon Horman
2013-10-28 1:39 ` Dave Young
2013-10-28 9:42 ` Matthew Garrett
2013-10-28 9:54 ` Dave Young
2013-10-28 10:12 ` Matthew Garrett
2013-10-28 10:34 ` Dave Young
2013-10-28 10:39 ` Matthew Garrett
2013-10-28 10:45 ` Dave Young
2013-10-28 10:51 ` Matthew Garrett
2013-10-28 10:53 ` Dave Young
2013-10-29 3:05 ` Dave Young
2013-10-29 3:34 ` Dave Young
2013-10-29 8:50 ` Dave Young
2013-10-29 14:57 ` H. Peter Anvin [this message]
2013-10-28 16:10 ` Vivek Goyal
2013-10-29 2:04 ` Simon Horman
2013-10-29 2:36 ` Dave Young
2013-10-29 3:18 ` Dave Young
2013-10-30 0:45 ` Simon Horman
2013-10-29 13:27 ` Vivek Goyal
2013-10-27 4:04 ` [patch 3/4] Add efi_info in x86 setup header dyoung
2013-10-27 4:04 ` [patch 4/4] Passing efi related data via setup_data dyoung
2013-10-28 0:37 ` Simon Horman
2013-10-28 1:12 ` Dave Young
2013-10-28 3:02 ` Dave Young
2013-10-28 4:16 ` Simon Horman
2013-10-28 1:28 ` Dave Young
2013-10-28 10:41 ` H. Peter Anvin
2013-10-28 11:21 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=698b34fe-77c0-4924-bc10-b713f46b5f46@email.android.com \
--to=hpa@zytor.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bp@alien8.de \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.fedoraproject.org \
--cc=kexec@lists.infradead.org \
--cc=mjg59@srcf.ucam.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox