Re: [keyutils] Remove undefined functions afrom version.lds

[Nicholas Vinson <nvinson234@gmail.com>]

On 1/3/24 09:12, Jarkko Sakkinen wrote:
> On Wed Dec 27, 2023 at 11:35 PM EET, Nicholas Vinson wrote:
>> Functions keyctl_restrict() and keyctl_dh_compute_kdf_alloc() are
>> nodefined. Their inclusion in version.lds causes clang/llvm LTO
> What does "nodefined" mean?

It's a typographical error I failed to catch before sending the email.It 
is supposed to say "not defined".

>> optimizations to fail with error messages similar to
>>
>>      error: version script assignment of KEYUTILS_1.7 to symbol
>>      keyctl_restrict failed: symbol not defined
>>
>> This patch fixes the issue by removing the symbol names from
>> version.lds.
>>
>> Fixes Gentoo bug 914637 (https://bugs.gentoo.org/914637)
> I wonder if we can uses here "Closes: <url>" similarly as with
> kernel bugzilla (question to more broad audience)?
>
>> Signed-off-by: Nicholas Vinson<nvinson234@gmail.com>
>> ---
>>   version.lds | 2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/version.lds b/version.lds
>> index 6c34adf..6186fb6 100644
>> --- a/version.lds
>> +++ b/version.lds
>> @@ -76,9 +76,7 @@ KEYUTILS_1.6 {
>>   
>>   KEYUTILS_1.7 {
>>   	/* management functions */
>> -	keyctl_restrict;
>>   	keyctl_dh_compute_kdf;
>> -	keyctl_dh_compute_kdf_alloc;
>>   
>>   } KEYUTILS_1.6;
>>   
> BR, Jarkko