From: Ben Boeckel <me@benboeckel.net>
To: Nicholas Vinson <nvinson234@gmail.com>
Cc: keyrings@vger.kernel.org, dhowells@redhat.com
Subject: Re: [keyutils] Remove undefined functions afrom version.lds
Date: Wed, 27 Dec 2023 20:56:05 -0500 [thread overview]
Message-ID: <ZYzVtdviEYQ6AN-6@farprobe> (raw)
In-Reply-To: <85561febfcf0618a9280448d5c53775646f470d6.1703712863.git.nvinson234@gmail.com>
On Wed, Dec 27, 2023 at 16:35:16 -0500, Nicholas Vinson wrote:
> Functions keyctl_restrict() and keyctl_dh_compute_kdf_alloc() are
> nodefined. Their inclusion in version.lds causes clang/llvm LTO
> optimizations to fail with error messages similar to
>
> error: version script assignment of KEYUTILS_1.7 to symbol
> keyctl_restrict failed: symbol not defined
>
> This patch fixes the issue by removing the symbol names from
> version.lds.
FYI, there is also a GitLab repo here if you want to submit an MR:
https://gitlab.com/linux-afs/keyutils
I believe it has yet to be seen if this is preferred or GitLab. Or
whether the ML will get GitLab MR notifications.
--Ben
next prev parent reply other threads:[~2023-12-28 1:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-27 21:35 [keyutils] Remove undefined functions afrom version.lds Nicholas Vinson
2023-12-28 1:56 ` Ben Boeckel [this message]
2023-12-28 2:20 ` Nicholas Vinson
2024-01-03 14:16 ` Jarkko Sakkinen
2024-01-03 14:15 ` Jarkko Sakkinen
2024-01-03 14:12 ` Jarkko Sakkinen
2024-01-03 15:00 ` Nicholas Vinson
2024-03-04 6:06 ` Nicholas Vinson
2024-07-09 19:54 ` Nicholas Vinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYzVtdviEYQ6AN-6@farprobe \
--to=me@benboeckel.net \
--cc=dhowells@redhat.com \
--cc=keyrings@vger.kernel.org \
--cc=nvinson234@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox