[keyutils] Remove undefined functions afrom version.lds

[keyutils] Remove undefined functions afrom version.lds

[Nicholas Vinson]

Functions keyctl_restrict() and keyctl_dh_compute_kdf_alloc() are
nodefined. Their inclusion in version.lds causes clang/llvm LTO
optimizations to fail with error messages similar to

    error: version script assignment of KEYUTILS_1.7 to symbol
    keyctl_restrict failed: symbol not defined

This patch fixes the issue by removing the symbol names from
version.lds.

Fixes Gentoo bug 914637 (https://bugs.gentoo.org/914637)

Signed-off-by: Nicholas Vinson <nvinson234@gmail.com>
---
 version.lds | 2 --
 1 file changed, 2 deletions(-)

diff --git a/version.lds b/version.lds
index 6c34adf..6186fb6 100644
--- a/version.lds
+++ b/version.lds
@@ -76,9 +76,7 @@ KEYUTILS_1.6 {
 
 KEYUTILS_1.7 {
 	/* management functions */
-	keyctl_restrict;
 	keyctl_dh_compute_kdf;
-	keyctl_dh_compute_kdf_alloc;
 
 } KEYUTILS_1.6;
 
-- 
2.43.0

Re: [keyutils] Remove undefined functions afrom version.lds

[Ben Boeckel]

On Wed, Dec 27, 2023 at 16:35:16 -0500, Nicholas Vinson wrote:
> Functions keyctl_restrict() and keyctl_dh_compute_kdf_alloc() are
> nodefined. Their inclusion in version.lds causes clang/llvm LTO
> optimizations to fail with error messages similar to
> 
>     error: version script assignment of KEYUTILS_1.7 to symbol
>     keyctl_restrict failed: symbol not defined
> 
> This patch fixes the issue by removing the symbol names from
> version.lds.

FYI, there is also a GitLab repo here if you want to submit an MR:

    https://gitlab.com/linux-afs/keyutils

I believe it has yet to be seen if this is preferred or GitLab. Or
whether the ML will get GitLab MR notifications.

--Ben

Re: [keyutils] Remove undefined functions afrom version.lds

[Nicholas Vinson]

On 12/27/23 20:56, Ben Boeckel wrote:
> On Wed, Dec 27, 2023 at 16:35:16 -0500, Nicholas Vinson wrote:
>> Functions keyctl_restrict() and keyctl_dh_compute_kdf_alloc() are
>> nodefined. Their inclusion in version.lds causes clang/llvm LTO
>> optimizations to fail with error messages similar to
>>
>>      error: version script assignment of KEYUTILS_1.7 to symbol
>>      keyctl_restrict failed: symbol not defined
>>
>> This patch fixes the issue by removing the symbol names from
>> version.lds.
> FYI, there is also a GitLab repo here if you want to submit an MR:
>
>      https://gitlab.com/linux-afs/keyutils
>
> I believe it has yet to be seen if this is preferred or GitLab. Or
> whether the ML will get GitLab MR notifications.

Thanks for the information. Would it be possible to add the information 
to the SUBMITTING_PATCHES file?

Regards,

Nicholas Vinson

>
> --Ben

Re: [keyutils] Remove undefined functions afrom version.lds

[Jarkko Sakkinen]

On Thu Dec 28, 2023 at 4:20 AM EET, Nicholas Vinson wrote:
>
> On 12/27/23 20:56, Ben Boeckel wrote:
> > On Wed, Dec 27, 2023 at 16:35:16 -0500, Nicholas Vinson wrote:
> >> Functions keyctl_restrict() and keyctl_dh_compute_kdf_alloc() are
> >> nodefined. Their inclusion in version.lds causes clang/llvm LTO
> >> optimizations to fail with error messages similar to
> >>
> >>      error: version script assignment of KEYUTILS_1.7 to symbol
> >>      keyctl_restrict failed: symbol not defined
> >>
> >> This patch fixes the issue by removing the symbol names from
> >> version.lds.
> > FYI, there is also a GitLab repo here if you want to submit an MR:
> >
> >      https://gitlab.com/linux-afs/keyutils
> >
> > I believe it has yet to be seen if this is preferred or GitLab. Or
> > whether the ML will get GitLab MR notifications.
>
> Thanks for the information. Would it be possible to add the information 
> to the SUBMITTING_PATCHES file?

This Gitlab migration is recent and we have not yet made any decisions
on how to deal with merge requests, or block them entirely. It came just
before holidays.

BR, Jarkko

Re: [keyutils] Remove undefined functions afrom version.lds

[Jarkko Sakkinen]

On Thu Dec 28, 2023 at 3:56 AM EET, Ben Boeckel wrote:
> On Wed, Dec 27, 2023 at 16:35:16 -0500, Nicholas Vinson wrote:
> > Functions keyctl_restrict() and keyctl_dh_compute_kdf_alloc() are
> > nodefined. Their inclusion in version.lds causes clang/llvm LTO
> > optimizations to fail with error messages similar to
> > 
> >     error: version script assignment of KEYUTILS_1.7 to symbol
> >     keyctl_restrict failed: symbol not defined
> > 
> > This patch fixes the issue by removing the symbol names from
> > version.lds.
>
> FYI, there is also a GitLab repo here if you want to submit an MR:
>
>     https://gitlab.com/linux-afs/keyutils
>
> I believe it has yet to be seen if this is preferred or GitLab. Or
> whether the ML will get GitLab MR notifications.

David what is your take on Gitlab MR's? Do we accept them or not?

I've been working on CI test for keyutils (was unfinished before
holiday season came, have to backtrack where I left off), which
builds a small BuildRoot image and runs keyutils test suite inside
it (running it in runner directly is not really a great idea). So
I'm thinking once I get it finished, should I use the list or is
MR cool?

BR, Jarkko

Re: [keyutils] Remove undefined functions afrom version.lds

[Jarkko Sakkinen]

On Wed Dec 27, 2023 at 11:35 PM EET, Nicholas Vinson wrote:
> Functions keyctl_restrict() and keyctl_dh_compute_kdf_alloc() are
> nodefined. Their inclusion in version.lds causes clang/llvm LTO

What does "nodefined" mean?

> optimizations to fail with error messages similar to
>
>     error: version script assignment of KEYUTILS_1.7 to symbol
>     keyctl_restrict failed: symbol not defined
>
> This patch fixes the issue by removing the symbol names from
> version.lds.
>
> Fixes Gentoo bug 914637 (https://bugs.gentoo.org/914637)

I wonder if we can uses here "Closes: <url>" similarly as with
kernel bugzilla (question to more broad audience)?

>
> Signed-off-by: Nicholas Vinson <nvinson234@gmail.com>
> ---
>  version.lds | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/version.lds b/version.lds
> index 6c34adf..6186fb6 100644
> --- a/version.lds
> +++ b/version.lds
> @@ -76,9 +76,7 @@ KEYUTILS_1.6 {
>  
>  KEYUTILS_1.7 {
>  	/* management functions */
> -	keyctl_restrict;
>  	keyctl_dh_compute_kdf;
> -	keyctl_dh_compute_kdf_alloc;
>  
>  } KEYUTILS_1.6;
>  

BR, Jarkko

Re: [keyutils] Remove undefined functions afrom version.lds

[Nicholas Vinson]

On 1/3/24 09:12, Jarkko Sakkinen wrote:
> On Wed Dec 27, 2023 at 11:35 PM EET, Nicholas Vinson wrote:
>> Functions keyctl_restrict() and keyctl_dh_compute_kdf_alloc() are
>> nodefined. Their inclusion in version.lds causes clang/llvm LTO
> What does "nodefined" mean?

It's a typographical error I failed to catch before sending the email.It 
is supposed to say "not defined".

>> optimizations to fail with error messages similar to
>>
>>      error: version script assignment of KEYUTILS_1.7 to symbol
>>      keyctl_restrict failed: symbol not defined
>>
>> This patch fixes the issue by removing the symbol names from
>> version.lds.
>>
>> Fixes Gentoo bug 914637 (https://bugs.gentoo.org/914637)
> I wonder if we can uses here "Closes: <url>" similarly as with
> kernel bugzilla (question to more broad audience)?
>
>> Signed-off-by: Nicholas Vinson<nvinson234@gmail.com>
>> ---
>>   version.lds | 2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/version.lds b/version.lds
>> index 6c34adf..6186fb6 100644
>> --- a/version.lds
>> +++ b/version.lds
>> @@ -76,9 +76,7 @@ KEYUTILS_1.6 {
>>   
>>   KEYUTILS_1.7 {
>>   	/* management functions */
>> -	keyctl_restrict;
>>   	keyctl_dh_compute_kdf;
>> -	keyctl_dh_compute_kdf_alloc;
>>   
>>   } KEYUTILS_1.6;
>>   
> BR, Jarkko

Re: [keyutils] Remove undefined functions afrom version.lds

[Nicholas Vinson]

On 1/3/24 10:00, Nicholas Vinson wrote:
> 
> On 1/3/24 09:12, Jarkko Sakkinen wrote:
>> On Wed Dec 27, 2023 at 11:35 PM EET, Nicholas Vinson wrote:
>>> Functions keyctl_restrict() and keyctl_dh_compute_kdf_alloc() are
>>> nodefined. Their inclusion in version.lds causes clang/llvm LTO
>> What does "nodefined" mean?
> 
> It's a typographical error I failed to catch before sending the email.It 
> is supposed to say "not defined".
> 
>>> optimizations to fail with error messages similar to
>>>
>>>      error: version script assignment of KEYUTILS_1.7 to symbol
>>>      keyctl_restrict failed: symbol not defined
>>>
>>> This patch fixes the issue by removing the symbol names from
>>> version.lds.
>>>
>>> Fixes Gentoo bug 914637 (https://bugs.gentoo.org/914637)
>> I wonder if we can uses here "Closes: <url>" similarly as with
>> kernel bugzilla (question to more broad audience)?
>>
>>> Signed-off-by: Nicholas Vinson<nvinson234@gmail.com>
>>> ---
>>>   version.lds | 2 --
>>>   1 file changed, 2 deletions(-)
>>>
>>> diff --git a/version.lds b/version.lds
>>> index 6c34adf..6186fb6 100644
>>> --- a/version.lds
>>> +++ b/version.lds
>>> @@ -76,9 +76,7 @@ KEYUTILS_1.6 {
>>>   KEYUTILS_1.7 {
>>>       /* management functions */
>>> -    keyctl_restrict;
>>>       keyctl_dh_compute_kdf;
>>> -    keyctl_dh_compute_kdf_alloc;
>>>   } KEYUTILS_1.6;
>> BR, Jarkko

May I get a status update for this PR please?

Thanks,
Nicholas Vinson

Re: [keyutils] Remove undefined functions afrom version.lds

[Nicholas Vinson]

On 3/4/24 01:06, Nicholas Vinson wrote:
> 
> 
> On 1/3/24 10:00, Nicholas Vinson wrote:
>>
>> On 1/3/24 09:12, Jarkko Sakkinen wrote:
>>> On Wed Dec 27, 2023 at 11:35 PM EET, Nicholas Vinson wrote:
>>>> Functions keyctl_restrict() and keyctl_dh_compute_kdf_alloc() are
>>>> nodefined. Their inclusion in version.lds causes clang/llvm LTO
>>> What does "nodefined" mean?
>>
>> It's a typographical error I failed to catch before sending the 
>> email.It is supposed to say "not defined".
>>
>>>> optimizations to fail with error messages similar to
>>>>
>>>>      error: version script assignment of KEYUTILS_1.7 to symbol
>>>>      keyctl_restrict failed: symbol not defined
>>>>
>>>> This patch fixes the issue by removing the symbol names from
>>>> version.lds.
>>>>
>>>> Fixes Gentoo bug 914637 (https://bugs.gentoo.org/914637)
>>> I wonder if we can uses here "Closes: <url>" similarly as with
>>> kernel bugzilla (question to more broad audience)?
>>>
>>>> Signed-off-by: Nicholas Vinson<nvinson234@gmail.com>
>>>> ---
>>>>   version.lds | 2 --
>>>>   1 file changed, 2 deletions(-)
>>>>
>>>> diff --git a/version.lds b/version.lds
>>>> index 6c34adf..6186fb6 100644
>>>> --- a/version.lds
>>>> +++ b/version.lds
>>>> @@ -76,9 +76,7 @@ KEYUTILS_1.6 {
>>>>   KEYUTILS_1.7 {
>>>>       /* management functions */
>>>> -    keyctl_restrict;
>>>>       keyctl_dh_compute_kdf;
>>>> -    keyctl_dh_compute_kdf_alloc;
>>>>   } KEYUTILS_1.6;
>>> BR, Jarkko
> 
> May I get a status update for this PR please?
> 
> Thanks,
> Nicholas Vinson

Hello, any status updates on this? It's been about 4 months since my 
last request and I haven't heard anything.

Thanks,
Nicholas Vinson