Kernel keyring development
 help / color / mirror / Atom feed
From: Nicholas Vinson <nvinson234@gmail.com>
To: Ben Boeckel <me@benboeckel.net>
Cc: keyrings@vger.kernel.org, dhowells@redhat.com
Subject: Re: [keyutils] Remove undefined functions afrom version.lds
Date: Wed, 27 Dec 2023 21:20:13 -0500	[thread overview]
Message-ID: <fe5c7770-7fbc-4332-aa85-80e281cda8c2@gmail.com> (raw)
In-Reply-To: <ZYzVtdviEYQ6AN-6@farprobe>


On 12/27/23 20:56, Ben Boeckel wrote:
> On Wed, Dec 27, 2023 at 16:35:16 -0500, Nicholas Vinson wrote:
>> Functions keyctl_restrict() and keyctl_dh_compute_kdf_alloc() are
>> nodefined. Their inclusion in version.lds causes clang/llvm LTO
>> optimizations to fail with error messages similar to
>>
>>      error: version script assignment of KEYUTILS_1.7 to symbol
>>      keyctl_restrict failed: symbol not defined
>>
>> This patch fixes the issue by removing the symbol names from
>> version.lds.
> FYI, there is also a GitLab repo here if you want to submit an MR:
>
>      https://gitlab.com/linux-afs/keyutils
>
> I believe it has yet to be seen if this is preferred or GitLab. Or
> whether the ML will get GitLab MR notifications.

Thanks for the information. Would it be possible to add the information 
to the SUBMITTING_PATCHES file?

Regards,

Nicholas Vinson

>
> --Ben

  reply	other threads:[~2023-12-28  2:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-27 21:35 [keyutils] Remove undefined functions afrom version.lds Nicholas Vinson
2023-12-28  1:56 ` Ben Boeckel
2023-12-28  2:20   ` Nicholas Vinson [this message]
2024-01-03 14:16     ` Jarkko Sakkinen
2024-01-03 14:15   ` Jarkko Sakkinen
2024-01-03 14:12 ` Jarkko Sakkinen
2024-01-03 15:00   ` Nicholas Vinson
2024-03-04  6:06     ` Nicholas Vinson
2024-07-09 19:54       ` Nicholas Vinson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe5c7770-7fbc-4332-aa85-80e281cda8c2@gmail.com \
    --to=nvinson234@gmail.com \
    --cc=dhowells@redhat.com \
    --cc=keyrings@vger.kernel.org \
    --cc=me@benboeckel.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox