public inbox for kvm-ppc@vger.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH] powerpc kvm: fix kvmppc_start_thread() for CONFIG_SMP=N
       [not found] <12283.1320977000@neuling.org>
@ 2011-11-11 16:01 ` Alexander Graf
  2011-11-12  4:07   ` Michael Neuling
  0 siblings, 1 reply; 2+ messages in thread
From: Alexander Graf @ 2011-11-11 16:01 UTC (permalink / raw)
  To: Michael Neuling; +Cc: Paul Mackerras, kvm-ppc, linuxppc-dev

On 11/11/2011 03:03 AM, Michael Neuling wrote:
> Currently kvmppc_start_thread() tries to wake other SMT threads via
> xics_wake_cpu().  Unfortunately xics_wake_cpu only exists when
> CONFIG_SMP=Y so when compiling with CONFIG_SMP=N we get:
>
>    arch/powerpc/kvm/built-in.o: In function `.kvmppc_start_thread':
>    book3s_hv.c:(.text+0xa1e0): undefined reference to `.xics_wake_cpu'
>
> The following should be fine since kvmppc_start_thread() shouldn't
> called to start non-zero threads when SMP=N since threads_per_core=1.
>
> Signed-off-by: Michael Neuling<mikey@neuling.org>

Thanks, applied to kvm-ppc-next. Please CC kvm-ppc@vger next time :).


Alex


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] powerpc kvm: fix kvmppc_start_thread() for CONFIG_SMP=N
  2011-11-11 16:01 ` [PATCH] powerpc kvm: fix kvmppc_start_thread() for CONFIG_SMP=N Alexander Graf
@ 2011-11-12  4:07   ` Michael Neuling
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Neuling @ 2011-11-12  4:07 UTC (permalink / raw)
  To: Alexander Graf; +Cc: Paul Mackerras, kvm-ppc, linuxppc-dev

In message <4EBD46F4.5040503@suse.de> you wrote:
> On 11/11/2011 03:03 AM, Michael Neuling wrote:
> > Currently kvmppc_start_thread() tries to wake other SMT threads via
> > xics_wake_cpu().  Unfortunately xics_wake_cpu only exists when
> > CONFIG_SMP=Y so when compiling with CONFIG_SMP=N we get:
> >
> >    arch/powerpc/kvm/built-in.o: In function `.kvmppc_start_thread':
> >    book3s_hv.c:(.text+0xa1e0): undefined reference to `.xics_wake_cpu'
> >
> > The following should be fine since kvmppc_start_thread() shouldn't
> > called to start non-zero threads when SMP=N since threads_per_core=1.
> >
> > Signed-off-by: Michael Neuling<mikey@neuling.org>
> 
> Thanks, applied to kvm-ppc-next. Please CC kvm-ppc@vger next time :).

Thanks will do.

Mikey

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-11-12  4:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <12283.1320977000@neuling.org>
2011-11-11 16:01 ` [PATCH] powerpc kvm: fix kvmppc_start_thread() for CONFIG_SMP=N Alexander Graf
2011-11-12  4:07   ` Michael Neuling

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox